All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Tianyang Zhang <zhangtianyang@loongson.cn>,
	chenhuacai@kernel.org, kernel@xen0n.name, corbet@lwn.net,
	alexs@kernel.org, si.yanteng@linux.dev, jiaxun.yang@flygoat.com,
	maobibo@loongson.cn
Cc: loongarch@lists.linux.dev, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Tianyang Zhang <zhangtianyang@loongson.cn>
Subject: Re: [PATCH v11 2/4] irqchip/irq-loonarch-avec: Prepare for interrupt redirection support
Date: Tue, 03 Feb 2026 18:17:05 +0100	[thread overview]
Message-ID: <87tsvx3fxq.ffs@tglx> (raw)
In-Reply-To: <20260203124522.2288900-3-zhangtianyang@loongson.cn>

On Tue, Feb 03 2026 at 20:45, Tianyang Zhang wrote:

$Subject: irqchip/irq-loonarch-avec

I know you blindly copied my suggestion and obviously you failed to spot
the missing 'g'.

> Interrupt redirection support requires a new interrupt chip, which
> needs to share data structures, constants and functions with the AVEC
> code.
>
> Move them to the header file and make the required functions public.

But then you still keep this nonsense around, which has no place in the
change log as I explained to you before:

  "Enumerating the details of what is moved is a pointless exercise
   because that can bee seen from the diff itself."

What's so hard about that to understand?

Just in case I'm not able to express myself coherently, this means:

Remove the following 4 lines:

> including:
> 1 marco AVEC_MSG_OFFSET
> 2 struct avecintc_data
> 3 Make avecintc_sync public

Sigh. Though I have to admit that 'loonarch' gave me a good laugh at
least.

Thanks,

        tglx

  reply	other threads:[~2026-02-03 17:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-03 12:45 [PATCH v11 0/4] Loongarch irq-redirect support Tianyang Zhang
2026-02-03 12:45 ` [PATCH v11 1/4] Docs/LoongArch: Add Advanced Extended-Redirect IRQ model description Tianyang Zhang
2026-02-03 12:45 ` [PATCH v11 2/4] irqchip/irq-loonarch-avec: Prepare for interrupt redirection support Tianyang Zhang
2026-02-03 17:17   ` Thomas Gleixner [this message]
2026-02-03 17:19     ` Thomas Gleixner
2026-02-04  1:26     ` Tianyang Zhang
2026-02-03 12:45 ` [PATCH v11 3/4] irqchip/loongarch-avec.c: return IRQ_SET_MASK_OK_DONE when keep affinity Tianyang Zhang
2026-02-03 12:45 ` [PATCH v11 4/4] irqchip/irq-loongarch-ir:Add Redirect irqchip support Tianyang Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tsvx3fxq.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=alexs@kernel.org \
    --cc=chenhuacai@kernel.org \
    --cc=corbet@lwn.net \
    --cc=jiaxun.yang@flygoat.com \
    --cc=kernel@xen0n.name \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loongarch@lists.linux.dev \
    --cc=maobibo@loongson.cn \
    --cc=si.yanteng@linux.dev \
    --cc=zhangtianyang@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.