From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A96BD3C526 for ; Wed, 10 Dec 2025 14:34:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 4975260893; Wed, 10 Dec 2025 14:34:57 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id O6Vyhj6BGoJ9; Wed, 10 Dec 2025 14:34:55 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 760F26075D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1765377295; bh=GXu+C6jn4wjNW66trWRFDg4n3Pcoz6KWv3Dl/BCG4/U=; h=From:To:Cc:In-Reply-To:References:Date:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=BkwP/ehYgvea1X0sl3G1uvjVj6S4FLncW1/1vhLAtEMCSrg/WZxCwfau9aNl3JBGn 5Ah9GqivrcY/AEiY+tzXEAQZ2tc0dAwSMapn4u27/5vPEqkhSKqT4F2dVAFBMokDwR Qv4K0NnINI1ow0ClW5BP8tC3e/CF1BuxY+W/FPOOfPPps/CLVSwM9X0MUq0lwXFJU9 YgyERBTzJpv18D8k4ZRzyoXtZdN3m1U7Jy9+jpFphBZWsF+js0fYCbNC1MZYsaF6zX Kq3FpoF8/G3aaiSooeFBzRQ27kHCp9hwSuAgVC3o4RVArCLlFzRQTOeBTUeT5E1B86 P+KXXyzxJ8f9A== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 760F26075D; Wed, 10 Dec 2025 14:34:55 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists1.osuosl.org (Postfix) with ESMTP id 9E8E8E7 for ; Wed, 10 Dec 2025 14:34:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 90C0F40804 for ; Wed, 10 Dec 2025 14:34:53 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id V8FHaLD-TFaL for ; Wed, 10 Dec 2025 14:34:53 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a0a:51c0:0:12e:550::1; helo=galois.linutronix.de; envelope-from=kurt@linutronix.de; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org B15CC407CA DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org B15CC407CA Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by smtp4.osuosl.org (Postfix) with ESMTPS id B15CC407CA for ; Wed, 10 Dec 2025 14:34:52 +0000 (UTC) From: Kurt Kanzenbach To: "Behera, VIVEK" , "Loktionov, Aleksandr" , "Keller, Jacob E" , "Nguyen, Anthony L" , "Kitszel, Przemyslaw" , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: "intel-wired-lan@lists.osuosl.org" In-Reply-To: References: <4c90ed4e-307c-429a-9f8c-29032cc146ee@intel.com> <878qfaabgn.fsf@jax.kurt.home> Date: Wed, 10 Dec 2025 15:34:46 +0100 Message-ID: <87tsxymmm1.fsf@jax.kurt.home> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1765377287; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GXu+C6jn4wjNW66trWRFDg4n3Pcoz6KWv3Dl/BCG4/U=; b=T6j3yqIVmBeB0ZISQ7pXgIvc+wlse/GfbOpdZTxduJssaJ+ou0LW7vpx+FNuqPsJLYj1rI TjLshd3OS52nWERDFmkRTgLsq/HnJwMsgmUQNgB4LS3rrGh/wsWUlIpcM2rgD2RfDQf7Vj mtlFN5JUhmSWkrCuPtGQeb366BI1jjgq5FuFBoClOuQlnIUQYiC3HhV8jLlpmJyFog+bUx d2NSXeVsK+elSnZ1vUHLZjIvxUwvzyu2uudDaFzK7rIqKbA1lAOlQ0pXW1IH2GpFqiBKVF uA3UYmPH+4jshBxw+xttRHEkOmPfLyr11iOOnjcX3ubwKoKkbdTfmh98JtJtCQ== X-Mailman-Original-DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1765377287; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GXu+C6jn4wjNW66trWRFDg4n3Pcoz6KWv3Dl/BCG4/U=; b=qo4CQNBpydMgYbtx5IzbN0U3qtcMhvxqHRnrhntUgZhqptowtBxu/gQTW3kDa0pDyPSGfJ KfBH2p47p9CRN8Dw== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=none dis=none) header.from=linutronix.de X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=linutronix.de header.i=@linutronix.de header.a=rsa-sha256 header.s=2020 header.b=T6j3yqIV; dkim=pass header.d=linutronix.de header.i=@linutronix.de header.a=ed25519-sha256 header.s=2020e header.b=qo4CQNBp Subject: Re: [Intel-wired-lan] [PATCH v5 iwl-net] igc: Fix trigger of incorrect irq in igc_xsk_wakeup function X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" --=-=-= Content-Type: text/plain On Wed Dec 10 2025, Behera, VIVEK wrote: > On Wed Dec 10 2025, Kurt Kanzenbach wrote: >> On Wed Dec 10 2025, Behera, VIVEK wrote: >>> Changes in v5: >>> - Updated comment style from multi-star to standard /* */ as suggested by Aleksandr. >>> >>> From ab2583ff8a17405d3aa6caf4df1c4fdfb21f5e98 Mon Sep 17 00:00:00 2001 >>> From: Vivek Behera >>> Date: Fri, 5 Dec 2025 10:26:05 +0100 >>> Subject: [PATCH v5] [iwl-net] igc: Fix trigger of incorrect irq in >>> igc_xsk_wakeup function >>> >>> This patch addresses the issue where the igc_xsk_wakeup function was >>> triggering an incorrect IRQ for tx-0 when the i226 is configured with >>> only 2 combined queues or in an environment with 2 active CPU cores. >>> This prevented XDP Zero-copy send functionality in such split IRQ >>> configurations. >>> >>> The fix implements the correct logic for extracting q_vectors saved >>> during rx and tx ring allocation and utilizes flags provided by the >>> ndo_xsk_wakeup API to trigger the appropriate IRQ. >>> >>> Changed comment blocks to align with standard Linux comments >>> >>> Fixes: fc9df2a0b520d7d439ecf464794d53e91be74b93 ("igc: Enable RX via >>> AF_XDP zero-copy") >>> Fixes: 15fd021bc4270273d8f4b7f58fdda8a16214a377 ("igc: Add Tx hardware >>> timestamp request for AF_XDP zero-copy packet") >>> Signed-off-by: Vivek Behera >>> Reviewed-by: Jacob Keller >>> Reviewed-by: Aleksandr loktinov >> >> Hi, >> >> thanks for this fix. Does the same issue also exist for i210 in the igb driver? The igb driver also has this split IRQ configuration with 2 queues. Might be good to fix this one as well :). >> >> Thanks, >> Kurt > > Hi Kurt, > > The issue so far has not popped up in i210 igb driver for XDP ZC send > but will impact the xsk_wakeup attempting to wakeup the RX irqs or > both Rx and Tx (for.e.g in xsk_poll) if IRQ configuration is with 2 > queues. Essentially same logic submitted in the patch is needed for > igb. I am preparing a patch for the igb aswell. However, I would wait > for submission until I manage to resolve the formatting and other > guideline related issue pointed out by Jakub in the igc patch. Sounds great. Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJHBAEBCgAxFiEEvLm/ssjDfdPf21mSwZPR8qpGc4IFAmk5hQYTHGt1cnRAbGlu dXRyb25peC5kZQAKCRDBk9HyqkZzguaED/0RHqQGYwR2cNrg6ozr/W/x0636Bc7C V1E1anymBBnf18gJPwYvFBPLlxcUsId07oOEVPRI9E2NMj0/0DGFedzUX+WNqspB ncAOU075/J/IH7sVtbra5VKqg5dDkSnBSgCGpFY8P0RoAoJAJhiMEd30fQjE5PUm mqNslkKqWQ+llA/8Vwp2tZEZYvOKGXQofPGq1NVX4E/bbxHl1z4ThlCc0FOniMJT mIueeuQLNM+EwC5g5hXzkEfcmMsOYgjPd8waVd8AWc4wOBN7SFb+r2OHWQN6YsMx e+NHzm6aZs+H6TaGjAbrTVJzd/7osBMefOK5d1i1QCuPoTLQMtNv3Nr0usFDw8sW nCR8/43nVv6Ho5Y1uL+pGKlnLtnAoqQjkFFjp59CTrgKKxQAbrIQZwHtJYlcJ3Ir E47s51QmBafxYKKpqMmqWvhjIKp51vJ+ciJfWtLRCMSqm0q+skERvvzGbAawM62R AbsL2a7OzrN+bu94XaIWKjmqjJsHhHGvCVuAjMG98EChbqVdRlgH3he6XuZ1HegX ngeZOW7ViGWOkLa3YgxFuW8+c480VqQ48uaA+2RkYFy/kihPfalsf+NtLGpxJfMk UQcttAUhQrWIGcZrPul76QTeOHBopj59HoQrriatrJUWRSgpduwdkAnbYzX+BE79 IMypurogsOBBug== =lLxh -----END PGP SIGNATURE----- --=-=-=--