From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB36713E41A for ; Fri, 21 Nov 2025 17:10:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763745057; cv=none; b=d41vpla5IFYthfZDA1ZrigdOs/HiuDwLNX4ugXfB7y5RR0PKkwr9C+lSWXupqpTejUV+8BCJtNwbtqOBibWehWUg/gkKSN6OfvbH4j7VE4l5/A4soTXNxbuA32PYvCTXIWD2AnoROsDLPsgjDM96NIgZ4rn1necubTnqk+3jRKM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763745057; c=relaxed/simple; bh=diQQ9efbudWXHMRJgu6j772FEhzSohEJPueR8ASeAUQ=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=n/30iioeqqpt+E9xgdyAEjZV0WC5v1enBQXx8+sHjuW+of12DXppwELPXi9GhFCeG0Q/p0x5lIMD8NUtq17tqBzvI5khpMfz6sPQTrAkA6Wa8VbMyutGZQLWl/RHczXZ1lJZ/bS2U4SeQglectK18e/YzNHtaVIlXam9aatw1z8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lzvfIlhx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lzvfIlhx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 571D8C4CEF1; Fri, 21 Nov 2025 17:10:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763745057; bh=diQQ9efbudWXHMRJgu6j772FEhzSohEJPueR8ASeAUQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lzvfIlhxbAUc/21VQb+ADGLjg2w8UQBnV+lND6+uxO6kJLovtRF6T5vZPKy4f8AC9 n4gPCAP/4GOWNNaHAv2vH6QbCZmTnKKVgGJFUf5CebVd1qYnyXMnKnSb3Zw3zKoOfm +tEurXlXjUZxO56LWVjnXWYC5bEV1MFcxAC3ESC/omxr104vjdQh9tJFCxVEThRQZm wQy73Vdtak1BTPWXe62c0WQV2eUAt5lwDt+Oa2gLC5rcClhR57xnEPhQrEWT5t/KeU 4DIYgGjEsWjbBfQZ9YtkAksYX81nFTJX/eQRM4eIe6h1iozA6Z+j9qAzSqD7g0X5of jNDvojeqXBqmQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=lobster-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vMUes-00000007Is5-3pXX; Fri, 21 Nov 2025 17:10:55 +0000 Date: Fri, 21 Nov 2025 17:10:54 +0000 Message-ID: <87tsynfh0h.wl-maz@kernel.org> From: Marc Zyngier To: Oliver Upton Cc: kvmarm@lists.linux.dev, Joey Gouly , Suzuki K Poulose , Zenghui Yu Subject: Re: [PATCH v2 06/14] KVM: arm64: Call helper for reading descriptors directly In-Reply-To: <20251117224325.2431848-7-oupton@kernel.org> References: <20251117224325.2431848-1-oupton@kernel.org> <20251117224325.2431848-7-oupton@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: oupton@kernel.org, kvmarm@lists.linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 17 Nov 2025 22:43:17 +0000, Oliver Upton wrote: > > Going through a function pointer doesn't serve much purpose when there's > only one implementation. > > Signed-off-by: Oliver Upton > --- > arch/arm64/kvm/nested.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/arch/arm64/kvm/nested.c b/arch/arm64/kvm/nested.c > index 08839a320a45..cf4b24e04a1a 100644 > --- a/arch/arm64/kvm/nested.c > +++ b/arch/arm64/kvm/nested.c > @@ -124,7 +124,6 @@ int kvm_vcpu_init_nested(struct kvm_vcpu *vcpu) > } > > struct s2_walk_info { > - int (*read_desc)(phys_addr_t pa, u64 *desc, void *data); > void *data; > u64 baddr; > unsigned int max_oa_bits; > @@ -199,6 +198,15 @@ static int check_output_size(struct s2_walk_info *wi, phys_addr_t output) > return 0; > } > > +static int read_guest_s2_desc(phys_addr_t pa, u64 *desc, void *data) > +{ > + struct kvm_vcpu *vcpu = data; > + u64 val; > + int r; Unused variables, better moved to the follow-up patch. Thanks, M. -- Jazz isn't dead. It just smells funny.