From: Markus Armbruster <armbru@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org,
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Subject: Re: [PULL 12/12] qapi: Add documentation format validation
Date: Wed, 05 Nov 2025 15:21:56 +0100 [thread overview]
Message-ID: <87tsz8lfuj.fsf@pond.sub.org> (raw)
In-Reply-To: <dfa1aec7-3449-48bf-867d-14b9b2cfeddb@linaro.org> (Richard Henderson's message of "Wed, 5 Nov 2025 14:41:26 +0100")
Richard Henderson <richard.henderson@linaro.org> writes:
> On 11/4/25 14:21, Markus Armbruster wrote:
>> @@ -423,12 +428,55 @@ def get_doc_line(self) -> Optional[str]:
>> if self.val != '##':
>> raise QAPIParseError(
>> self, "junk after '##' at end of documentation comment")
>> + self._literal_mode = False
>> return None
>> if self.val == '#':
>> return ''
>> if self.val[1] != ' ':
>> raise QAPIParseError(self, "missing space after #")
>> - return self.val[2:].rstrip()
>> +
>> + line = self.val[2:].rstrip()
>> +
>> + if re.match(r'(\.\. +qmp-example)? *::$', line):
>> + self._literal_mode = True
>> + self._literal_mode_indent = 0
>> + elif self._literal_mode and line:
>> + indent = re.match(r'^ *', line).end()
>
> Another failure from my incomplete testing last night:
>
> https://gitlab.com/qemu-project/qemu/-/jobs/11982687207#L127
>
> ../scripts/qapi/parser.py:444: error: Item "None" of "Optional[Match[str]]" has no attribute "end" [union-attr]
Missed in review, sorry. I'll post a fix a.s.a.p. Thanks!
next prev parent reply other threads:[~2025-11-05 14:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 13:21 [PULL 00/12] QAPI patches for 2025-11-04 Markus Armbruster
2025-11-04 13:21 ` [PULL 01/12] qapi/command: Avoid generating unused qmp_marshal_output_T() Markus Armbruster
2025-11-04 13:21 ` [PULL 02/12] meson: Add missing backends.py to qapi_gen_depends Markus Armbruster
2025-11-04 13:21 ` [PULL 03/12] qapi/audio: Fix description markup of AudiodevDBusOptions @nsamples Markus Armbruster
2025-11-04 13:21 ` [PULL 04/12] qapi: Refill doc comments to conform to conventions Markus Armbruster
2025-11-04 13:21 ` [PULL 05/12] qapi: Clean up whitespace between definitions Markus Armbruster
2025-11-04 13:21 ` [PULL 06/12] qga/qapi-schema: Refill doc comments to conform to conventions Markus Armbruster
2025-11-04 13:21 ` [PULL 07/12] qga/qapi-schema: Clean up whitespace between definitions Markus Armbruster
2025-11-04 13:21 ` [PULL 08/12] docs/interop: Refill QAPI doc comments to conform to conventions Markus Armbruster
2025-11-04 13:21 ` [PULL 09/12] docs/interop/vhost-user: Belatedly convert "Example" section Markus Armbruster
2025-11-04 13:21 ` [PULL 10/12] docs/interop/firmware: Literal block markup Markus Armbruster
2025-11-04 13:21 ` [PULL 11/12] docs/interop: Add test to keep vhost-user.json sane Markus Armbruster
2025-11-04 13:21 ` [PULL 12/12] qapi: Add documentation format validation Markus Armbruster
2025-11-05 13:41 ` Richard Henderson
2025-11-05 14:21 ` Markus Armbruster [this message]
2025-11-05 12:28 ` [PULL 00/12] QAPI patches for 2025-11-04 Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tsz8lfuj.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.