From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16657CCD1BC for ; Thu, 23 Oct 2025 10:27:38 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vBsXD-0004x1-G7; Thu, 23 Oct 2025 06:27:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vBsX9-0004wm-0x for qemu-devel@nongnu.org; Thu, 23 Oct 2025 06:27:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vBsX7-00060x-0M for qemu-devel@nongnu.org; Thu, 23 Oct 2025 06:27:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761215219; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QO3fnkjbCt16+DrOUgXq8HZ3/DkqCTJdXfbUoxoVCNs=; b=GAplqSa1gM/2yy6AsKqImjk8TJYB1WjSzDuTjIp8C5/KTUqY7kf9MGXnDo6zT/Gw8CmeR4 493u1V+1StDBiYr7UCTZHMmjPqtGZjGpKe7i1yAF7JdsWjWq/0xeGJ6WISfp7E9tESpdRj 8DADMlBPwfosSBvGYpmXNAtb2sMzWqg= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-489-l8yZFuFcO8KUbBGSd_hs5w-1; Thu, 23 Oct 2025 06:26:57 -0400 X-MC-Unique: l8yZFuFcO8KUbBGSd_hs5w-1 X-Mimecast-MFC-AGG-ID: l8yZFuFcO8KUbBGSd_hs5w_1761215216 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AC9D91800669; Thu, 23 Oct 2025 10:26:56 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.19]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4361B180045B; Thu, 23 Oct 2025 10:26:56 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 6CAFF21E6A27; Thu, 23 Oct 2025 12:26:53 +0200 (CEST) From: Markus Armbruster To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= Cc: qemu-devel@nongnu.org, Thomas Huth , Stefan Hajnoczi , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Peter Maydell , Paolo Bonzini , "Michael S. Tsirkin" Subject: Re: [PATCH v2 01/32] qom: replace 'abstract' with 'flags' In-Reply-To: <20250926140144.1998694-2-berrange@redhat.com> ("Daniel P. =?utf-8?Q?Berrang=C3=A9=22's?= message of "Fri, 26 Sep 2025 15:01:12 +0100") References: <20250926140144.1998694-1-berrange@redhat.com> <20250926140144.1998694-2-berrange@redhat.com> Date: Thu, 23 Oct 2025 12:26:53 +0200 Message-ID: <87tszp9amq.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Daniel P. Berrang=C3=A9 writes: > This will allow extra boolean flags without expending the memory "expanding", I guess. > usage of the Type struct. > > Signed-off-by: Daniel P. Berrang=C3=A9 According to pahole, we currently have 7 unused bytes right after @abstract. So this will pay off after the eighth flag, or the fourth if something else plugs into the hole. According to size, qemu-system-x86_64's text grows by 64 bytes. > --- > qom/object.c | 21 ++++++++++++++------- > 1 file changed, 14 insertions(+), 7 deletions(-) I wouldn't bother :)