Re: [PATCH] hw/arm/boot: replace fprintf with error_report

["Alex Bennée" <alex.bennee@linaro.org>]

Osama Abdelkader <osama.abdelkader@gmail.com> writes:

> On Mon, Sep 01, 2025 at 05:59:03PM +0100, Alex Bennée wrote:
>> Peter Maydell <peter.maydell@linaro.org> writes:
>> 
>> > On Sat, 23 Aug 2025 at 16:03, Osama Abdelkader
>> > <osama.abdelkader@gmail.com> wrote:
>> >>
>> >> Replace direct fprintf(stderr, …) with QEMU's error_report() API,
>> >> which ensures consistent formatting and integrates with QEMU's
>> >> logging infrastructure.
>> >>
>> >> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
>> >> ---
>> >>  hw/arm/boot.c | 22 +++++++++++-----------
>> >>  1 file changed, 11 insertions(+), 11 deletions(-)
>> >
>> >
>> >
>> > Applied to target-arm.next, thanks.
>> 
>> I didn't see this had been posted but I did a more extensive clean-up
>> here:
>> 
>>   Message-ID: <20250901125304.1047624-1-alex.bennee@linaro.org>
>>   Date: Mon,  1 Sep 2025 13:53:00 +0100
>>   Subject: [PATCH 0/4] arm_load_dtb cleanups
>>   From: =?UTF-8?q?Alex=20Benn=C3=A9e?= <alex.bennee@linaro.org>
>> 
>> >
>> > -- PMM
>> 
>> -- 
>> Alex Bennée
>> Virtualisation Tech Lead @ Linaro
>
> sorry Alex, I didn't know that your patch set covers that.

No need to apologise - qemu-devel is a firehose of patches so its
inevitable two or more people might touch the same thing at the same
time.

> I just submitted a simple patch to replace fprintf in raspi4b
> Would appreciate your review.

I have left some comments.

>
> Thank you.
>
> Regards,
> Osama

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro