From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1433CCA0FE1 for ; Mon, 25 Aug 2025 12:03:02 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uqVtw-0003LV-NG; Mon, 25 Aug 2025 08:02:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uqVtk-00036C-Aj for qemu-devel@nongnu.org; Mon, 25 Aug 2025 08:02:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uqVta-0000HQ-JS for qemu-devel@nongnu.org; Mon, 25 Aug 2025 08:02:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756123307; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BUJNRG8pGC3kfqMLzf4LFlqDWNHpW8iE2kSuIt5cgco=; b=JY9B+ZUIttbS3iYpYqoVzBOkiMUi+YoxmHj2vMAPfCuUkhibEUIwiO5zGSt/vXg1Q71i7e 8ABew6boLF5+FJm/6dRhnZrg8JTR/KJJ5hKSmzAXQNPjWIJ7dAUnm9y4J6MryEMHPgLlUw 7APC7yw0yHc6nIvwGRR8zsr81WW9m8I= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-148-YVvKw4FkMz2NumBzNmIDCw-1; Mon, 25 Aug 2025 08:01:42 -0400 X-MC-Unique: YVvKw4FkMz2NumBzNmIDCw-1 X-Mimecast-MFC-AGG-ID: YVvKw4FkMz2NumBzNmIDCw_1756123301 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3A9F018011E1; Mon, 25 Aug 2025 12:01:38 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.4]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C4837195419F; Mon, 25 Aug 2025 12:01:37 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 4DC5321E6A27; Mon, 25 Aug 2025 14:01:35 +0200 (CEST) From: Markus Armbruster To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= Cc: qemu-devel@nongnu.org, Stefan Hajnoczi , Michael Roth , Paolo Bonzini , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Mads Ynddal , Alex =?utf-8?Q?Benn=C3=A9e?= , Thomas Huth Subject: Re: [PATCH v3 8/8] qapi: switch to use QEMU_TEST_REGENERATE env var In-Reply-To: ("Daniel P. =?utf-8?Q?Berrang?= =?utf-8?Q?=C3=A9=22's?= message of "Mon, 18 Aug 2025 16:09:37 +0100") References: <20250806164832.1382919-1-berrange@redhat.com> <20250806164832.1382919-9-berrange@redhat.com> <87cy96mhu5.fsf@pond.sub.org> Date: Mon, 25 Aug 2025 14:01:35 +0200 Message-ID: <87tt1vsj8g.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Daniel P. Berrang=C3=A9 writes: > On Fri, Aug 08, 2025 at 08:46:10AM +0200, Markus Armbruster wrote: >> Daniel P. Berrang=C3=A9 writes: >>=20 >> > The QAPI_TEST_UPDATE env var can be set when running the QAPI >> > schema tests to regenerate the reference output. For consistent >> > naming with the tracetool test, change the env var name to >> > QEMU_TEST_REGENERATE. >> > >> > The test is modified to provide a hint about use of the new >> > env var and it is also added to the developer documentation.document i= ts usage. >> > >> > Signed-off-by: Daniel P. Berrang=C3=A9 [...] >> > index 4be930228c..cf7fb8a6df 100755 >> > --- a/tests/qapi-schema/test-qapi.py >> > +++ b/tests/qapi-schema/test-qapi.py >> > @@ -165,7 +165,7 @@ def test_and_diff(test_name, dir_name, update): >> > if actual_out =3D=3D expected_out and actual_err =3D=3D expected_= err: >> > return 0 >> >=20=20 >> > - print("%s %s" % (test_name, 'UPDATE' if update else 'FAIL'), >> > + print("%s: %s" % (test_name, 'UPDATE' if update else 'FAIL'), >>=20 >> Is there a need for this, or is it just drive-by polishing? > > Just making it more consistent in style with other error print() > statements we have in the file, as well as this new one I'm > adding. Which existing print()s do you mean? > >>=20 >> > file=3Dsys.stderr) >> > out_diff =3D difflib.unified_diff(expected_out, actual_out, outfp= .name) >> > err_diff =3D difflib.unified_diff(expected_err, actual_err, errfp= .name) >> > @@ -173,6 +173,9 @@ def test_and_diff(test_name, dir_name, update): >> > sys.stdout.writelines(err_diff) >> >=20=20 >> > if not update: >> > + print(("\n%s: set QEMU_TEST_REGENERATE=3D1 to recreate refere= nce output" + >> > + "if the QAPI schema generator was intentionally change= d") % test_name, >> > + file=3Dsys.stderr) >> > return 1 >> >=20=20 >> > try: >> > @@ -197,7 +200,7 @@ def main(argv): >> > parser.add_argument('-d', '--dir', action=3D'store', default=3D'', >> > help=3D"directory containing tests") >> > parser.add_argument('-u', '--update', action=3D'store_true', >> > - default=3D'QAPI_TEST_UPDATE' in os.environ, >> > + default=3D'QEMU_TEST_REGENERATE' in os.enviro= n, >> > help=3D"update expected test results") >> > parser.add_argument('tests', nargs=3D'*', metavar=3D'TEST', actio= n=3D'store') >> > args =3D parser.parse_args()