From: Fabiano Rosas <farosas@suse.de>
To: Prasad Pandit <ppandit@redhat.com>
Cc: qemu-devel@nongnu.org, "Peter Xu" <peterx@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Peter Maydell" <peter.maydell@linaro.org>
Subject: Re: [PATCH 1/2] migration: Fix postcopy latency distribution formatting computation
Date: Thu, 17 Jul 2025 09:35:09 -0300 [thread overview]
Message-ID: <87tt3bknb6.fsf@suse.de> (raw)
In-Reply-To: <CAE8KmOxPLS9Zd+_uGRSBJwxDb6NcqOnLK7bTLeJ0mKKUs+gMxg@mail.gmail.com>
Prasad Pandit <ppandit@redhat.com> writes:
> On Wed, 16 Jul 2025 at 19:06, Fabiano Rosas <farosas@suse.de> wrote:
>> The condition should be >=.
>
> * I'm thinking of doing away with the loop and the string array. The
> array has 3 values of which only one gets used due to conversion to
> seconds.
The point is not to convert to seconds, but to fit the number of
microseconds in a range. Take a look at the output of 'info migrate -a'
with postcopy-blocktime capability enabled.
>
>> But then that's "0 sec" for 1000000 us.
>
> #define US (MS * 1000) => 1000000
>
> When us = 1000000, us / US should return "1 sec", no?
>
Sorry, I meant when the number of microseconds is smaller than a second.
> Thank you.
> ---
> - Prasad
next prev parent reply other threads:[~2025-07-17 20:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 12:45 [PATCH 0/2] migration: Fix possible access out of bounds Fabiano Rosas
2025-07-15 12:45 ` [PATCH 1/2] migration: Fix postcopy latency distribution formatting computation Fabiano Rosas
2025-07-15 14:01 ` Philippe Mathieu-Daudé
2025-07-16 10:26 ` Prasad Pandit
2025-07-16 13:36 ` Fabiano Rosas
2025-07-17 6:28 ` Prasad Pandit
2025-07-17 12:35 ` Fabiano Rosas [this message]
2025-07-17 13:31 ` Daniel P. Berrangé
2025-07-15 12:45 ` [PATCH 2/2] cutils: Add time_us_to_str Fabiano Rosas
2025-07-15 14:02 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tt3bknb6.fsf@suse.de \
--to=farosas@suse.de \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.