From: Dave Marquardt <davemarq@linux.ibm.com>
To: Breno Leitao <leitao@debian.org>
Cc: Jakub Kicinski <kuba@kernel.org>,
davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
dw@davidwei.uk
Subject: Re: [PATCH net] net: drv: netdevsim: don't napi_complete() from netpoll
Date: Thu, 12 Jun 2025 08:11:21 -0500 [thread overview]
Message-ID: <87tt4lm7eu.fsf@linux.ibm.com> (raw)
In-Reply-To: <aEqIqDwHUGcblXjT@gmail.com> (Breno Leitao's message of "Thu, 12 Jun 2025 00:58:32 -0700")
Breno Leitao <leitao@debian.org> writes:
> Hello Dave,
>
> On Wed, Jun 11, 2025 at 05:23:33PM -0500, Dave Marquardt wrote:
>> Jakub Kicinski <kuba@kernel.org> writes:
>>
>> > netdevsim supports netpoll. Make sure we don't call napi_complete()
>> > from it, since it may not be scheduled. Breno reports hitting a
>> > warning in napi_complete_done():
>>
>> I decided to go learn a bit more about netdevsim, and ran across a typo
>> in Documentation/networking/devlink/netdevsim.rst:
>
> I acknowledge the bug exists in the latest netnext/main repo. Would you
> like to send a patch and fix it, or, should we?
I'll send in a patch. Thanks.
> Thanks for reporting it.
You're welcome!
-Dave
next prev parent reply other threads:[~2025-06-12 13:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 17:46 [PATCH net] net: drv: netdevsim: don't napi_complete() from netpoll Jakub Kicinski
2025-06-11 22:23 ` Dave Marquardt
2025-06-12 7:58 ` Breno Leitao
2025-06-12 13:11 ` Dave Marquardt [this message]
2025-06-12 8:53 ` Breno Leitao
2025-06-12 15:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tt4lm7eu.fsf@linux.ibm.com \
--to=davemarq@linux.ibm.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.