From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A2E3C5AD49 for ; Fri, 6 Jun 2025 19:21:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E8D7010EBAA; Fri, 6 Jun 2025 19:21:13 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="SIuPY96b"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id A9EEE10EBAA for ; Fri, 6 Jun 2025 19:21:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1749237673; x=1780773673; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=MPV79muJWmm4suMc7q2pVqo0EDf/1JWKcgisx0S9MD4=; b=SIuPY96bS2FBD+3pCLfzsGdiipcxvuJNp2EjXQuy3RTnOu94m4gyItyW wDFtaVBthG18KFOTcCca4QrLQwSJaevO7vKOitZsGwPyhlAcKsUzIbcTe QHtlBj0bi8nS1lnINX/yBtleqjcHORaUAcx03qCy98iDgdBB9NKG5580w /fJf71KF6/j/RgXwESx9hw46B7G4gch2m321PvXNFy7wWMdFx4Nv1sScm BeTLzgmuhNCNpSUGzCY2EovLVsvnz54Q0wVbjPKtb0lkuhWY+QsG/ZbOp 7HlTbuE/7vUuhWnP5bFmLHb1ELOZMauybpSpQ7DCfoWqcbsVnE3+hHqUB Q==; X-CSE-ConnectionGUID: we3NGw+DSHOKWFvRcUOcww== X-CSE-MsgGUID: H3CssF7GTYOirzHVNeiFug== X-IronPort-AV: E=McAfee;i="6800,10657,11456"; a="55057976" X-IronPort-AV: E=Sophos;i="6.16,216,1744095600"; d="scan'208";a="55057976" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jun 2025 12:21:13 -0700 X-CSE-ConnectionGUID: JL3mMZvwQmGs4BeDjBaeig== X-CSE-MsgGUID: zmF1epTeQbWK2HqbrljPpQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,216,1744095600"; d="scan'208";a="150920629" Received: from paulineh-mobl1.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.85.143]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jun 2025 12:21:12 -0700 Date: Fri, 06 Jun 2025 12:21:11 -0700 Message-ID: <87tt4su15k.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa Cc: Subject: Re: [PATCH 1/5] drm/xe/oa/uapi: Expose media OA units In-Reply-To: References: <20250606160253.4054668-1-ashutosh.dixit@intel.com> <20250606160253.4054668-2-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Fri, 06 Jun 2025 10:37:53 -0700, Umesh Nerlige Ramappa wrote: > > On Fri, Jun 06, 2025 at 09:02:49AM -0700, Ashutosh Dixit wrote: > > On Xe2+ platforms, media engines are attached to "SCMI" OA media (OAM) > > units. One or more SCMI OAM units might be present on a platform. In > > addition there is another OAM unit for global events, called > > OAM-SAG. Performance metrics for media workloads can be obtained from these > > OAM units, similar to OAG. > > > > Expose these OAM units for userspace to use. OAM-SAG is exposed as an OA > > unit without any attached engines. > > > > Bspec: 70819, 67103, 63844, 72572, 74476, 61284 > > > > v2: Fix xe_gt_WARN_ON in __hwe_oam_unit for < 12.7 platforms > > v3: Return XE_OA_UNIT_INVALID for < 12.7 to indicate no OAM units > > v4: Move xe_oa_print_oa_units() to separate patch > > v5: Introduce DRM_XE_OA_UNIT_TYPE_OAM_SAG > > > > Signed-off-by: Ashutosh Dixit > > LGTM, > > Reviewed-by: Umesh Nerlige Ramappa Thanks Umesh. I also just added a DRM_XE_OA_CAPS_OAM capability also to this patch. I was debating initially, since userland will see at least 2 OAM units after this series is merged, so that is the way to figure out if correct OAM support is present in the driver. But then went ahead and added DRM_XE_OA_CAPS_OAM, since that's how we've been doing things: if you change uapi, you add a capability. Thanks.