From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 545B0C54E65 for ; Thu, 22 May 2025 07:12:08 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [45.14.194.44]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8021C601F4; Thu, 22 May 2025 09:11:56 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8021C601F4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1747897926; bh=IxVcX9HAZDAVXLWQOfYITQ7JI6BdE+h8bpaoqjA7gg8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=hhSRTyj6kB5RCoghsrgfxBhVxU7edqYRwx5ADRAx8RC7WUEFeJtBh4QPvYuYUlRTE T3tDie9XkXWMG9vm+kLv6E0ttSrzsCzMNL/sewckPHNxsPtciylMyYPBoi5cDVqa8E 4SU2Kb+0QwqH/Ka2mcS9kluKZdwfhRtKqoEHB3lw= Received: by alsa1.perex.cz (Postfix, from userid 50401) id E68EFF805BB; Thu, 22 May 2025 09:11:32 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id D1070F805B6; Thu, 22 May 2025 09:11:32 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E690FF8056F; Thu, 22 May 2025 09:11:29 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1003BF80549 for ; Thu, 22 May 2025 09:11:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1003BF80549 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=xSnonLeg; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=UZjJFHgq; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=koxIp/ic; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ku5C2E9w Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E7F4D22475; Thu, 22 May 2025 07:11:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1747897887; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Qf0+/c0ivuvI5IZj8NYoK+iuFx23I/xdZAXK+xWly14=; b=xSnonLegHQfJA2BiOniv6NIBTGOjvKT+PREc4bwtuVt4hyKl74bMEeKiy/t+46rjwmhZ77 lcZRyDqwMFMI0SKmJ+iHBBMF2GrgR/0VSF2o71eX1A5NCYKMdcRriKZEiJv4lGbSs7FJnz dEWCEmWE1VF8+ABcJUYX1/8n6c8UwRU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1747897887; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Qf0+/c0ivuvI5IZj8NYoK+iuFx23I/xdZAXK+xWly14=; b=UZjJFHgqVVZMevkcCh4PuOeo/VmhnD7K8BkXq2txLL5YOdTKr07zFZn+J7toK9Ddp3qsk8 0IDu95R9O9RNoQBw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="koxIp/ic"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ku5C2E9w DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1747897886; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Qf0+/c0ivuvI5IZj8NYoK+iuFx23I/xdZAXK+xWly14=; b=koxIp/icmX3WpaD7nDbVNuIyWQCbow/JExCec2UQ6QOSgxwjKDMKZgrVGtB/fIVvipKmhn gcACNv25f33Kf+VgTP1n3vUHvU7jJa52kTkjv4tDiioN/VhQ3gHZfXIBASQGNOAR7+WDBK ou4LraumyCdvixGztN1Xo+tiHRaZmt4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1747897886; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Qf0+/c0ivuvI5IZj8NYoK+iuFx23I/xdZAXK+xWly14=; b=ku5C2E9wpUhRxWAJUxlCNwFh+RtGn4nvZRsnB91/LAbhB8v9EK4YBq213dxl1NfdFpeV9L zxzMfTaRLMMno2Ag== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B860913433; Thu, 22 May 2025 07:11:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id FF0uLB7OLmgOCAAAD6G6ig (envelope-from ); Thu, 22 May 2025 07:11:26 +0000 Date: Thu, 22 May 2025 09:11:26 +0200 Message-ID: <87tt5d86ht.wl-tiwai@suse.de> From: Takashi Iwai To: Shenghao Ding Cc: , , <13564923607@139.com>, <13916275206@139.com>, , , , , Subject: Re: [PATCH v1] ALSA: hda/tas2781: Move and unified the calibrated-data getting function for SPI and I2C into the tas2781_hda lib. In-Reply-To: <20250522014347.1163-1-shenghao-ding@ti.com> References: <20250522014347.1163-1-shenghao-ding@ti.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spamd-Result: default: False [-3.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[139.com]; FREEMAIL_CC(0.00)[kernel.org,linux.intel.com,139.com,alsa-project.org,vger.kernel.org,ti.com,fpt.com]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_SEVEN(0.00)[10]; DKIM_TRACE(0.00)[suse.de:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:dkim,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo] X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: E7F4D22475 Message-ID-Hash: P4LAH26KY54VF7NS23RT4S3WIYZ3CDXL X-Message-ID-Hash: P4LAH26KY54VF7NS23RT4S3WIYZ3CDXL X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 22 May 2025 03:43:47 +0200, Shenghao Ding wrote: > > Calibration data getting function for SPI and I2C HDA drivers are almost > same, which read the calibration data from UEFI. To put them into > tas2781_hda lib for code cleanup is more reasonable than to still keep > them in the codec driver. For tas2781 codec driver, there're two different > sources for calibrated data, one is from bin file, generated in factory > test, requested and read in codec driver side; the other is from user > space during device bootup. > > Signed-off-by: Shenghao Ding Applied now. Thanks. Takashi