From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Zixun LI <admin@hifiphile.com>
Cc: Lukasz Majewski <lukma@denx.de>, Marek Vasut <marex@denx.de>,
u-boot@lists.denx.de
Subject: Re: [PATCH 0/4] usb: gadget: f_mass_storage: Fix crashes on low memory devices
Date: Sat, 29 Mar 2025 11:04:39 +0100 [thread overview]
Message-ID: <87tt7c885k.fsf@baylibre.com> (raw)
In-Reply-To: <CA+GyqeZwrAaQ_7DcvY6VgnVo0WTsMBiZsKZBmWVzQu2CAL6_xQ@mail.gmail.com>
Hi Zixun,
On ven., mars 28, 2025 at 18:38, Zixun LI <admin@hifiphile.com> wrote:
> On Fri, Mar 28, 2025 at 9:15 AM Mattijs Korpershoek
> <mkorpershoek@baylibre.com> wrote:
>> This series fixes the above mentioned crash by introducing proper error
>> handling and freeing the buffers in the unbind callback.
>
> Hi Mattijs,
>
> Thank you for the quick fix, I've tested on SAM9X60 with multiple ums
> commands and it works.
Thank you for testing. Testing on hardware is very valuable to the
U-Boot community.
It is so valuable that we give credit in the commit history for testing.
In order to give you proper credit for testing, a special email line is
expected to be found:
"""
Tested-by: Zixun LI <admin@hifiphile.com>
"""
You can also specify on which board you've tested:
"""
Tested-by: Zixun LI <admin@hifiphile.com> # on SAM9X60
"""
This allows tools to automatically pick up your testing efforts and put
them in the commit log.
See: https://docs.u-boot.org/en/latest/develop/process.html#review-process-git-tags
If you are OK with being mentioned in the commit log, could you please
answer this email thread with the special "Tested-by:" line.
Also, do not hesitate to use that in the future.
Thanks again for contributing to U-Boot!
Mattijs
>
> Zixun
next prev parent reply other threads:[~2025-03-29 10:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 8:15 [PATCH 0/4] usb: gadget: f_mass_storage: Fix crashes on low memory devices Mattijs Korpershoek
2025-03-28 8:15 ` [PATCH 1/4] usb: gadget: f_mass_storage: Remove kref structure use Mattijs Korpershoek
2025-03-28 8:15 ` [PATCH 2/4] usb: gadget: f_mass_storage: Drop invalid kfree() in fsg_common_release() Mattijs Korpershoek
2025-03-28 8:15 ` [PATCH 3/4] usb: gadget: f_mass_storage: Fix NULL dereference in fsg_add() Mattijs Korpershoek
2025-03-28 8:15 ` [PATCH 4/4] usb: gadget: f_mass_storage: Fix memory leak of fsg buffers Mattijs Korpershoek
2025-03-28 17:38 ` [PATCH 0/4] usb: gadget: f_mass_storage: Fix crashes on low memory devices Zixun LI
2025-03-29 10:04 ` Mattijs Korpershoek [this message]
2025-03-29 10:54 ` Zixun LI
2025-04-10 8:48 ` Mattijs Korpershoek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tt7c885k.fsf@baylibre.com \
--to=mkorpershoek@baylibre.com \
--cc=admin@hifiphile.com \
--cc=lukma@denx.de \
--cc=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.