Re: Cross-compilation artifact is broken

["Alex Bennée" <alex.bennee@linaro.org>]

Konstantin Kostiuk <kkostiuk@redhat.com> writes:

> On Wed, Mar 12, 2025 at 6:24 PM Alex Bennée <alex.bennee@linaro.org> wrote:
>
>  Daniel P. Berrangé <berrange@redhat.com> writes:
>
>  > On Wed, Mar 12, 2025 at 02:05:09PM +0000, Daniel P. Berrangé wrote:
>  >> On Wed, Mar 12, 2025 at 03:52:45PM +0200, Konstantin Kostiuk wrote:
>  >> > Hi All,
>  >> > 
>  >> > I cross-compiled qemu-ga from current master branch
>  >> > (825b96dbcee23d134b691fc75618b59c5f53da32) and found strange behavior.
>  >> > 
<snip>
>  >> > My question is, is this expected behavior or is this a bug?
>  >> 
>  >> Your configure args don't include "--enable-debug", so I would
>  >> not have expected -gsplit-dwarf to have been enabled, so I'm
>  >> surprised that commit casued a problem.
>  >
>  > Hmm it appears that the meson  "get_option('debug')" is entirely
>  > unconnected to QEMU's --enable-debug configure flag, which I did
>  > not realize.
>  >
>  > IOW, we've got -gsplit-dwarf enabled by default for everyone
>  > building QEMU, which feels dubious. IMHO only an explicit
>  > --enable-debug configure arg should have triggered it.
>
>  --enable-debug is more than debug info, --enable-debug-info is enabled
>  by default. If you build with --disable-debug-info then -gsplit-dwarf
>  won't be applied.
>
> But as this broke the Windows build, maybe we should disable this for Windows
> until resolve this problem

Something like:

if host_os != 'windows'
  if get_option('debug') and get_option('split_debug')
    qemu_cflags += '-gsplit-dwarf'
  endif
endif

>  
>  >
>  > In addition since its breaking Windows builds, it appears we
>  > need to block its usage on Windows.
>  >
>  >
>  > With regards,
>  > Daniel
>
>  -- 
>  Alex Bennée
>  Virtualisation Tech Lead @ Linaro

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro