All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Vitaly Rodionov <vitalyr@opensource.cirrus.com>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
	<linux-sound@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<patches@opensource.cirrus.com>
Subject: Re: [PATCH 1/2 v2] ALSA: hda/cirrus: Correct the full scale volume set logic
Date: Sat, 15 Feb 2025 08:40:24 +0100	[thread overview]
Message-ID: <87tt8vpsev.wl-tiwai@suse.de> (raw)
In-Reply-To: <20250214210736.30814-1-vitalyr@opensource.cirrus.com>

On Fri, 14 Feb 2025 22:07:28 +0100,
Vitaly Rodionov wrote:
> 
> This patch corrects the full-scale volume setting logic. On certain
> platforms, the full-scale volume bit is required. The current logic
> mistakenly sets this bit and incorrectly clears reserved bit 0, causing
> the headphone output to be muted.
> 
> Fixies: 342b6b610ae2 (ALSA: hda/cs8409: Fix Full Scale Volume setting for all variants)

It should be "Fixes" :)
Also, the tag should be in the form of
  Fixes: $ID ("$SUBJECT")
with quotes.  I fixed and applied now.


thanks,

Takashi

      reply	other threads:[~2025-02-15  7:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-14 21:07 [PATCH 1/2 v2] ALSA: hda/cirrus: Correct the full scale volume set logic Vitaly Rodionov
2025-02-15  7:40 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tt8vpsev.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=vitalyr@opensource.cirrus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.