From: Kalle Valo <kvalo@kernel.org>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] wifi: ath9k: use unsigned long for activity check timestamp
Date: Thu, 16 Jan 2025 13:20:07 +0200 [thread overview]
Message-ID: <87tt9zm2e0.fsf@kernel.org> (raw)
In-Reply-To: <20250115171750.259917-2-dmantipov@yandex.ru> (Dmitry Antipov's message of "Wed, 15 Jan 2025 20:17:50 +0300")
Dmitry Antipov <dmantipov@yandex.ru> writes:
> Since 'rx_active_check_time' of 'struct ath_softc' is in jiffies,
> prefer 'unsigned long' over 'u32' to avoid possible truncation in
> 'ath_hw_rx_inactive_check()'. Found with clang's -Wshorten-64-to-32,
> compile tested only.
>
> Fixes: b5f871ab4913 ("wifi: ath9k: Add RX inactivity detection and reset chip when it occurs")
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
I don't think this should have a Fixes either. Jeff, can you remove
these during commit?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2025-01-16 11:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 17:17 [PATCH 1/2] wifi: ath9k: cleanup struct ath_tx_control and ath_tx_prepare() Dmitry Antipov
2025-01-15 17:17 ` [PATCH 2/2] wifi: ath9k: use unsigned long for activity check timestamp Dmitry Antipov
2025-01-16 11:05 ` Toke Høiland-Jørgensen
2025-01-16 11:20 ` Kalle Valo [this message]
2025-01-16 17:41 ` Jeff Johnson
2025-01-16 11:05 ` [PATCH 1/2] wifi: ath9k: cleanup struct ath_tx_control and ath_tx_prepare() Toke Høiland-Jørgensen
2025-01-16 11:19 ` Kalle Valo
2025-01-16 17:42 ` Jeff Johnson
2025-01-17 23:41 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tt9zm2e0.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=dmantipov@yandex.ru \
--cc=linux-wireless@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.