From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434b0d9bed7sm201495695e9.8.2024.12.03.10.10.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2024 10:10:45 -0800 (PST) Received: from draig (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 216345F78C; Tue, 3 Dec 2024 18:10:44 +0000 (GMT) From: =?utf-8?Q?Alex_Benn=C3=A9e?= To: Peter Maydell Cc: Pierrick Bouvier , qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Richard Henderson , Andrew Melnychenko , Daniel P. =?utf-8?Q?Berrang=C3=A9?= , Jason Wang , Thomas Huth , Vladimir Sementsov-Ogievskiy , Fabiano Rosas , Kevin Wolf , Markus Armbruster , Eric Blake , qemu-arm@nongnu.org, Yuri Benditovich , manos.pitsidianakis@linaro.org, qemu-block@nongnu.org, Michael Roth , Konstantin Kostiuk , Paolo Bonzini , Peter Xu , gustavo.romero@linaro.org Subject: Re: [PATCH 6/7] docs: add a glossary In-Reply-To: (Peter Maydell's message of "Tue, 3 Dec 2024 17:37:22 +0000") References: <20241118172357.475281-1-pierrick.bouvier@linaro.org> <20241118172357.475281-7-pierrick.bouvier@linaro.org> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Tue, 03 Dec 2024 18:10:44 +0000 Message-ID: <87ttbkbpsr.fsf@draig.linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-TUID: xUpXNRrow4uw Peter Maydell writes: > On Mon, 18 Nov 2024 at 17:24, Pierrick Bouvier > wrote: >> >> Signed-off-by: Pierrick Bouvier >> --- >> docs/devel/control-flow-integrity.rst | 2 + >> docs/devel/multi-thread-tcg.rst | 2 + >> docs/glossary/index.rst | 238 ++++++++++++++++++++++++++ >> docs/index.rst | 1 + >> docs/system/arm/virt.rst | 2 + >> docs/system/images.rst | 2 + >> docs/tools/qemu-nbd.rst | 2 + >> 7 files changed, 249 insertions(+) >> create mode 100644 docs/glossary/index.rst > > I think this is a good idea; we've had at least one bug > report from a user pointing out that we had a term in > our docs which we didn't define ("block driver"): > https://gitlab.com/qemu-project/qemu/-/issues/2611 > I have some comments on specific entries below. > >> diff --git a/docs/devel/control-flow-integrity.rst b/docs/devel/control-= flow-integrity.rst >> index e6b73a4fe1a..3d5702fa4cc 100644 >> --- a/docs/devel/control-flow-integrity.rst >> + >> +Device >> +------ >> + >> +QEMU is able to emulate a CPU, and all the hardware interacting with it, >> +including many devices. When QEMU runs a virtual machine using a hardwa= re-based >> +accelerator, it is responsible for emulating, using software, all devic= es. > > This definition doesn't actually define what a device is :-) Also we can xref to: https://qemu.readthedocs.io/en/v9.1.0/system/device-emulation.html where we go into a bit more detail about what a device, bus, frontend and backend are. > >> + >> +EDK2 >> +---- >> + >> +EDK2, as known as `TianoCore `_, is an open= source >> +implementation of UEFI standard. It's ran by QEMU to support UEFI for v= irtual >> +machines. > > Replace last sentence with > "QEMU virtual machines that boot a UEFI BIOS usually use EDK2." > ? > --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro