From: Fabiano Rosas <farosas@suse.de>
To: Peter Xu <peterx@redhat.com>
Cc: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
qemu-devel@nongnu.org, linuxarm@huawei.com,
zhangfei.gao@linaro.org
Subject: Re: [PATCH] migration/multifd: Fix compile error caused by page_size usage
Date: Tue, 03 Dec 2024 14:59:12 -0300 [thread overview]
Message-ID: <87ttbkir67.fsf@suse.de> (raw)
In-Reply-To: <Z09AZ06nSg2R_TIZ@x1n>
Peter Xu <peterx@redhat.com> writes:
> On Tue, Dec 03, 2024 at 10:17:14AM -0300, Fabiano Rosas wrote:
>> Shameer Kolothum via <qemu-devel@nongnu.org> writes:
>>
>> > From Commit 90fa121c6c07 ("migration/multifd: Inline page_size and
>> > page_count") onwards page_size is not part of MutiFD*Params but uses
>> > an inline constant instead.
>> >
>> > However, it missed updating an old usage, causing a compile error.
>> >
>> > Fixes: 90fa121c6c07 ("migration/multifd: Inline page_size and page_count")
>> > Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
>>
>> Reviewed-by: Fabiano Rosas <farosas@suse.de>
>
> Wanna pick this up for your qtest pull for 10.0 altogether?
Yep
next prev parent reply other threads:[~2024-12-03 18:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 12:49 [PATCH] migration/multifd: Fix compile error caused by page_size usage Shameer Kolothum via
2024-12-03 13:17 ` Fabiano Rosas
2024-12-03 17:31 ` Peter Xu
2024-12-03 17:59 ` Fabiano Rosas [this message]
2025-01-12 13:04 ` Michael Tokarev
2025-01-13 12:55 ` Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttbkir67.fsf@suse.de \
--to=farosas@suse.de \
--cc=linuxarm@huawei.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.