All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: David Wang <00107082@163.com>
Cc: kees@kernel.org, linux-kernel@vger.kernel.org,
	geert@linux-m68k.org, David Wang <00107082@163.com>
Subject: Re: [PATCH 2/3] irqchip: Fix a potential abuse of seq_printf() format string
Date: Tue, 03 Dec 2024 12:22:46 +0100	[thread overview]
Message-ID: <87ttblt3i1.ffs@tglx> (raw)
In-Reply-To: <762e88c3e940bd6087c35b599f2c88baff775c6b.1732093745.git.00107082@163.com>

On Wed, Nov 20 2024 at 17:17, David Wang wrote:
> Using device name as format string of seq_printf() is prone to
> "Format string attack", opens possibility for exploitation.
> Seq_puts() is safer and more efficient.

I agree that seq_puts() is more efficient, but this whole handwaving
about format string attacks is far fetched.

These strings originate from device tree or generated device/domain
names. If they contain format strings, then that's either a plain bug in
the kernel or the device tree, but far from a 'format string attack'.

Thanks,

        tglx

  reply	other threads:[~2024-12-03 11:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-20  9:14 [PATCH 1/3] gpio: Fix a potential abuse of seq_printf() format string David Wang
2024-11-20  9:17 ` [PATCH 2/3] irqchip: " David Wang
2024-12-03 11:22   ` Thomas Gleixner [this message]
2024-12-03 12:00     ` David Wang
2024-11-20  9:18 ` [PATCH 3/3] pinctrl: " David Wang
2024-11-20 11:04 ` [PATCH 1/3] gpio: " Geert Uytterhoeven
2024-11-20 11:41   ` David Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttblt3i1.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=00107082@163.com \
    --cc=geert@linux-m68k.org \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.