From: Thomas Gleixner <tglx@linutronix.de>
To: Richard Cochran <richardcochran@gmail.com>
Cc: "Dalmas, Marcelo (GE Vernova)" <marcelo.dalmas@ge.com>,
"jstultz@google.com" <jstultz@google.com>,
"sboyd@kernel.org" <sboyd@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ntp: fix bug in adjtimex reading time offset
Date: Wed, 27 Nov 2024 18:35:18 +0100 [thread overview]
Message-ID: <87ttbsy3zd.ffs@tglx> (raw)
In-Reply-To: <Z0dDOje96uI_t9sd@hoboy.vegasvil.org>
On Wed, Nov 27 2024 at 08:05, Richard Cochran wrote:
> On Wed, Nov 27, 2024 at 03:10:30PM +0100, Thomas Gleixner wrote:
> The patch was generated by the following coccinelle script:
>
> ...
>
> So I guess combining random other manual fixes into a patch that
> claims to be generated is a bad idea?
Indeed. I just figured out why the cast is there. txc::time_offset is of
type 'long long', so the division triggers a build fail on 32-bit.
It want's to be:
txc->time_offset = div_s64(txc->time_offset, NSEC_PER_USEC);
....
next prev parent reply other threads:[~2024-11-27 17:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 12:16 [PATCH] ntp: fix bug in adjtimex reading time offset Dalmas, Marcelo (GE Vernova)
2024-11-27 14:10 ` Thomas Gleixner
2024-11-27 16:05 ` Richard Cochran
2024-11-27 17:35 ` Thomas Gleixner [this message]
2024-11-27 17:39 ` Thomas Gleixner
2024-11-28 10:54 ` Thomas Gleixner
2024-11-27 17:33 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttbsy3zd.ffs@tglx \
--to=tglx@linutronix.de \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.dalmas@ge.com \
--cc=richardcochran@gmail.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.