From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17FC2D2F7C0 for ; Wed, 16 Oct 2024 21:01:38 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t1B8S-0006kF-3W; Wed, 16 Oct 2024 17:00:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1B8Q-0006jy-Fw for qemu-devel@nongnu.org; Wed, 16 Oct 2024 17:00:46 -0400 Received: from smtp-out2.suse.de ([2a07:de40:b251:101:10:150:64:2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t1B8M-0006z3-KI for qemu-devel@nongnu.org; Wed, 16 Oct 2024 17:00:46 -0400 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3AE411FD0B; Wed, 16 Oct 2024 21:00:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1729112438; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M0saLAt62sotpchHFuArnJMILAtW+DmUbux1LuP9cMU=; b=QaXX1y7Jucpxnb/tZDUg1un7//MSDOV+uOlyD/tbQMOvTiOncA6NOGCp07MZafAUZyrkbe aklHxVbz5FiwYCzDwk8F8CktnJoKe+NcOMgo2DdJxKXgMTXEkYhWu6Xqvs5MFBy4T/hGBs UyEzMcPO+shuDeoprXeOGaKr7nYbZ+I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1729112438; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M0saLAt62sotpchHFuArnJMILAtW+DmUbux1LuP9cMU=; b=NUhkM2HLdDzwOqMWbhqUhDsz296erF6adxXIHOK5zoGM8hNTM3Vi3hJonrEy7r1HdV4ezg dvrAnCEcro+fgeAA== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1729112437; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M0saLAt62sotpchHFuArnJMILAtW+DmUbux1LuP9cMU=; b=EXy477gjVrrfSkN3BLe1dWZndkOpHNba8EjyFRKm3R7Q95ZizLlP+pD4/WMoOHFnycJNbq JRbrqvAiWzxcgi1xK9Nn0pifZtcH8cDdN3nAyvkYl0bC6qXx3BHuIgfoVLrv2COMdTYM/g /naajwTOjyksSm1Ru48i9Ad7tTsxHAw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1729112437; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M0saLAt62sotpchHFuArnJMILAtW+DmUbux1LuP9cMU=; b=y6lzi76s9Ga7j7kU0kGwpZH0dccnWR4WekYQ8z3M+NLMndfkeMfDSqAlHf0vDQA+LF9Lc+ W531gdL1nsZPAwCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AE9DB13433; Wed, 16 Oct 2024 21:00:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id G5EBHXQpEGdxCwAAD6G6ig (envelope-from ); Wed, 16 Oct 2024 21:00:36 +0000 From: Fabiano Rosas To: Yichen Wang , "Dr. David Alan Gilbert" , Paolo Bonzini , =?utf-8?Q?Marc-A?= =?utf-8?Q?ndr=C3=A9?= Lureau , =?utf-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Peter Xu , Eric Blake , Markus Armbruster , "Michael S. Tsirkin" , Cornelia Huck , qemu-devel@nongnu.org Cc: Hao Xiang , "Liu, Yuan1" , Shivam Kumar , "Ho-Ren (Jack) Chuang" , Yichen Wang , Bryan Zhang Subject: Re: [PATCH v6 03/12] util/dsa: Implement DSA device start and stop logic. In-Reply-To: <20241009234610.27039-4-yichen.wang@bytedance.com> References: <20241009234610.27039-1-yichen.wang@bytedance.com> <20241009234610.27039-4-yichen.wang@bytedance.com> Date: Wed, 16 Oct 2024 18:00:34 -0300 Message-ID: <87ttdb3gr1.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MISSING_XM_UA(0.00)[]; RCPT_COUNT_TWELVE(0.00)[18]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FUZZY_BLOCKED(0.00)[rspamd.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[linux.dev:email, bytedance.com:email, suse.de:mid, imap1.dmz-prg2.suse.org:helo] Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:2; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Yichen Wang writes: > From: Hao Xiang > > * DSA device open and close. > * DSA group contains multiple DSA devices. > * DSA group configure/start/stop/clean. > > Signed-off-by: Hao Xiang > Signed-off-by: Bryan Zhang > Signed-off-by: Yichen Wang > --- > include/qemu/dsa.h | 103 +++++++++++++++++ > util/dsa.c | 282 +++++++++++++++++++++++++++++++++++++++++++++ > util/meson.build | 3 + > 3 files changed, 388 insertions(+) > create mode 100644 include/qemu/dsa.h > create mode 100644 util/dsa.c > > diff --git a/include/qemu/dsa.h b/include/qemu/dsa.h > new file mode 100644 > index 0000000000..501bb8c70d > --- /dev/null > +++ b/include/qemu/dsa.h > @@ -0,0 +1,103 @@ > +/* > + * Interface for using Intel Data Streaming Accelerator to offload certain > + * background operations. > + * > + * Copyright (C) Bytedance Ltd. > + * > + * Authors: > + * Hao Xiang > + * Yichen Wang > + * > + * This work is licensed under the terms of the GNU GPL, version 2 or later. > + * See the COPYING file in the top-level directory. > + */ > + > +#ifndef QEMU_DSA_H > +#define QEMU_DSA_H > + > +#include "qemu/error-report.h" > +#include "qemu/thread.h" > +#include "qemu/queue.h" > + > +#ifdef CONFIG_DSA_OPT > + > +#pragma GCC push_options > +#pragma GCC target("enqcmd") > + > +#include > +#include "x86intrin.h" > + > +typedef struct { > + void *work_queue; > +} QemuDsaDevice; > + > +typedef QSIMPLEQ_HEAD(QemuDsaTaskQueue, QemuDsaBatchTask) QemuDsaTaskQueue; > + > +typedef struct { > + QemuDsaDevice *dsa_devices; > + int num_dsa_devices; > + /* The index of the next DSA device to be used. */ > + uint32_t device_allocator_index; > + bool running; > + QemuMutex task_queue_lock; > + QemuCond task_queue_cond; > + QemuDsaTaskQueue task_queue; > +} QemuDsaDeviceGroup; > + > +/** > + * @brief Initializes DSA devices. > + * > + * @param dsa_parameter A list of DSA device path from migration parameter. > + * > + * @return int Zero if successful, otherwise non zero. > + */ > +int qemu_dsa_init(const strList *dsa_parameter, Error **errp); > + > +/** > + * @brief Start logic to enable using DSA. > + */ > +void qemu_dsa_start(void); > + > +/** > + * @brief Stop the device group and the completion thread. > + */ > +void qemu_dsa_stop(void); > + > +/** > + * @brief Clean up system resources created for DSA offloading. > + */ > +void qemu_dsa_cleanup(void); > + > +/** > + * @brief Check if DSA is running. > + * > + * @return True if DSA is running, otherwise false. > + */ > +bool qemu_dsa_is_running(void); > + > +#else > + > +static inline bool qemu_dsa_is_running(void) > +{ > + return false; > +} > + > +static inline int qemu_dsa_init(const strList *dsa_parameter, Error **errp) > +{ > + if (dsa_parameter != NULL && strlen(dsa_parameter) != 0) { > + error_setg(errp, "DSA is not supported."); > + return -1; > + } > + > + return 0; > +} > + > +static inline void qemu_dsa_start(void) {} > + > +static inline void qemu_dsa_stop(void) {} > + > +static inline void qemu_dsa_cleanup(void) {} > + > +#endif > + > +#endif > diff --git a/util/dsa.c b/util/dsa.c > new file mode 100644 > index 0000000000..54d0e20c29 > --- /dev/null > +++ b/util/dsa.c > @@ -0,0 +1,282 @@ > +/* > + * Use Intel Data Streaming Accelerator to offload certain background > + * operations. > + * > + * Copyright (C) Bytedance Ltd. > + * > + * Authors: > + * Hao Xiang > + * Bryan Zhang > + * Yichen Wang > + * > + * This work is licensed under the terms of the GNU GPL, version 2 or later. > + * See the COPYING file in the top-level directory. > + */ > + > +#include "qemu/osdep.h" > +#include "qapi/error.h" > +#include "qemu/queue.h" > +#include "qemu/memalign.h" > +#include "qemu/lockable.h" > +#include "qemu/cutils.h" > +#include "qemu/dsa.h" > +#include "qemu/bswap.h" > +#include "qemu/error-report.h" > +#include "qemu/rcu.h" > + > +#pragma GCC push_options > +#pragma GCC target("enqcmd") > + > +#include > +#include "x86intrin.h" > + > +#define DSA_WQ_PORTAL_SIZE 4096 > +#define MAX_DSA_DEVICES 16 > + > +uint32_t max_retry_count; > +static QemuDsaDeviceGroup dsa_group; > + > + > +/** > + * @brief This function opens a DSA device's work queue and > + * maps the DSA device memory into the current process. > + * > + * @param dsa_wq_path A pointer to the DSA device work queue's file path. > + * @return A pointer to the mapped memory, or MAP_FAILED on failure. > + */ > +static void * > +map_dsa_device(const char *dsa_wq_path) > +{ > + void *dsa_device; > + int fd; > + > + fd = open(dsa_wq_path, O_RDWR); > + if (fd < 0) { > + error_report("Open %s failed with errno = %d.", > + dsa_wq_path, errno); > + return MAP_FAILED; > + } > + dsa_device = mmap(NULL, DSA_WQ_PORTAL_SIZE, PROT_WRITE, > + MAP_SHARED | MAP_POPULATE, fd, 0); > + close(fd); > + if (dsa_device == MAP_FAILED) { > + error_report("mmap failed with errno = %d.", errno); > + return MAP_FAILED; > + } > + return dsa_device; > +} > + > +/** > + * @brief Initializes a DSA device structure. > + * > + * @param instance A pointer to the DSA device. > + * @param work_queue A pointer to the DSA work queue. > + */ > +static void > +dsa_device_init(QemuDsaDevice *instance, > + void *dsa_work_queue) > +{ > + instance->work_queue = dsa_work_queue; > +} > + > +/** > + * @brief Cleans up a DSA device structure. > + * > + * @param instance A pointer to the DSA device to cleanup. > + */ > +static void > +dsa_device_cleanup(QemuDsaDevice *instance) > +{ > + if (instance->work_queue != MAP_FAILED) { > + munmap(instance->work_queue, DSA_WQ_PORTAL_SIZE); > + } > +} > + > +/** > + * @brief Initializes a DSA device group. > + * > + * @param group A pointer to the DSA device group. > + * @param dsa_parameter A list of DSA device path from are separated by space > + * character migration parameter. Multiple DSA device path. > + * > + * @return Zero if successful, non-zero otherwise. > + */ > +static int > +dsa_device_group_init(QemuDsaDeviceGroup *group, > + const strList *dsa_parameter, > + Error **errp) > +{ > + if (dsa_parameter == NULL) { > + error_setg(errp, "dsa device path is not supplied."); > + return -1; > + } > + > + int ret = 0; > + const char *dsa_path[MAX_DSA_DEVICES]; > + int num_dsa_devices = 0; > + > + while (dsa_parameter) { > + dsa_path[num_dsa_devices++] = dsa_parameter->value; > + if (num_dsa_devices == MAX_DSA_DEVICES) { > + break; > + } > + dsa_parameter = dsa_parameter->next; > + } > + > + group->dsa_devices = > + g_new0(QemuDsaDevice, num_dsa_devices); > + group->num_dsa_devices = num_dsa_devices; > + group->device_allocator_index = 0; > + > + group->running = false; > + qemu_mutex_init(&group->task_queue_lock); > + qemu_cond_init(&group->task_queue_cond); > + QSIMPLEQ_INIT(&group->task_queue); > + > + void *dsa_wq = MAP_FAILED; > + for (int i = 0; i < num_dsa_devices; i++) { > + dsa_wq = map_dsa_device(dsa_path[i]); > + if (dsa_wq == MAP_FAILED) { > + error_setg(errp, "map_dsa_device failed MAP_FAILED."); > + ret = -1; > + goto exit; This will leave subsequent dsa_devices uninitialized after map_dsa_device fails for the i-th device, but the loop at dsa_device_group_cleanup() still passes all of them into dsa_device_cleanup(), so the check != MAP_FAILED there will be true. > + } > + dsa_device_init(&dsa_group.dsa_devices[i], dsa_wq); I think you mean &group->dsa_devices[i] here. > + } > + > +exit: > + return ret; > +} > + > +/** > + * @brief Starts a DSA device group. > + * > + * @param group A pointer to the DSA device group. > + */ > +static void > +dsa_device_group_start(QemuDsaDeviceGroup *group) > +{ > + group->running = true; > +} > + > +/** > + * @brief Stops a DSA device group. > + * > + * @param group A pointer to the DSA device group. > + */ > +__attribute__((unused)) > +static void > +dsa_device_group_stop(QemuDsaDeviceGroup *group) > +{ > + group->running = false; > +} > + > +/** > + * @brief Cleans up a DSA device group. > + * > + * @param group A pointer to the DSA device group. > + */ > +static void > +dsa_device_group_cleanup(QemuDsaDeviceGroup *group) > +{ > + if (!group->dsa_devices) { > + return; > + } > + for (int i = 0; i < group->num_dsa_devices; i++) { > + dsa_device_cleanup(&group->dsa_devices[i]); > + } > + g_free(group->dsa_devices); > + group->dsa_devices = NULL; > + > + qemu_mutex_destroy(&group->task_queue_lock); > + qemu_cond_destroy(&group->task_queue_cond); > +} > + > +/** > + * @brief Returns the next available DSA device in the group. > + * > + * @param group A pointer to the DSA device group. > + * > + * @return struct QemuDsaDevice* A pointer to the next available DSA device > + * in the group. > + */ > +__attribute__((unused)) > +static QemuDsaDevice * > +dsa_device_group_get_next_device(QemuDsaDeviceGroup *group) > +{ > + if (group->num_dsa_devices == 0) { > + return NULL; > + } > + uint32_t current = qatomic_fetch_inc(&group->device_allocator_index); > + current %= group->num_dsa_devices; > + return &group->dsa_devices[current]; > +} > + > +/** > + * @brief Check if DSA is running. > + * > + * @return True if DSA is running, otherwise false. > + */ > +bool qemu_dsa_is_running(void) > +{ > + return false; > +} > + > +static void > +dsa_globals_init(void) > +{ > + max_retry_count = UINT32_MAX; > +} > + > +/** > + * @brief Initializes DSA devices. > + * > + * @param dsa_parameter A list of DSA device path from migration parameter. > + * > + * @return int Zero if successful, otherwise non zero. > + */ > +int qemu_dsa_init(const strList *dsa_parameter, Error **errp) > +{ > + dsa_globals_init(); > + > + return dsa_device_group_init(&dsa_group, dsa_parameter, errp); > +} > + > +/** > + * @brief Start logic to enable using DSA. > + * > + */ > +void qemu_dsa_start(void) > +{ > + if (dsa_group.num_dsa_devices == 0) { > + return; > + } > + if (dsa_group.running) { > + return; > + } > + dsa_device_group_start(&dsa_group); > +} > + > +/** > + * @brief Stop the device group and the completion thread. > + * > + */ > +void qemu_dsa_stop(void) > +{ > + QemuDsaDeviceGroup *group = &dsa_group; > + > + if (!group->running) { > + return; > + } > +} > + > +/** > + * @brief Clean up system resources created for DSA offloading. > + * > + */ > +void qemu_dsa_cleanup(void) > +{ > + qemu_dsa_stop(); > + dsa_device_group_cleanup(&dsa_group); > +} > + > diff --git a/util/meson.build b/util/meson.build > index 5d8bef9891..3360f62923 100644 > --- a/util/meson.build > +++ b/util/meson.build > @@ -88,6 +88,9 @@ if have_block or have_ga > endif > if have_block > util_ss.add(files('aio-wait.c')) > + if config_host_data.get('CONFIG_DSA_OPT') > + util_ss.add(files('dsa.c')) > + endif > util_ss.add(files('buffer.c')) > util_ss.add(files('bufferiszero.c')) > util_ss.add(files('hbitmap.c'))