All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/4] drm/i915/irq: Nuke stale comments
Date: Wed, 02 Oct 2024 13:34:53 +0300	[thread overview]
Message-ID: <87ttduu71u.fsf@intel.com> (raw)
In-Reply-To: <20241001195803.3371-2-ville.syrjala@linux.intel.com>

On Tue, 01 Oct 2024, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Remove the tall tales about getting passed pipe indices into
> the .vblank_{enable,disable}() hooks. This hasn't been true since
> commit 08fa8fd0faa5 ("drm/i915: Switch to per-crtc vblank vfuncs").
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_display_irq.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_irq.c b/drivers/gpu/drm/i915/display/intel_display_irq.c
> index 8c548ee56c12..0ea1fcc61dde 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_irq.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_irq.c
> @@ -1259,9 +1259,6 @@ void gen11_display_irq_handler(struct drm_i915_private *i915)
>  	enable_rpm_wakeref_asserts(&i915->runtime_pm);
>  }
>  
> -/* Called from drm generic code, passed 'crtc' which
> - * we use as a pipe index
> - */
>  int i8xx_enable_vblank(struct drm_crtc *crtc)
>  {
>  	struct drm_i915_private *dev_priv = to_i915(crtc->dev);
> @@ -1394,9 +1391,6 @@ int bdw_enable_vblank(struct drm_crtc *_crtc)
>  	return 0;
>  }
>  
> -/* Called from drm generic code, passed 'crtc' which
> - * we use as a pipe index
> - */
>  void i8xx_disable_vblank(struct drm_crtc *crtc)
>  {
>  	struct drm_i915_private *dev_priv = to_i915(crtc->dev);

-- 
Jani Nikula, Intel

  reply	other threads:[~2024-10-02 10:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-01 19:57 [PATCH 0/4] drm/i915: Vblank/CRC irq stuf Ville Syrjala
2024-10-01 19:58 ` [PATCH 1/4] drm/i915/irq: Nuke stale comments Ville Syrjala
2024-10-02 10:34   ` Jani Nikula [this message]
2024-10-01 19:58 ` [PATCH 2/4] drm/i915/irq: Pair up the vblank enable/disable functions Ville Syrjala
2024-10-02 10:36   ` Jani Nikula
2024-10-01 19:58 ` [PATCH 3/4] drm/i915: Extract i915gm_irq_cstate_wa_{disable, enable}() Ville Syrjala
2024-10-02 10:37   ` Jani Nikula
2024-10-01 19:58 ` [PATCH 4/4] drm/i915: Apply the i915gm/i945gm irq C-state w/a to CRC interrupts Ville Syrjala
2024-10-02 10:46   ` Jani Nikula
2024-10-02  2:08 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Vblank/CRC irq stuf Patchwork
2024-10-02  2:59 ` ✓ Fi.CI.BAT: success " Patchwork
2024-10-03  1:29 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttduu71u.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.