From: Fabiano Rosas <farosas@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Peter Xu" <peterx@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH for-9.2 3/9] tests/qtest/migration-test: Fix leaks in calc_dirtyrate_ready()
Date: Wed, 21 Aug 2024 18:04:26 -0300 [thread overview]
Message-ID: <87ttfdzixx.fsf@suse.de> (raw)
In-Reply-To: <20240820144912.320744-4-peter.maydell@linaro.org>
Peter Maydell <peter.maydell@linaro.org> writes:
> In calc_dirtyrate_ready() we g_strdup() a string but then never free it:
>
> Direct leak of 19 byte(s) in 2 object(s) allocated from:
> #0 0x55ead613413e in malloc (/mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/asan/tests/qtest/migration-test+0x22f13e) (BuildId: e7cd5c37b2987a1af682b43ee5240b98bb316737)
> #1 0x7f7a13d39738 in g_malloc debian/build/deb/../../../glib/gmem.c:128:13
> #2 0x7f7a13d4e583 in g_strdup debian/build/deb/../../../glib/gstrfuncs.c:361:17
> #3 0x55ead6266f48 in calc_dirtyrate_ready tests/qtest/migration-test.c:3409:14
> #4 0x55ead62669fe in wait_for_calc_dirtyrate_complete tests/qtest/migration-test.c:3422:13
> #5 0x55ead6253df7 in test_vcpu_dirty_limit tests/qtest/migration-test.c:3562:9
> #6 0x55ead626a407 in migration_test_wrapper tests/qtest/migration-helpers.c:456:5
>
> We also fail to unref the QMP rsp_return, so we leak that also.
>
> Rather than duplicating the string, use the in-place value from
> the qdict, and then unref the qdict.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
next prev parent reply other threads:[~2024-08-21 21:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 14:49 [PATCH for-9.2 0/9] tests/qtest/migration-test: Fix various leaks Peter Maydell
2024-08-20 14:49 ` [PATCH for-9.2 1/9] tests/qtest/migration-test: Fix bootfile cleanup handling Peter Maydell
2024-08-21 21:00 ` Fabiano Rosas
2024-08-20 14:49 ` [PATCH for-9.2 2/9] tests/qtest/migration-test: Don't leak resp in multifd_mapped_ram_fdset_end() Peter Maydell
2024-08-21 21:01 ` Fabiano Rosas
2024-08-20 14:49 ` [PATCH for-9.2 3/9] tests/qtest/migration-test: Fix leaks in calc_dirtyrate_ready() Peter Maydell
2024-08-21 21:04 ` Fabiano Rosas [this message]
2024-08-20 14:49 ` [PATCH for-9.2 4/9] tests/qtest/migration-helpers: Fix migrate_get_socket_address() leak Peter Maydell
2024-08-22 12:24 ` Fabiano Rosas
2024-08-20 14:49 ` [PATCH for-9.2 5/9] tests/qtest/migration-test: Free QCRyptoTLSTestCertReq objects Peter Maydell
2024-08-22 12:43 ` Fabiano Rosas
2024-08-20 14:49 ` [PATCH for-9.2 6/9] tests/unit/crypto-tls-x509-helpers: deinit privkey in test_tls_cleanup Peter Maydell
2024-08-22 12:44 ` Fabiano Rosas
2024-08-20 14:49 ` [PATCH for-9.2 7/9] tests/qtest/migration-helpers: Don't dup argument to qdict_put_str() Peter Maydell
2024-08-22 12:26 ` Fabiano Rosas
2024-08-20 14:49 ` [PATCH for-9.2 8/9] tests/qtest/migration-test: Don't strdup in get_dirty_rate() Peter Maydell
2024-08-22 12:27 ` Fabiano Rosas
2024-08-20 14:49 ` [PATCH for-9.2 9/9] tests/qtest/migration-test: Don't leak QTestState in test_multifd_tcp_cancel() Peter Maydell
2024-08-22 12:31 ` Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttfdzixx.fsf@suse.de \
--to=farosas@suse.de \
--cc=berrange@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.