From: Baruch Siach via buildroot <buildroot@buildroot.org>
To: Joachim Wiberg <troglobit@gmail.com>
Cc: Asaf Kahlon <asafka7@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/spdlog: add menuconfig option to use bundled fmt
Date: Sun, 04 Aug 2024 09:20:32 +0300 [thread overview]
Message-ID: <87ttg03j2n.fsf@tarshish> (raw)
In-Reply-To: <20240804060003.735172-1-troglobit@gmail.com> (Joachim Wiberg's message of "Sun, 4 Aug 2024 08:00:03 +0200")
Hi Joachim,
On Sun, Aug 04 2024, Joachim Wiberg wrote:
> Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
> ---
> package/spdlog/Config.in | 10 ++++++++++
> package/spdlog/spdlog.mk | 9 +++++++--
> 2 files changed, 17 insertions(+), 2 deletions(-)
>
> diff --git a/package/spdlog/Config.in b/package/spdlog/Config.in
> index 877c1b6ab7..170e17a4f1 100644
> --- a/package/spdlog/Config.in
> +++ b/package/spdlog/Config.in
> @@ -9,6 +9,16 @@ config BR2_PACKAGE_SPDLOG
>
> https://github.com/gabime/spdlog
>
> +if BR2_PACKAGE_SPDLOG
> +
> +config BR2_PACKAGE_SPDLOG_FMT_EXTERNAL
> + bool "Use external fmt library"
> + default y
> + help
> + Use external or bundled fmt library, default external.
What is the advantage of bundled library? The commit log should explain
that.
Also, you should probably move 'select BR2_PACKAGE_FMT' here. We don't
have to build fmt if spdlog doesn't use it.
> +
> +endif
> +
> comment "spdlog needs a toolchain w/ C++, threads, wchar"
> depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS \
> || !BR2_USE_WCHAR
> diff --git a/package/spdlog/spdlog.mk b/package/spdlog/spdlog.mk
> index 6b24357697..c2832c94f3 100644
> --- a/package/spdlog/spdlog.mk
> +++ b/package/spdlog/spdlog.mk
> @@ -13,8 +13,13 @@ SPDLOG_DEPENDENCIES = fmt
> SPDLOG_CONF_OPTS += \
> -DSPDLOG_BUILD_TESTS=OFF \
> -DSPDLOG_BUILD_EXAMPLE=OFF \
> - -DSPDLOG_BUILD_BENCH=OFF \
> - -DSPDLOG_FMT_EXTERNAL=ON
> + -DSPDLOG_BUILD_BENCH=OFF
> +
> +ifeq ($(BR2_PACKAGE_SPDLOG_FMT_EXTERNAL),y)
> +SPDLOG_CONF_OPTS += -DSPDLOG_FMT_EXTERNAL=ON
fmt dependency should also move here.
> +else
> +SPDLOG_CONF_OPTS += -DSPDLOG_FMT_EXTERNAL=OFF
> +endif
>
> ifeq ($(BR2_STATIC_LIBS),y)
> SPDLOG_CONF_OPTS += -DSPDLOG_BUILD_SHARED=OFF
baruch
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-08-04 6:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-04 6:00 [Buildroot] [PATCH 1/1] package/spdlog: add menuconfig option to use bundled fmt Joachim Wiberg
2024-08-04 6:20 ` Baruch Siach via buildroot [this message]
2024-08-04 7:03 ` Joachim Wiberg
2024-08-04 9:46 ` [Buildroot] [PATCH v2 1/1] package/spdlog: add menuconfig option to select formatter Joachim Wiberg
2024-08-04 20:22 ` Thomas Petazzoni via buildroot
2024-08-06 11:11 ` Joachim Wiberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttg03j2n.fsf@tarshish \
--to=buildroot@buildroot.org \
--cc=asafka7@gmail.com \
--cc=baruch@tkos.co.il \
--cc=troglobit@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.