From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F6CCC30658 for ; Wed, 3 Jul 2024 00:03:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2DD0610E6F7; Wed, 3 Jul 2024 00:03:35 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="g3mkh+ba"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5EBA810E6F7 for ; Wed, 3 Jul 2024 00:03:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719965014; x=1751501014; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=10oGrybX5pavEt/ruo+4kYllMZItiZDqD9HYX67M6+c=; b=g3mkh+basuZFY7r5wkzEPnqHkBSz0bIcPpT0neEFYbm9ureunOQmZ2Am 4Bw31Bbw87YpwVdheSP5eC7MzXuQyPTrIw4Am+12y+LbM7fwXeR/CwrzO 3CIdbELzn7M3OZ9Q2M3x/GhONAPSIy8U5zio5MqVDOUWa/OF/+60lCRYu hglP71b9i1jU3GFj6+jpyO5DIXnsfsjpCx9paskQLSAbEkj+HbH/lp9Wn xDBRZqbn2NDb6NNLm9Vl7VdsGDn6fMNCHbqdryfhwQJOPZ/alD28il3z4 685nQpHt+QQpCi1cX2E0qapktjBiw/V0sxfG5MYinpX9bu7uvApkiSctO A==; X-CSE-ConnectionGUID: KAwF8S/JR762x9lIl2xfew== X-CSE-MsgGUID: V8AMtPICRROFlUVxx46e1A== X-IronPort-AV: E=McAfee;i="6700,10204,11121"; a="17380436" X-IronPort-AV: E=Sophos;i="6.09,180,1716274800"; d="scan'208";a="17380436" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2024 17:03:34 -0700 X-CSE-ConnectionGUID: ggeiKyyRThifkjkXbJ9EAQ== X-CSE-MsgGUID: Vs9Ngcf5T0619DymQvNRww== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,180,1716274800"; d="scan'208";a="45934884" Received: from rtatoosk-mobl2.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.125.129.72]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2024 17:03:33 -0700 Date: Tue, 02 Jul 2024 17:03:31 -0700 Message-ID: <87tth79wa4.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa Cc: intel-xe@lists.freedesktop.org, Lucas De Marchi , Rodrigo Vivi , Jose Souza Subject: Re: [PATCH] drm/xe/uapi: Rename xe perf layer as xe observation layer In-Reply-To: References: <20240702214034.2507446-1-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.3 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Tue, 02 Jul 2024 15:45:26 -0700, Umesh Nerlige Ramappa wrote: > Hi Umesh, > On Tue, Jul 02, 2024 at 02:40:34PM -0700, Ashutosh Dixit wrote: > > In Xe, the perf layer allows capture of HW counter streams. These HW > > counters are generally performance related but don't have to be necessarily > > so. Also, the name "perf" is a carryover from i915 and is not preferred. > > > > Here we propose the name "observation" for this common layer which allows > > capture of different types of these counter streams. > > > > v2: Rename observability layer to observation layer and in code > > s/obsrv/observation/ (Lucas/Rodrigo) > > > > Fixes: 52c2e956dceb ("drm/xe/perf/uapi: "Perf" layer to support multiple > > perf counter stream types") > > Fixes: fe8929bdf835 ("drm/xe/perf/uapi: Add perf_stream_paranoid sysctl") > > Acked-by: Lucas De Marchi > > Acked-by: Rodrigo Vivi > > Signed-off-by: Ashutosh Dixit > > Applied the patch and grepped for perf/obsrv/observation, LGTM, > > Reviewed-by: Umesh Nerlige Ramappa Thanks for checking and reviewing. Looks like CI is not running at present. In any case, I'll wait to see if anyone else also has any review comments before merging this. Thanks. -- Ashutosh