From: Peter Korsgaard <peter@korsgaard.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Adam Duskett <adam.duskett@amarulasolutions.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2, 1/1] package/libutempter: do not hardcode PIE
Date: Mon, 27 May 2024 15:00:50 +0200 [thread overview]
Message-ID: <87ttijbe9p.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20240505190044.1246330-1-fontaine.fabrice@gmail.com> (Fabrice Fontaine's message of "Sun, 5 May 2024 21:00:44 +0200")
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> PIE will be set by buildroot if the user wants it so set
> {COMPILE,LINK}_PIE to an empty value to fix the following build failure
> raised since the addition of the package in commit
> 02c818bc5c7a6967a212f12e4caa8ccdfa0b452b:
> /home/buildroot/autobuild/run/instance-3/output-1/host/bin/m68k-linux-gcc
> -W -Wall -Waggregate-return -Wcast-align -Wconversion
> -Wdisabled-optimization -Wmissing-declarations
> -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes
> -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes
> -Wwrite-strings -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
> -D_FILE_OFFSET_BITS=64 -O2 -g0 -std=gnu99 -DLIBEXECDIR=\"/usr/lib\"
> -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64
> -Wl,-z,relro -Wl,-stats -fPIE -pie -Wl,-z,now utempter.c -o utempter
> [...]
> /home/buildroot/autobuild/run/instance-3/output-1/host/opt/ext-toolchain/bin/../lib/gcc/m68k-buildroot-linux-uclibc/12.3.0/../../../../m68k-buildroot-linux-uclibc/bin/ld:
> /home/buildroot/autobuild/run/instance-3/output-1/host/m68k-buildroot-linux-uclibc/sysroot/usr/lib/Scrt1.o:
> in function `lib_main':
> (.text+0x4): undefined reference to `__shared_flat_add_library'
> Fixes: 02c818bc5c7a6967a212f12e4caa8ccdfa0b452b
> - http://autobuild.buildroot.org/results/3a5581fd4edf56bbdc48ab111a2351fc70f1c703
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2 (after review of Yann E. Morin):
> - Also set COMPILE_PIE
Committed to 2024.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-05-27 13:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-05 19:00 [Buildroot] [PATCH v2, 1/1] package/libutempter: do not hardcode PIE Fabrice Fontaine
2024-05-06 20:02 ` Thomas Petazzoni via buildroot
2024-05-27 13:00 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttijbe9p.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=adam.duskett@amarulasolutions.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.