From: Takashi Iwai <tiwai@suse.de>
To: Simon Trimmer <simont@opensource.cirrus.com>
Cc: <tiwai@suse.com>, <linux-sound@vger.kernel.org>,
<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
<patches@opensource.cirrus.com>
Subject: Re: [PATCH] ALSA: hda: cs35l56: Perform firmware download in the background
Date: Thu, 02 May 2024 09:34:34 +0200 [thread overview]
Message-ID: <87ttjgk6ph.wl-tiwai@suse.de> (raw)
In-Reply-To: <20240501111755.21231-1-simont@opensource.cirrus.com>
On Wed, 01 May 2024 13:17:55 +0200,
Simon Trimmer wrote:
> @@ -964,6 +1011,14 @@ int cs35l56_hda_common_probe(struct cs35l56_hda *cs35l56, int hid, int id)
> mutex_init(&cs35l56->base.irq_lock);
> dev_set_drvdata(cs35l56->base.dev, cs35l56);
>
> + cs35l56->dsp_wq = create_singlethread_workqueue("cs35l56-dsp");
> + if (!cs35l56->dsp_wq) {
> + ret = -ENOMEM;
> + goto err;
> + }
Do we really need a dedicated workqueue? In most usages, simple
schedule_work*() works fine and is recommended.
thanks,
Takashi
next prev parent reply other threads:[~2024-05-02 7:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 11:17 [PATCH] ALSA: hda: cs35l56: Perform firmware download in the background Simon Trimmer
2024-05-02 7:34 ` Takashi Iwai [this message]
2024-05-02 9:21 ` Richard Fitzgerald
2024-05-02 9:52 ` Takashi Iwai
2024-05-02 10:17 ` Simon Trimmer
2024-05-02 10:25 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2024-06-18 12:53 Simon Trimmer
2024-06-18 12:59 ` Simon Trimmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttjgk6ph.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=simont@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.