From: Kalle Valo <kvalo@kernel.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: Breno Leitao <leitao@debian.org>,
"leit@meta.com" <leit@meta.com>,
"open list:REALTEK WIRELESS DRIVER (rtw89)"
<linux-wireless@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH wireless] wifi: rtw89: Un-embed dummy device
Date: Thu, 25 Apr 2024 08:57:00 +0300 [thread overview]
Message-ID: <87ttjqgf2r.fsf@kernel.org> (raw)
In-Reply-To: <f46ae94488d1468e9a9a669320e4cfb9@realtek.com> (Ping-Ke Shih's message of "Thu, 25 Apr 2024 05:52:54 +0000")
Ping-Ke Shih <pkshih@realtek.com> writes:
> Breno Leitao <leitao@debian.org> wrote:
>> Embedding net_device into structures prohibits the usage of flexible
>> arrays in the net_device structure. For more details, see the discussion
>> at [1].
>>
>> Un-embed the net_device from the private struct by converting it
>> into a pointer. Then use the leverage the new alloc_netdev_dummy()
>> helper to allocate and initialize dummy devices.
>>
>> [1] https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/
>>
>> Signed-off-by: Breno Leitao <leitao@debian.org>
>
> I think this patch should go via net-next tree, because wireless-next tree
> doesn't have patch of dummy devices yet.
>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
FWIW I sent the wireless-next pull request yesterday and once it pulled
we will fast forward wireless-next to latest net-next.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-04-25 5:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 18:23 [PATCH wireless] wifi: rtw89: Un-embed dummy device Breno Leitao
2024-04-25 5:52 ` Ping-Ke Shih
2024-04-25 5:57 ` Kalle Valo [this message]
2024-04-25 6:00 ` Kalle Valo
2024-04-25 6:15 ` Ping-Ke Shih
2024-05-09 7:48 ` Breno Leitao
2024-05-09 7:59 ` Ping-Ke Shih
2024-05-09 9:48 ` Kalle Valo
2024-05-09 11:03 ` Breno Leitao
2024-05-09 6:14 ` Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttjqgf2r.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=leit@meta.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.