From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38D5EC00A94 for ; Mon, 15 Apr 2024 14:01:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 979F940119; Mon, 15 Apr 2024 14:01:04 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id UhX5M9x9VX7w; Mon, 15 Apr 2024 14:01:00 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org EF8A04016B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1713189660; bh=8CkXYS21B8SH8DBLj2VWRkV6viWLhTMjW+3OPz7/pzQ=; h=From:To:In-Reply-To:References:Date:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=CKLvGzMsmhxVRbkAFiNmBLePwNcp9wdir7BxeQcYV7wSAHyRLSQIce9iGfj4XrjtG dcMa6/sZB7kgYzjholFjVt9P5pT6XK7YMwpuuC08CilVCBf4zTGGOakTbLoTRKZEgC 06XU4eVhDBsPA3J4pLbUETVjYeDP2DuLXcqv2khuImCMDGsBu9uc8E+ootTCgXY2W0 KdqkmXL3nzNba5SVLpSLZuYzIOX1A7z+ZmDpn/cZ55kfQDB8staI/iwsdHCu6ba8P4 3w0rb556IS4T/Y8NqcWnQv729N+a8OOpzF4eKY9kTQo9EPgYf1BhJHNCd5daPHadFt oiYh42psyfU3Q== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id EF8A04016B; Mon, 15 Apr 2024 14:00:59 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 85A121BF285 for ; Mon, 15 Apr 2024 14:00:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 71BF081257 for ; Mon, 15 Apr 2024 14:00:58 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id YlYH0cDCKUcI for ; Mon, 15 Apr 2024 14:00:54 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a0a:51c0:0:12e:550::1; helo=galois.linutronix.de; envelope-from=kurt@linutronix.de; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org F419980FA6 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org F419980FA6 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by smtp1.osuosl.org (Postfix) with ESMTPS id F419980FA6 for ; Mon, 15 Apr 2024 14:00:53 +0000 (UTC) From: Kurt Kanzenbach To: Lukas Wunner In-Reply-To: References: <20240411-igc_led_deadlock-v1-1-0da98a3c68c5@linutronix.de> <877ch0b901.fsf@kurt.kurt.home> <87zftukhxl.fsf@kurt.kurt.home> Date: Mon, 15 Apr 2024 16:00:50 +0200 Message-ID: <87ttk2k9nx.fsf@kurt.kurt.home> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1713189651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8CkXYS21B8SH8DBLj2VWRkV6viWLhTMjW+3OPz7/pzQ=; b=JMXT1O6oZ6nTdi4AMFLgwnZgPGJ118+Fqm24qdKBp74cis8rybF0EST1nxdwNwMufuyRlH 4fBc+6apyqVN+f8yXOw2FcNaO8CKBtDTH9wD+JHl9mvwlQnrFjSANvkvwiQunM7yIVzETU 5XD5PFnryJIX13v/Ut1Cr3y80mVhx62YAaHkTzsGcJOfh2k9VB003waU45iJBGL0z33kHW ARsV72CZVGnSk0Yr7v/Ai7TFBcTO7fiCscxx/f39BLF4Wyo+EMW4H2SicO1y8qI0bt40Fj K51B5TeF2T3THDJezdNHF4dbijIDzJ14pwDjZFpuOsnbnTsy4/4rnyvFxFS+8w== X-Mailman-Original-DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1713189651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8CkXYS21B8SH8DBLj2VWRkV6viWLhTMjW+3OPz7/pzQ=; b=bG0RKwoMXR2QZzzmRtLvhLpK4rtObVSmR+dHWmkXp4lJFK5NEqoeGLa/MBTqb0HHWWWqAa KE+az3Qc5Se7wnDw== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=none dis=none) header.from=linutronix.de X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=linutronix.de header.i=@linutronix.de header.a=rsa-sha256 header.s=2020 header.b=JMXT1O6o; dkim=pass header.d=linutronix.de header.i=@linutronix.de header.a=ed25519-sha256 header.s=2020e header.b=bG0RKwoM Subject: Re: [Intel-wired-lan] [PATCH iwl-net] igc: Fix deadlock on module removal X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Sasha Neftin , Roman Lozko , Eric Dumazet , netdev@vger.kernel.org, Tony Nguyen , intel-wired-lan@lists.osuosl.org, Jakub Kicinski , Paolo Abeni , "David S. Miller" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Lukas, On Mon Apr 15 2024, Lukas Wunner wrote: > On Mon, Apr 15, 2024 at 01:02:14PM +0200, Kurt Kanzenbach wrote: >> > > I would have been happy to submit a patch myself, I was waiting >> > > for a Tested-by from Roman or you. >> > >> > Perfect. I was wondering why you are not submitting the patch >> > yourself. Then, please go ahead and submit the patch. Feel free to add >> > my Tested-by. >>=20 >> Scratch that. I've sent v2 with your SoB. PTAL, because your original >> code snippet didn't have a SoB. >>=20 >> https://lore.kernel.org/netdev/20240411-igc_led_deadlock-v2-1-b758c0c88b= 2b@linutronix.de/ > > I created a patch yesterday, as you've requested, then waited for 0-day > to crunch through it and report success. Which it just did, so here's > my proposal and I guess maintainers now have more than enough options > to choose from: > > https://lore.kernel.org/netdev/2f1be6b1cf2b3346929b0049f2ac7d7d79acb5c9.1= 713188539.git.lukas@wunner.de/ Yes. And sorry for being a bit unresponsive, but i was out-of-office for the last couple of weeks. Anyway, thank you for your help in debugging this! Regarding testing, it worked on my test machines and the Intel maintainers will validate it as well. Thanks, Kurt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJHBAEBCgAxFiEEvLm/ssjDfdPf21mSwZPR8qpGc4IFAmYdMxITHGt1cnRAbGlu dXRyb25peC5kZQAKCRDBk9HyqkZzgm8dD/9wq0wT4s0WUmzJKekTZ5wLDvDGWoiM BvfXf2TuVuADSCwL7rOrPQjcenNkznF7lr834KXR5Emi1W6brNtb+5TbZUvXKb3e sfrYJL6BDrLCb9Ii3/Ib9V9gGPwXcxa2WLbn8bgRO02PYUH07SHiuauSsi2MqT+F zSZyIDugP1S7fpH11zb1IW4Cvd67iPr+ol+eUdYVx+ZKJDkBNkdm33vHXHMFq2ud s9oKZhTZshDXbgPR+5MnVdaCyJIw3HOdrFijHOcMIHUQOotaJhmOuk4IxQ6xWMRb BxrUypJcBY3aaej1byqu1zha6vhnKeVgxPk+E8VxFYhrHFvBkmaInTaxRrol6s1H aiDFcOAnWYt6uH/3N5QPRq3qqNIPoSfmvMpm3RfKhcTTGWgwVkOT4tx+iMLGA0Vq 6dO/P2C/LgVAOAf58QnMrX6oWxTBNz4qRLx0F5B7N/npUNTr+wWlojXEzS4AAjaC 7W29HEGX/qmVgJTAcK7X3ZoIU3ia/vhrdQashGytswJ53CuQeb0gkfY4Y9gTKLwx zSDqEChuw2vCYJK5mflWX4YXWD0Hwe8mFXSxPcM8b2/0G4teMCSv0ESNrlkN1baS QKZU3ev5BX5yHZHVs2HaxVwdLlSjm+F9KC6gV6wlm8POpfm2S4AKMl2Vjy5wKOe3 Bm/7y5c0wlRtZw== =kppl -----END PGP SIGNATURE----- --=-=-=-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F54D73186 for ; Mon, 15 Apr 2024 14:00:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713189657; cv=none; b=Fq/7bghve/o+wBHvf4gAzqddLV8vy47orzFMn/j/poHyhvy0R/lEdziN80tmCz9EcnKYiiW6/mh22fLUA+hPyYJDBnWlHIY/lMK7ZTl1MBTs+5IT1PPzsxaecm7x2qDmzJeJbYVgXOrQ8fe3Sd3W4TYUX65vMwVVMfIg7BJ3kpg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713189657; c=relaxed/simple; bh=px2vG55pE3JPcVlPraM2XP+jrtWQUE3roNemiyTuZms=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=WtlEFZWo0b8zBPovX75EAZSQ5sR2UWe4E9DfA/wP0RKvHSQk0r8aQQk5nseSDRc1pFL5Mvco4sG7lQEaHPDiH1r81pLIt2hVIP7GrHqK2/Da84gRHVTNpKs0gt/Z9VMmelx8jIQdSFJjFPCOHoSgLZn9WaLOloPucBIdQLmySJk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=JMXT1O6o; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=bG0RKwoM; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="JMXT1O6o"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="bG0RKwoM" From: Kurt Kanzenbach DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1713189651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8CkXYS21B8SH8DBLj2VWRkV6viWLhTMjW+3OPz7/pzQ=; b=JMXT1O6oZ6nTdi4AMFLgwnZgPGJ118+Fqm24qdKBp74cis8rybF0EST1nxdwNwMufuyRlH 4fBc+6apyqVN+f8yXOw2FcNaO8CKBtDTH9wD+JHl9mvwlQnrFjSANvkvwiQunM7yIVzETU 5XD5PFnryJIX13v/Ut1Cr3y80mVhx62YAaHkTzsGcJOfh2k9VB003waU45iJBGL0z33kHW ARsV72CZVGnSk0Yr7v/Ai7TFBcTO7fiCscxx/f39BLF4Wyo+EMW4H2SicO1y8qI0bt40Fj K51B5TeF2T3THDJezdNHF4dbijIDzJ14pwDjZFpuOsnbnTsy4/4rnyvFxFS+8w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1713189651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8CkXYS21B8SH8DBLj2VWRkV6viWLhTMjW+3OPz7/pzQ=; b=bG0RKwoMXR2QZzzmRtLvhLpK4rtObVSmR+dHWmkXp4lJFK5NEqoeGLa/MBTqb0HHWWWqAa KE+az3Qc5Se7wnDw== To: Lukas Wunner Cc: Roman Lozko , Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Sasha Neftin , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org Subject: Re: [PATCH iwl-net] igc: Fix deadlock on module removal In-Reply-To: References: <20240411-igc_led_deadlock-v1-1-0da98a3c68c5@linutronix.de> <877ch0b901.fsf@kurt.kurt.home> <87zftukhxl.fsf@kurt.kurt.home> Date: Mon, 15 Apr 2024 16:00:50 +0200 Message-ID: <87ttk2k9nx.fsf@kurt.kurt.home> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Lukas, On Mon Apr 15 2024, Lukas Wunner wrote: > On Mon, Apr 15, 2024 at 01:02:14PM +0200, Kurt Kanzenbach wrote: >> > > I would have been happy to submit a patch myself, I was waiting >> > > for a Tested-by from Roman or you. >> > >> > Perfect. I was wondering why you are not submitting the patch >> > yourself. Then, please go ahead and submit the patch. Feel free to add >> > my Tested-by. >>=20 >> Scratch that. I've sent v2 with your SoB. PTAL, because your original >> code snippet didn't have a SoB. >>=20 >> https://lore.kernel.org/netdev/20240411-igc_led_deadlock-v2-1-b758c0c88b= 2b@linutronix.de/ > > I created a patch yesterday, as you've requested, then waited for 0-day > to crunch through it and report success. Which it just did, so here's > my proposal and I guess maintainers now have more than enough options > to choose from: > > https://lore.kernel.org/netdev/2f1be6b1cf2b3346929b0049f2ac7d7d79acb5c9.1= 713188539.git.lukas@wunner.de/ Yes. And sorry for being a bit unresponsive, but i was out-of-office for the last couple of weeks. Anyway, thank you for your help in debugging this! Regarding testing, it worked on my test machines and the Intel maintainers will validate it as well. Thanks, Kurt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJHBAEBCgAxFiEEvLm/ssjDfdPf21mSwZPR8qpGc4IFAmYdMxITHGt1cnRAbGlu dXRyb25peC5kZQAKCRDBk9HyqkZzgm8dD/9wq0wT4s0WUmzJKekTZ5wLDvDGWoiM BvfXf2TuVuADSCwL7rOrPQjcenNkznF7lr834KXR5Emi1W6brNtb+5TbZUvXKb3e sfrYJL6BDrLCb9Ii3/Ib9V9gGPwXcxa2WLbn8bgRO02PYUH07SHiuauSsi2MqT+F zSZyIDugP1S7fpH11zb1IW4Cvd67iPr+ol+eUdYVx+ZKJDkBNkdm33vHXHMFq2ud s9oKZhTZshDXbgPR+5MnVdaCyJIw3HOdrFijHOcMIHUQOotaJhmOuk4IxQ6xWMRb BxrUypJcBY3aaej1byqu1zha6vhnKeVgxPk+E8VxFYhrHFvBkmaInTaxRrol6s1H aiDFcOAnWYt6uH/3N5QPRq3qqNIPoSfmvMpm3RfKhcTTGWgwVkOT4tx+iMLGA0Vq 6dO/P2C/LgVAOAf58QnMrX6oWxTBNz4qRLx0F5B7N/npUNTr+wWlojXEzS4AAjaC 7W29HEGX/qmVgJTAcK7X3ZoIU3ia/vhrdQashGytswJ53CuQeb0gkfY4Y9gTKLwx zSDqEChuw2vCYJK5mflWX4YXWD0Hwe8mFXSxPcM8b2/0G4teMCSv0ESNrlkN1baS QKZU3ev5BX5yHZHVs2HaxVwdLlSjm+F9KC6gV6wlm8POpfm2S4AKMl2Vjy5wKOe3 Bm/7y5c0wlRtZw== =kppl -----END PGP SIGNATURE----- --=-=-=--