From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C6A01E86A; Mon, 18 Mar 2024 03:25:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=150.107.74.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710732311; cv=none; b=bVnLtilTpvxblq3GqKOOQCY1jMff3LNbrlXXEqytJ63xkGzDPeRFdWgQCznu1G/vDh0BVUEM2pbGeLKdOVdvLLgc1z2VnoraEwOX8XpGnkK3VoU/K9+BYbDKYf4gRhSyw3JKEStzKi9qVjMuWbVeCHqPEuEjU8qxqkVcl1/37t4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710732311; c=relaxed/simple; bh=NV+IEiKEp7lCdjzjbneFkp6G29/AFeVDyz/GqmHX3m4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=qI9I8/C6jvBvgSNuCCFvnjTqzeoFisRHqtE3qI9yvJaq+bb9OBGWx/yWfy95GlIINluKUU0ORg9rRQPsS//T9CGnBX7SRqWHI+cE8l0dQBnISAYkJQmE8ckRG8rqFgRFENJzD+8w/hC7e8ec2LSh5cj7ssB8mqmDCiAbeKq/Jw4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au; spf=pass smtp.mailfrom=ellerman.id.au; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b=aZwR6Ce1; arc=none smtp.client-ip=150.107.74.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ellerman.id.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="aZwR6Ce1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1710732306; bh=NV+IEiKEp7lCdjzjbneFkp6G29/AFeVDyz/GqmHX3m4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=aZwR6Ce11vNXim4mOCh1eXkx7K65RfM+cau+BhgB9SdLqlZPW+NSBiMfH6HvhOd0A Cxq4iA45zUMfJd0t0fiCZUW9oT7MdElC1lAHDwjgYhkFVet+3SexBY3VTuWZ+t2GS/ R6YtLN+mqg6XUSgVsgcCPTEOKRlHDfSmPt/ef1FfXW6waLfQPAdiG7JMm/zsq5BT3k vdQUUXBAz8sJiI6L7YfwQCfB8GuYQWxC3Reysu8xNTnmju7VZ+DNwIB5BF60uJsyDk OdmHw4LQNlhzuekWxZGLa0lNLJlIa+tl6Z4Z3Fg6YFxfGk0yqItTN1sXJzV54NgtGp w8QwwUGGGIyQQ== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4TygG42yLDz4wc1; Mon, 18 Mar 2024 14:25:00 +1100 (AEDT) From: Michael Ellerman To: Guenter Roeck , Geert Uytterhoeven Cc: linux-kselftest@vger.kernel.org, David Airlie , Arnd Bergmann , =?utf-8?Q?Ma=C3=ADra?= Canal , Dan Carpenter , Kees Cook , Daniel Diaz , David Gow , Arthur Grillo , Brendan Higgins , Naresh Kamboju , Maarten Lankhorst , Andrew Morton , Maxime Ripard , Ville =?utf-8?B?U3lyasOkbMOk?= , Daniel Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, loongarch@lists.linux.dev, netdev@lists.linux.dev Subject: Re: [PATCH 00/14] Add support for suppressing warning backtraces In-Reply-To: <04f34097-7788-490d-a9c2-82b44bf6af44@roeck-us.net> References: <20240312170309.2546362-1-linux@roeck-us.net> <6d9269c0-bd38-4965-a454-4358e0a182e3@roeck-us.net> <04f34097-7788-490d-a9c2-82b44bf6af44@roeck-us.net> Date: Mon, 18 Mar 2024 14:24:59 +1100 Message-ID: <87ttl4z0fo.fsf@mail.lhotse> Precedence: bulk X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Guenter Roeck writes: > On 3/14/24 07:37, Guenter Roeck wrote: >> On 3/14/24 06:36, Geert Uytterhoeven wrote: >>> Hi G=C3=BCnter, >>> >>> On Tue, Mar 12, 2024 at 6:03=E2=80=AFPM Guenter Roeck wrote: >>>> Some unit tests intentionally trigger warning backtraces by passing bad >>>> parameters to kernel API functions. Such unit tests typically check the >>>> return value from such calls, not the existence of the warning backtra= ce. >>>> >>>> Such intentionally generated warning backtraces are neither desirable >>>> nor useful for a number of reasons. >>>> - They can result in overlooked real problems. >>>> - A warning that suddenly starts to show up in unit tests needs to be >>>> =C2=A0=C2=A0 investigated and has to be marked to be ignored, for exam= ple by >>>> =C2=A0=C2=A0 adjusting filter scripts. Such filters are ad-hoc because= there is >>>> =C2=A0=C2=A0 no real standard format for warnings. On top of that, suc= h filter >>>> =C2=A0=C2=A0 scripts would require constant maintenance. >>>> >>>> One option to address problem would be to add messages such as "expect= ed >>>> warning backtraces start / end here" to the kernel log.=C2=A0 However,= that >>>> would again require filter scripts, it might result in missing real >>>> problematic warning backtraces triggered while the test is running, and >>>> the irrelevant backtrace(s) would still clog the kernel log. >>>> >>>> Solve the problem by providing a means to identify and suppress specif= ic >>>> warning backtraces while executing test code. Support suppressing mult= iple >>>> backtraces while at the same time limiting changes to generic code to = the >>>> absolute minimum. Architecture specific changes are kept at minimum by >>>> retaining function names only if both CONFIG_DEBUG_BUGVERBOSE and >>>> CONFIG_KUNIT are enabled. >>>> >>>> The first patch of the series introduces the necessary infrastructure. >>>> The second patch introduces support for counting suppressed backtraces. >>>> This capability is used in patch three to implement unit tests. >>>> Patch four documents the new API. >>>> The next two patches add support for suppressing backtraces in drm_rect >>>> and dev_addr_lists unit tests. These patches are intended to serve as >>>> examples for the use of the functionality introduced with this series. >>>> The remaining patches implement the necessary changes for all >>>> architectures with GENERIC_BUG support. >>> >>> Thanks for your series! >>> >>> I gave it a try on m68k, just running backtrace-suppression-test, >>> and that seems to work fine. >>> >>>> Design note: >>>> =C2=A0=C2=A0 Function pointers are only added to the __bug_table secti= on if both >>>> =C2=A0=C2=A0 CONFIG_KUNIT and CONFIG_DEBUG_BUGVERBOSE are enabled to a= void image >>>> =C2=A0=C2=A0 size increases if CONFIG_KUNIT=3Dn. There would be some b= enefits to >>>> =C2=A0=C2=A0 adding those pointers all the time (reduced complexity, a= bility to >>>> =C2=A0=C2=A0 display function names in BUG/WARNING messages). That cha= nge, if >>>> =C2=A0=C2=A0 desired, can be made later. >>> >>> Unfortunately this also increases kernel size in the CONFIG_KUNIT=3Dm >>> case (ca. 80 KiB for atari_defconfig), making it less attractive to have >>> kunit and all tests enabled as modules in my standard kernel. >>> >>=20 >> Good point. Indeed, it does. I wanted to avoid adding a configuration op= tion, >> but maybe I should add it after all. How about something like this ? >>=20 >> +config KUNIT_SUPPRESS_BACKTRACE >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bool "KUnit - Enable backtrace sup= pression" >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 default y >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 help >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Enable backtrace suppr= ession for KUnit. If enabled, backtraces >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 generated intentionall= y by KUnit tests can be suppressed. Disable >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 to reduce kernel image= size if image size is more important than >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 suppression of backtra= ces generated by KUnit tests. > > Any more comments / feedback on this ? Otherwise I'll introduce the > above configuration option in v2 of the series. > > In this context, any suggestions if it should be enabled or disabled by > default ? I personally think it would be more important to be able to > suppress backtraces, but I understand that others may not be willing to > accept a ~1% image size increase with CONFIG_KUNIT=3Dm unless > KUNIT_SUPPRESS_BACKTRACE is explicitly disabled. Please enable it by default. There are multiple CI systems that will benefit from it, whereas the number of users enabling KUNIT in severely spaced constrainted environments is surely small - perhaps just Geert ;). cheers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF81BC54E5D for ; Mon, 18 Mar 2024 03:25:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=klx9h3O9koDEx/v3zJJY/B2vjs/HWRJhvBVl205MzCI=; b=vKSD3BcOuAz4hq i4zzNTATPPGSgk+ZoWZ8YsxmOQI2LF8ZlyPyVAaDGADBALWLeWbsRvZBlGjtaaAHaDabFAf2R80gB AJ4nqVdL1jBQAVDJWRtqkd1WpFOlqE3riWgqvcOoy4GHhBQkPrZpvLWGw9Q78S5OY+C3iGKB+o2el Z6xPyKDAyYXE7HvnBHV1f1I1biyqdF2OJU7Bw3Q4wnd4gbMTBDO/mxgWxfvRD56NU5PSfMK5gLGCs ZP0PZ+fECjFWZQjxyDXhVvk2b+DJ8xgUKvd69c7k+GsAV19PyDku5dzqW7kvQX4iZxTdLQGg4iB8I A4v7TuLaES0fGyu5/83A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rm3cm-000000078ww-37RU; Mon, 18 Mar 2024 03:25:20 +0000 Received: from gandalf.ozlabs.org ([150.107.74.76]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rm3cg-000000078t9-11Kg; Mon, 18 Mar 2024 03:25:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1710732306; bh=NV+IEiKEp7lCdjzjbneFkp6G29/AFeVDyz/GqmHX3m4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=aZwR6Ce11vNXim4mOCh1eXkx7K65RfM+cau+BhgB9SdLqlZPW+NSBiMfH6HvhOd0A Cxq4iA45zUMfJd0t0fiCZUW9oT7MdElC1lAHDwjgYhkFVet+3SexBY3VTuWZ+t2GS/ R6YtLN+mqg6XUSgVsgcCPTEOKRlHDfSmPt/ef1FfXW6waLfQPAdiG7JMm/zsq5BT3k vdQUUXBAz8sJiI6L7YfwQCfB8GuYQWxC3Reysu8xNTnmju7VZ+DNwIB5BF60uJsyDk OdmHw4LQNlhzuekWxZGLa0lNLJlIa+tl6Z4Z3Fg6YFxfGk0yqItTN1sXJzV54NgtGp w8QwwUGGGIyQQ== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4TygG42yLDz4wc1; Mon, 18 Mar 2024 14:25:00 +1100 (AEDT) From: Michael Ellerman To: Guenter Roeck , Geert Uytterhoeven Cc: linux-kselftest@vger.kernel.org, David Airlie , Arnd Bergmann , =?utf-8?Q?Ma=C3=ADra?= Canal , Dan Carpenter , Kees Cook , Daniel Diaz , David Gow , Arthur Grillo , Brendan Higgins , Naresh Kamboju , Maarten Lankhorst , Andrew Morton , Maxime Ripard , Ville =?utf-8?B?U3lyasOkbMOk?= , Daniel Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, loongarch@lists.linux.dev, netdev@lists.linux.dev Subject: Re: [PATCH 00/14] Add support for suppressing warning backtraces In-Reply-To: <04f34097-7788-490d-a9c2-82b44bf6af44@roeck-us.net> References: <20240312170309.2546362-1-linux@roeck-us.net> <6d9269c0-bd38-4965-a454-4358e0a182e3@roeck-us.net> <04f34097-7788-490d-a9c2-82b44bf6af44@roeck-us.net> Date: Mon, 18 Mar 2024 14:24:59 +1100 Message-ID: <87ttl4z0fo.fsf@mail.lhotse> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240317_202514_594342_74AD3D91 X-CRM114-Status: GOOD ( 25.13 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org R3VlbnRlciBSb2VjayA8bGludXhAcm9lY2stdXMubmV0PiB3cml0ZXM6Cj4gT24gMy8xNC8yNCAw NzozNywgR3VlbnRlciBSb2VjayB3cm90ZToKPj4gT24gMy8xNC8yNCAwNjozNiwgR2VlcnQgVXl0 dGVyaG9ldmVuIHdyb3RlOgo+Pj4gSGkgR8O8bnRlciwKPj4+Cj4+PiBPbiBUdWUsIE1hciAxMiwg MjAyNCBhdCA2OjAz4oCvUE0gR3VlbnRlciBSb2VjayA8bGludXhAcm9lY2stdXMubmV0PiB3cm90 ZToKPj4+PiBTb21lIHVuaXQgdGVzdHMgaW50ZW50aW9uYWxseSB0cmlnZ2VyIHdhcm5pbmcgYmFj a3RyYWNlcyBieSBwYXNzaW5nIGJhZAo+Pj4+IHBhcmFtZXRlcnMgdG8ga2VybmVsIEFQSSBmdW5j dGlvbnMuIFN1Y2ggdW5pdCB0ZXN0cyB0eXBpY2FsbHkgY2hlY2sgdGhlCj4+Pj4gcmV0dXJuIHZh bHVlIGZyb20gc3VjaCBjYWxscywgbm90IHRoZSBleGlzdGVuY2Ugb2YgdGhlIHdhcm5pbmcgYmFj a3RyYWNlLgo+Pj4+Cj4+Pj4gU3VjaCBpbnRlbnRpb25hbGx5IGdlbmVyYXRlZCB3YXJuaW5nIGJh Y2t0cmFjZXMgYXJlIG5laXRoZXIgZGVzaXJhYmxlCj4+Pj4gbm9yIHVzZWZ1bCBmb3IgYSBudW1i ZXIgb2YgcmVhc29ucy4KPj4+PiAtIFRoZXkgY2FuIHJlc3VsdCBpbiBvdmVybG9va2VkIHJlYWwg cHJvYmxlbXMuCj4+Pj4gLSBBIHdhcm5pbmcgdGhhdCBzdWRkZW5seSBzdGFydHMgdG8gc2hvdyB1 cCBpbiB1bml0IHRlc3RzIG5lZWRzIHRvIGJlCj4+Pj4gwqDCoCBpbnZlc3RpZ2F0ZWQgYW5kIGhh cyB0byBiZSBtYXJrZWQgdG8gYmUgaWdub3JlZCwgZm9yIGV4YW1wbGUgYnkKPj4+PiDCoMKgIGFk anVzdGluZyBmaWx0ZXIgc2NyaXB0cy4gU3VjaCBmaWx0ZXJzIGFyZSBhZC1ob2MgYmVjYXVzZSB0 aGVyZSBpcwo+Pj4+IMKgwqAgbm8gcmVhbCBzdGFuZGFyZCBmb3JtYXQgZm9yIHdhcm5pbmdzLiBP biB0b3Agb2YgdGhhdCwgc3VjaCBmaWx0ZXIKPj4+PiDCoMKgIHNjcmlwdHMgd291bGQgcmVxdWly ZSBjb25zdGFudCBtYWludGVuYW5jZS4KPj4+Pgo+Pj4+IE9uZSBvcHRpb24gdG8gYWRkcmVzcyBw cm9ibGVtIHdvdWxkIGJlIHRvIGFkZCBtZXNzYWdlcyBzdWNoIGFzICJleHBlY3RlZAo+Pj4+IHdh cm5pbmcgYmFja3RyYWNlcyBzdGFydCAvIGVuZCBoZXJlIiB0byB0aGUga2VybmVsIGxvZy7CoCBI b3dldmVyLCB0aGF0Cj4+Pj4gd291bGQgYWdhaW4gcmVxdWlyZSBmaWx0ZXIgc2NyaXB0cywgaXQg bWlnaHQgcmVzdWx0IGluIG1pc3NpbmcgcmVhbAo+Pj4+IHByb2JsZW1hdGljIHdhcm5pbmcgYmFj a3RyYWNlcyB0cmlnZ2VyZWQgd2hpbGUgdGhlIHRlc3QgaXMgcnVubmluZywgYW5kCj4+Pj4gdGhl IGlycmVsZXZhbnQgYmFja3RyYWNlKHMpIHdvdWxkIHN0aWxsIGNsb2cgdGhlIGtlcm5lbCBsb2cu Cj4+Pj4KPj4+PiBTb2x2ZSB0aGUgcHJvYmxlbSBieSBwcm92aWRpbmcgYSBtZWFucyB0byBpZGVu dGlmeSBhbmQgc3VwcHJlc3Mgc3BlY2lmaWMKPj4+PiB3YXJuaW5nIGJhY2t0cmFjZXMgd2hpbGUg ZXhlY3V0aW5nIHRlc3QgY29kZS4gU3VwcG9ydCBzdXBwcmVzc2luZyBtdWx0aXBsZQo+Pj4+IGJh Y2t0cmFjZXMgd2hpbGUgYXQgdGhlIHNhbWUgdGltZSBsaW1pdGluZyBjaGFuZ2VzIHRvIGdlbmVy aWMgY29kZSB0byB0aGUKPj4+PiBhYnNvbHV0ZSBtaW5pbXVtLiBBcmNoaXRlY3R1cmUgc3BlY2lm aWMgY2hhbmdlcyBhcmUga2VwdCBhdCBtaW5pbXVtIGJ5Cj4+Pj4gcmV0YWluaW5nIGZ1bmN0aW9u IG5hbWVzIG9ubHkgaWYgYm90aCBDT05GSUdfREVCVUdfQlVHVkVSQk9TRSBhbmQKPj4+PiBDT05G SUdfS1VOSVQgYXJlIGVuYWJsZWQuCj4+Pj4KPj4+PiBUaGUgZmlyc3QgcGF0Y2ggb2YgdGhlIHNl cmllcyBpbnRyb2R1Y2VzIHRoZSBuZWNlc3NhcnkgaW5mcmFzdHJ1Y3R1cmUuCj4+Pj4gVGhlIHNl Y29uZCBwYXRjaCBpbnRyb2R1Y2VzIHN1cHBvcnQgZm9yIGNvdW50aW5nIHN1cHByZXNzZWQgYmFj a3RyYWNlcy4KPj4+PiBUaGlzIGNhcGFiaWxpdHkgaXMgdXNlZCBpbiBwYXRjaCB0aHJlZSB0byBp bXBsZW1lbnQgdW5pdCB0ZXN0cy4KPj4+PiBQYXRjaCBmb3VyIGRvY3VtZW50cyB0aGUgbmV3IEFQ SS4KPj4+PiBUaGUgbmV4dCB0d28gcGF0Y2hlcyBhZGQgc3VwcG9ydCBmb3Igc3VwcHJlc3Npbmcg YmFja3RyYWNlcyBpbiBkcm1fcmVjdAo+Pj4+IGFuZCBkZXZfYWRkcl9saXN0cyB1bml0IHRlc3Rz LiBUaGVzZSBwYXRjaGVzIGFyZSBpbnRlbmRlZCB0byBzZXJ2ZSBhcwo+Pj4+IGV4YW1wbGVzIGZv ciB0aGUgdXNlIG9mIHRoZSBmdW5jdGlvbmFsaXR5IGludHJvZHVjZWQgd2l0aCB0aGlzIHNlcmll cy4KPj4+PiBUaGUgcmVtYWluaW5nIHBhdGNoZXMgaW1wbGVtZW50IHRoZSBuZWNlc3NhcnkgY2hh bmdlcyBmb3IgYWxsCj4+Pj4gYXJjaGl0ZWN0dXJlcyB3aXRoIEdFTkVSSUNfQlVHIHN1cHBvcnQu Cj4+Pgo+Pj4gVGhhbmtzIGZvciB5b3VyIHNlcmllcyEKPj4+Cj4+PiBJIGdhdmUgaXQgYSB0cnkg b24gbTY4aywganVzdCBydW5uaW5nIGJhY2t0cmFjZS1zdXBwcmVzc2lvbi10ZXN0LAo+Pj4gYW5k IHRoYXQgc2VlbXMgdG8gd29yayBmaW5lLgo+Pj4KPj4+PiBEZXNpZ24gbm90ZToKPj4+PiDCoMKg IEZ1bmN0aW9uIHBvaW50ZXJzIGFyZSBvbmx5IGFkZGVkIHRvIHRoZSBfX2J1Z190YWJsZSBzZWN0 aW9uIGlmIGJvdGgKPj4+PiDCoMKgIENPTkZJR19LVU5JVCBhbmQgQ09ORklHX0RFQlVHX0JVR1ZF UkJPU0UgYXJlIGVuYWJsZWQgdG8gYXZvaWQgaW1hZ2UKPj4+PiDCoMKgIHNpemUgaW5jcmVhc2Vz IGlmIENPTkZJR19LVU5JVD1uLiBUaGVyZSB3b3VsZCBiZSBzb21lIGJlbmVmaXRzIHRvCj4+Pj4g wqDCoCBhZGRpbmcgdGhvc2UgcG9pbnRlcnMgYWxsIHRoZSB0aW1lIChyZWR1Y2VkIGNvbXBsZXhp dHksIGFiaWxpdHkgdG8KPj4+PiDCoMKgIGRpc3BsYXkgZnVuY3Rpb24gbmFtZXMgaW4gQlVHL1dB Uk5JTkcgbWVzc2FnZXMpLiBUaGF0IGNoYW5nZSwgaWYKPj4+PiDCoMKgIGRlc2lyZWQsIGNhbiBi ZSBtYWRlIGxhdGVyLgo+Pj4KPj4+IFVuZm9ydHVuYXRlbHkgdGhpcyBhbHNvIGluY3JlYXNlcyBr ZXJuZWwgc2l6ZSBpbiB0aGUgQ09ORklHX0tVTklUPW0KPj4+IGNhc2UgKGNhLiA4MCBLaUIgZm9y IGF0YXJpX2RlZmNvbmZpZyksIG1ha2luZyBpdCBsZXNzIGF0dHJhY3RpdmUgdG8gaGF2ZQo+Pj4g a3VuaXQgYW5kIGFsbCB0ZXN0cyBlbmFibGVkIGFzIG1vZHVsZXMgaW4gbXkgc3RhbmRhcmQga2Vy bmVsLgo+Pj4KPj4gCj4+IEdvb2QgcG9pbnQuIEluZGVlZCwgaXQgZG9lcy4gSSB3YW50ZWQgdG8g YXZvaWQgYWRkaW5nIGEgY29uZmlndXJhdGlvbiBvcHRpb24sCj4+IGJ1dCBtYXliZSBJIHNob3Vs ZCBhZGQgaXQgYWZ0ZXIgYWxsLiBIb3cgYWJvdXQgc29tZXRoaW5nIGxpa2UgdGhpcyA/Cj4+IAo+ PiArY29uZmlnIEtVTklUX1NVUFBSRVNTX0JBQ0tUUkFDRQo+PiArwqDCoMKgwqDCoMKgIGJvb2wg IktVbml0IC0gRW5hYmxlIGJhY2t0cmFjZSBzdXBwcmVzc2lvbiIKPj4gK8KgwqDCoMKgwqDCoCBk ZWZhdWx0IHkKPj4gK8KgwqDCoMKgwqDCoCBoZWxwCj4+ICvCoMKgwqDCoMKgwqDCoMKgIEVuYWJs ZSBiYWNrdHJhY2Ugc3VwcHJlc3Npb24gZm9yIEtVbml0LiBJZiBlbmFibGVkLCBiYWNrdHJhY2Vz Cj4+ICvCoMKgwqDCoMKgwqDCoMKgIGdlbmVyYXRlZCBpbnRlbnRpb25hbGx5IGJ5IEtVbml0IHRl c3RzIGNhbiBiZSBzdXBwcmVzc2VkLiBEaXNhYmxlCj4+ICvCoMKgwqDCoMKgwqDCoMKgIHRvIHJl ZHVjZSBrZXJuZWwgaW1hZ2Ugc2l6ZSBpZiBpbWFnZSBzaXplIGlzIG1vcmUgaW1wb3J0YW50IHRo YW4KPj4gK8KgwqDCoMKgwqDCoMKgwqAgc3VwcHJlc3Npb24gb2YgYmFja3RyYWNlcyBnZW5lcmF0 ZWQgYnkgS1VuaXQgdGVzdHMuCj4KPiBBbnkgbW9yZSBjb21tZW50cyAvIGZlZWRiYWNrIG9uIHRo aXMgPyBPdGhlcndpc2UgSSdsbCBpbnRyb2R1Y2UgdGhlCj4gYWJvdmUgY29uZmlndXJhdGlvbiBv cHRpb24gaW4gdjIgb2YgdGhlIHNlcmllcy4KPgo+IEluIHRoaXMgY29udGV4dCwgYW55IHN1Z2dl c3Rpb25zIGlmIGl0IHNob3VsZCBiZSBlbmFibGVkIG9yIGRpc2FibGVkIGJ5Cj4gZGVmYXVsdCA/ IEkgcGVyc29uYWxseSB0aGluayBpdCB3b3VsZCBiZSBtb3JlIGltcG9ydGFudCB0byBiZSBhYmxl IHRvCj4gc3VwcHJlc3MgYmFja3RyYWNlcywgYnV0IEkgdW5kZXJzdGFuZCB0aGF0IG90aGVycyBt YXkgbm90IGJlIHdpbGxpbmcgdG8KPiBhY2NlcHQgYSB+MSUgaW1hZ2Ugc2l6ZSBpbmNyZWFzZSB3 aXRoIENPTkZJR19LVU5JVD1tIHVubGVzcwo+IEtVTklUX1NVUFBSRVNTX0JBQ0tUUkFDRSBpcyBl eHBsaWNpdGx5IGRpc2FibGVkLgoKUGxlYXNlIGVuYWJsZSBpdCBieSBkZWZhdWx0LgoKVGhlcmUg YXJlIG11bHRpcGxlIENJIHN5c3RlbXMgdGhhdCB3aWxsIGJlbmVmaXQgZnJvbSBpdCwgd2hlcmVh cyB0aGUKbnVtYmVyIG9mIHVzZXJzIGVuYWJsaW5nIEtVTklUIGluIHNldmVyZWx5IHNwYWNlZCBj b25zdHJhaW50ZWQKZW52aXJvbm1lbnRzIGlzIHN1cmVseSBzbWFsbCAtIHBlcmhhcHMganVzdCBH ZWVydCA7KS4KCmNoZWVycwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtcmlzY3YgbWFpbGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1yaXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 710FEC54E5D for ; Mon, 18 Mar 2024 03:25:52 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=aZwR6Ce1; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TygH25VFzz3vX3 for ; Mon, 18 Mar 2024 14:25:50 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=aZwR6Ce1; dkim-atps=neutral Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TygGC2Wnyz3bmy for ; Mon, 18 Mar 2024 14:25:07 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1710732306; bh=NV+IEiKEp7lCdjzjbneFkp6G29/AFeVDyz/GqmHX3m4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=aZwR6Ce11vNXim4mOCh1eXkx7K65RfM+cau+BhgB9SdLqlZPW+NSBiMfH6HvhOd0A Cxq4iA45zUMfJd0t0fiCZUW9oT7MdElC1lAHDwjgYhkFVet+3SexBY3VTuWZ+t2GS/ R6YtLN+mqg6XUSgVsgcCPTEOKRlHDfSmPt/ef1FfXW6waLfQPAdiG7JMm/zsq5BT3k vdQUUXBAz8sJiI6L7YfwQCfB8GuYQWxC3Reysu8xNTnmju7VZ+DNwIB5BF60uJsyDk OdmHw4LQNlhzuekWxZGLa0lNLJlIa+tl6Z4Z3Fg6YFxfGk0yqItTN1sXJzV54NgtGp w8QwwUGGGIyQQ== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4TygG42yLDz4wc1; Mon, 18 Mar 2024 14:25:00 +1100 (AEDT) From: Michael Ellerman To: Guenter Roeck , Geert Uytterhoeven Subject: Re: [PATCH 00/14] Add support for suppressing warning backtraces In-Reply-To: <04f34097-7788-490d-a9c2-82b44bf6af44@roeck-us.net> References: <20240312170309.2546362-1-linux@roeck-us.net> <6d9269c0-bd38-4965-a454-4358e0a182e3@roeck-us.net> <04f34097-7788-490d-a9c2-82b44bf6af44@roeck-us.net> Date: Mon, 18 Mar 2024 14:24:59 +1100 Message-ID: <87ttl4z0fo.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: loongarch@lists.linux.dev, linux-doc@vger.kernel.org, dri-devel@lists.freedesktop.org, Brendan Higgins , linux-kselftest@vger.kernel.org, linux-riscv@lists.infradead.org, David Airlie , Arthur Grillo , Ville =?utf-8?B?U3lyasOkbMOk?= , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Daniel Diaz , linux-sh@vger.kernel.org, Naresh Kamboju , =?utf-8?Q?Ma=C3=ADra?= Canal , Dan Carpenter , netdev@lists.linux.dev, Kees Cook , Arnd Bergmann , Maarten Lankhorst , Maxime Ripard , David Gow , Daniel Vetter , linux-arm-kernel@lists.infradead.org, kunit-dev@googlegroups.com, linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Zimmermann , Andrew Morton , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Guenter Roeck writes: > On 3/14/24 07:37, Guenter Roeck wrote: >> On 3/14/24 06:36, Geert Uytterhoeven wrote: >>> Hi G=C3=BCnter, >>> >>> On Tue, Mar 12, 2024 at 6:03=E2=80=AFPM Guenter Roeck wrote: >>>> Some unit tests intentionally trigger warning backtraces by passing bad >>>> parameters to kernel API functions. Such unit tests typically check the >>>> return value from such calls, not the existence of the warning backtra= ce. >>>> >>>> Such intentionally generated warning backtraces are neither desirable >>>> nor useful for a number of reasons. >>>> - They can result in overlooked real problems. >>>> - A warning that suddenly starts to show up in unit tests needs to be >>>> =C2=A0=C2=A0 investigated and has to be marked to be ignored, for exam= ple by >>>> =C2=A0=C2=A0 adjusting filter scripts. Such filters are ad-hoc because= there is >>>> =C2=A0=C2=A0 no real standard format for warnings. On top of that, suc= h filter >>>> =C2=A0=C2=A0 scripts would require constant maintenance. >>>> >>>> One option to address problem would be to add messages such as "expect= ed >>>> warning backtraces start / end here" to the kernel log.=C2=A0 However,= that >>>> would again require filter scripts, it might result in missing real >>>> problematic warning backtraces triggered while the test is running, and >>>> the irrelevant backtrace(s) would still clog the kernel log. >>>> >>>> Solve the problem by providing a means to identify and suppress specif= ic >>>> warning backtraces while executing test code. Support suppressing mult= iple >>>> backtraces while at the same time limiting changes to generic code to = the >>>> absolute minimum. Architecture specific changes are kept at minimum by >>>> retaining function names only if both CONFIG_DEBUG_BUGVERBOSE and >>>> CONFIG_KUNIT are enabled. >>>> >>>> The first patch of the series introduces the necessary infrastructure. >>>> The second patch introduces support for counting suppressed backtraces. >>>> This capability is used in patch three to implement unit tests. >>>> Patch four documents the new API. >>>> The next two patches add support for suppressing backtraces in drm_rect >>>> and dev_addr_lists unit tests. These patches are intended to serve as >>>> examples for the use of the functionality introduced with this series. >>>> The remaining patches implement the necessary changes for all >>>> architectures with GENERIC_BUG support. >>> >>> Thanks for your series! >>> >>> I gave it a try on m68k, just running backtrace-suppression-test, >>> and that seems to work fine. >>> >>>> Design note: >>>> =C2=A0=C2=A0 Function pointers are only added to the __bug_table secti= on if both >>>> =C2=A0=C2=A0 CONFIG_KUNIT and CONFIG_DEBUG_BUGVERBOSE are enabled to a= void image >>>> =C2=A0=C2=A0 size increases if CONFIG_KUNIT=3Dn. There would be some b= enefits to >>>> =C2=A0=C2=A0 adding those pointers all the time (reduced complexity, a= bility to >>>> =C2=A0=C2=A0 display function names in BUG/WARNING messages). That cha= nge, if >>>> =C2=A0=C2=A0 desired, can be made later. >>> >>> Unfortunately this also increases kernel size in the CONFIG_KUNIT=3Dm >>> case (ca. 80 KiB for atari_defconfig), making it less attractive to have >>> kunit and all tests enabled as modules in my standard kernel. >>> >>=20 >> Good point. Indeed, it does. I wanted to avoid adding a configuration op= tion, >> but maybe I should add it after all. How about something like this ? >>=20 >> +config KUNIT_SUPPRESS_BACKTRACE >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bool "KUnit - Enable backtrace sup= pression" >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 default y >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 help >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Enable backtrace suppr= ession for KUnit. If enabled, backtraces >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 generated intentionall= y by KUnit tests can be suppressed. Disable >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 to reduce kernel image= size if image size is more important than >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 suppression of backtra= ces generated by KUnit tests. > > Any more comments / feedback on this ? Otherwise I'll introduce the > above configuration option in v2 of the series. > > In this context, any suggestions if it should be enabled or disabled by > default ? I personally think it would be more important to be able to > suppress backtraces, but I understand that others may not be willing to > accept a ~1% image size increase with CONFIG_KUNIT=3Dm unless > KUNIT_SUPPRESS_BACKTRACE is explicitly disabled. Please enable it by default. There are multiple CI systems that will benefit from it, whereas the number of users enabling KUNIT in severely spaced constrainted environments is surely small - perhaps just Geert ;). cheers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BADDBC54E5D for ; Mon, 18 Mar 2024 03:25:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tvJCgyiI0fCu3KO7y2/79n32QD3KpXjnqzcLfIhkRTs=; b=NFKDIOkMmAOkln O1XZvho4OOzr+Lm8NJY6e9ie5jblxMNE6Hq/lRIKyOKGH3aQxew++oinHHpweh11F+YxbcX1X8m18 Yg6JI/g2WBV7jm9gm1qPxgdM9d/EzoCphxoUK1jjfDA3bb6c9Wu4wex20Xu1sBbYJLMj9p9z+rMoO 7nQ9AFVIorTjqP22lDLAhLuBEvozh2a7saNGVbUKnN8NlQtcVVS5ahbv76TZMSKtAT85vFMZaFrAb gC3ziHb2RI/Blar82O8FY97i5qC1P90vrtC5VXSSRACLfjiNBUuaumueGkd3WRXjaZtLN1+/qlYA5 YYAbXDCpp5JzKVzJDVpw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rm3cl-000000078vk-0Hxo; Mon, 18 Mar 2024 03:25:19 +0000 Received: from gandalf.ozlabs.org ([150.107.74.76]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rm3cg-000000078t9-11Kg; Mon, 18 Mar 2024 03:25:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1710732306; bh=NV+IEiKEp7lCdjzjbneFkp6G29/AFeVDyz/GqmHX3m4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=aZwR6Ce11vNXim4mOCh1eXkx7K65RfM+cau+BhgB9SdLqlZPW+NSBiMfH6HvhOd0A Cxq4iA45zUMfJd0t0fiCZUW9oT7MdElC1lAHDwjgYhkFVet+3SexBY3VTuWZ+t2GS/ R6YtLN+mqg6XUSgVsgcCPTEOKRlHDfSmPt/ef1FfXW6waLfQPAdiG7JMm/zsq5BT3k vdQUUXBAz8sJiI6L7YfwQCfB8GuYQWxC3Reysu8xNTnmju7VZ+DNwIB5BF60uJsyDk OdmHw4LQNlhzuekWxZGLa0lNLJlIa+tl6Z4Z3Fg6YFxfGk0yqItTN1sXJzV54NgtGp w8QwwUGGGIyQQ== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4TygG42yLDz4wc1; Mon, 18 Mar 2024 14:25:00 +1100 (AEDT) From: Michael Ellerman To: Guenter Roeck , Geert Uytterhoeven Cc: linux-kselftest@vger.kernel.org, David Airlie , Arnd Bergmann , =?utf-8?Q?Ma=C3=ADra?= Canal , Dan Carpenter , Kees Cook , Daniel Diaz , David Gow , Arthur Grillo , Brendan Higgins , Naresh Kamboju , Maarten Lankhorst , Andrew Morton , Maxime Ripard , Ville =?utf-8?B?U3lyasOkbMOk?= , Daniel Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, loongarch@lists.linux.dev, netdev@lists.linux.dev Subject: Re: [PATCH 00/14] Add support for suppressing warning backtraces In-Reply-To: <04f34097-7788-490d-a9c2-82b44bf6af44@roeck-us.net> References: <20240312170309.2546362-1-linux@roeck-us.net> <6d9269c0-bd38-4965-a454-4358e0a182e3@roeck-us.net> <04f34097-7788-490d-a9c2-82b44bf6af44@roeck-us.net> Date: Mon, 18 Mar 2024 14:24:59 +1100 Message-ID: <87ttl4z0fo.fsf@mail.lhotse> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240317_202514_594342_74AD3D91 X-CRM114-Status: GOOD ( 25.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org R3VlbnRlciBSb2VjayA8bGludXhAcm9lY2stdXMubmV0PiB3cml0ZXM6Cj4gT24gMy8xNC8yNCAw NzozNywgR3VlbnRlciBSb2VjayB3cm90ZToKPj4gT24gMy8xNC8yNCAwNjozNiwgR2VlcnQgVXl0 dGVyaG9ldmVuIHdyb3RlOgo+Pj4gSGkgR8O8bnRlciwKPj4+Cj4+PiBPbiBUdWUsIE1hciAxMiwg MjAyNCBhdCA2OjAz4oCvUE0gR3VlbnRlciBSb2VjayA8bGludXhAcm9lY2stdXMubmV0PiB3cm90 ZToKPj4+PiBTb21lIHVuaXQgdGVzdHMgaW50ZW50aW9uYWxseSB0cmlnZ2VyIHdhcm5pbmcgYmFj a3RyYWNlcyBieSBwYXNzaW5nIGJhZAo+Pj4+IHBhcmFtZXRlcnMgdG8ga2VybmVsIEFQSSBmdW5j dGlvbnMuIFN1Y2ggdW5pdCB0ZXN0cyB0eXBpY2FsbHkgY2hlY2sgdGhlCj4+Pj4gcmV0dXJuIHZh bHVlIGZyb20gc3VjaCBjYWxscywgbm90IHRoZSBleGlzdGVuY2Ugb2YgdGhlIHdhcm5pbmcgYmFj a3RyYWNlLgo+Pj4+Cj4+Pj4gU3VjaCBpbnRlbnRpb25hbGx5IGdlbmVyYXRlZCB3YXJuaW5nIGJh Y2t0cmFjZXMgYXJlIG5laXRoZXIgZGVzaXJhYmxlCj4+Pj4gbm9yIHVzZWZ1bCBmb3IgYSBudW1i ZXIgb2YgcmVhc29ucy4KPj4+PiAtIFRoZXkgY2FuIHJlc3VsdCBpbiBvdmVybG9va2VkIHJlYWwg cHJvYmxlbXMuCj4+Pj4gLSBBIHdhcm5pbmcgdGhhdCBzdWRkZW5seSBzdGFydHMgdG8gc2hvdyB1 cCBpbiB1bml0IHRlc3RzIG5lZWRzIHRvIGJlCj4+Pj4gwqDCoCBpbnZlc3RpZ2F0ZWQgYW5kIGhh cyB0byBiZSBtYXJrZWQgdG8gYmUgaWdub3JlZCwgZm9yIGV4YW1wbGUgYnkKPj4+PiDCoMKgIGFk anVzdGluZyBmaWx0ZXIgc2NyaXB0cy4gU3VjaCBmaWx0ZXJzIGFyZSBhZC1ob2MgYmVjYXVzZSB0 aGVyZSBpcwo+Pj4+IMKgwqAgbm8gcmVhbCBzdGFuZGFyZCBmb3JtYXQgZm9yIHdhcm5pbmdzLiBP biB0b3Agb2YgdGhhdCwgc3VjaCBmaWx0ZXIKPj4+PiDCoMKgIHNjcmlwdHMgd291bGQgcmVxdWly ZSBjb25zdGFudCBtYWludGVuYW5jZS4KPj4+Pgo+Pj4+IE9uZSBvcHRpb24gdG8gYWRkcmVzcyBw cm9ibGVtIHdvdWxkIGJlIHRvIGFkZCBtZXNzYWdlcyBzdWNoIGFzICJleHBlY3RlZAo+Pj4+IHdh cm5pbmcgYmFja3RyYWNlcyBzdGFydCAvIGVuZCBoZXJlIiB0byB0aGUga2VybmVsIGxvZy7CoCBI b3dldmVyLCB0aGF0Cj4+Pj4gd291bGQgYWdhaW4gcmVxdWlyZSBmaWx0ZXIgc2NyaXB0cywgaXQg bWlnaHQgcmVzdWx0IGluIG1pc3NpbmcgcmVhbAo+Pj4+IHByb2JsZW1hdGljIHdhcm5pbmcgYmFj a3RyYWNlcyB0cmlnZ2VyZWQgd2hpbGUgdGhlIHRlc3QgaXMgcnVubmluZywgYW5kCj4+Pj4gdGhl IGlycmVsZXZhbnQgYmFja3RyYWNlKHMpIHdvdWxkIHN0aWxsIGNsb2cgdGhlIGtlcm5lbCBsb2cu Cj4+Pj4KPj4+PiBTb2x2ZSB0aGUgcHJvYmxlbSBieSBwcm92aWRpbmcgYSBtZWFucyB0byBpZGVu dGlmeSBhbmQgc3VwcHJlc3Mgc3BlY2lmaWMKPj4+PiB3YXJuaW5nIGJhY2t0cmFjZXMgd2hpbGUg ZXhlY3V0aW5nIHRlc3QgY29kZS4gU3VwcG9ydCBzdXBwcmVzc2luZyBtdWx0aXBsZQo+Pj4+IGJh Y2t0cmFjZXMgd2hpbGUgYXQgdGhlIHNhbWUgdGltZSBsaW1pdGluZyBjaGFuZ2VzIHRvIGdlbmVy aWMgY29kZSB0byB0aGUKPj4+PiBhYnNvbHV0ZSBtaW5pbXVtLiBBcmNoaXRlY3R1cmUgc3BlY2lm aWMgY2hhbmdlcyBhcmUga2VwdCBhdCBtaW5pbXVtIGJ5Cj4+Pj4gcmV0YWluaW5nIGZ1bmN0aW9u IG5hbWVzIG9ubHkgaWYgYm90aCBDT05GSUdfREVCVUdfQlVHVkVSQk9TRSBhbmQKPj4+PiBDT05G SUdfS1VOSVQgYXJlIGVuYWJsZWQuCj4+Pj4KPj4+PiBUaGUgZmlyc3QgcGF0Y2ggb2YgdGhlIHNl cmllcyBpbnRyb2R1Y2VzIHRoZSBuZWNlc3NhcnkgaW5mcmFzdHJ1Y3R1cmUuCj4+Pj4gVGhlIHNl Y29uZCBwYXRjaCBpbnRyb2R1Y2VzIHN1cHBvcnQgZm9yIGNvdW50aW5nIHN1cHByZXNzZWQgYmFj a3RyYWNlcy4KPj4+PiBUaGlzIGNhcGFiaWxpdHkgaXMgdXNlZCBpbiBwYXRjaCB0aHJlZSB0byBp bXBsZW1lbnQgdW5pdCB0ZXN0cy4KPj4+PiBQYXRjaCBmb3VyIGRvY3VtZW50cyB0aGUgbmV3IEFQ SS4KPj4+PiBUaGUgbmV4dCB0d28gcGF0Y2hlcyBhZGQgc3VwcG9ydCBmb3Igc3VwcHJlc3Npbmcg YmFja3RyYWNlcyBpbiBkcm1fcmVjdAo+Pj4+IGFuZCBkZXZfYWRkcl9saXN0cyB1bml0IHRlc3Rz LiBUaGVzZSBwYXRjaGVzIGFyZSBpbnRlbmRlZCB0byBzZXJ2ZSBhcwo+Pj4+IGV4YW1wbGVzIGZv ciB0aGUgdXNlIG9mIHRoZSBmdW5jdGlvbmFsaXR5IGludHJvZHVjZWQgd2l0aCB0aGlzIHNlcmll cy4KPj4+PiBUaGUgcmVtYWluaW5nIHBhdGNoZXMgaW1wbGVtZW50IHRoZSBuZWNlc3NhcnkgY2hh bmdlcyBmb3IgYWxsCj4+Pj4gYXJjaGl0ZWN0dXJlcyB3aXRoIEdFTkVSSUNfQlVHIHN1cHBvcnQu Cj4+Pgo+Pj4gVGhhbmtzIGZvciB5b3VyIHNlcmllcyEKPj4+Cj4+PiBJIGdhdmUgaXQgYSB0cnkg b24gbTY4aywganVzdCBydW5uaW5nIGJhY2t0cmFjZS1zdXBwcmVzc2lvbi10ZXN0LAo+Pj4gYW5k IHRoYXQgc2VlbXMgdG8gd29yayBmaW5lLgo+Pj4KPj4+PiBEZXNpZ24gbm90ZToKPj4+PiDCoMKg IEZ1bmN0aW9uIHBvaW50ZXJzIGFyZSBvbmx5IGFkZGVkIHRvIHRoZSBfX2J1Z190YWJsZSBzZWN0 aW9uIGlmIGJvdGgKPj4+PiDCoMKgIENPTkZJR19LVU5JVCBhbmQgQ09ORklHX0RFQlVHX0JVR1ZF UkJPU0UgYXJlIGVuYWJsZWQgdG8gYXZvaWQgaW1hZ2UKPj4+PiDCoMKgIHNpemUgaW5jcmVhc2Vz IGlmIENPTkZJR19LVU5JVD1uLiBUaGVyZSB3b3VsZCBiZSBzb21lIGJlbmVmaXRzIHRvCj4+Pj4g wqDCoCBhZGRpbmcgdGhvc2UgcG9pbnRlcnMgYWxsIHRoZSB0aW1lIChyZWR1Y2VkIGNvbXBsZXhp dHksIGFiaWxpdHkgdG8KPj4+PiDCoMKgIGRpc3BsYXkgZnVuY3Rpb24gbmFtZXMgaW4gQlVHL1dB Uk5JTkcgbWVzc2FnZXMpLiBUaGF0IGNoYW5nZSwgaWYKPj4+PiDCoMKgIGRlc2lyZWQsIGNhbiBi ZSBtYWRlIGxhdGVyLgo+Pj4KPj4+IFVuZm9ydHVuYXRlbHkgdGhpcyBhbHNvIGluY3JlYXNlcyBr ZXJuZWwgc2l6ZSBpbiB0aGUgQ09ORklHX0tVTklUPW0KPj4+IGNhc2UgKGNhLiA4MCBLaUIgZm9y IGF0YXJpX2RlZmNvbmZpZyksIG1ha2luZyBpdCBsZXNzIGF0dHJhY3RpdmUgdG8gaGF2ZQo+Pj4g a3VuaXQgYW5kIGFsbCB0ZXN0cyBlbmFibGVkIGFzIG1vZHVsZXMgaW4gbXkgc3RhbmRhcmQga2Vy bmVsLgo+Pj4KPj4gCj4+IEdvb2QgcG9pbnQuIEluZGVlZCwgaXQgZG9lcy4gSSB3YW50ZWQgdG8g YXZvaWQgYWRkaW5nIGEgY29uZmlndXJhdGlvbiBvcHRpb24sCj4+IGJ1dCBtYXliZSBJIHNob3Vs ZCBhZGQgaXQgYWZ0ZXIgYWxsLiBIb3cgYWJvdXQgc29tZXRoaW5nIGxpa2UgdGhpcyA/Cj4+IAo+ PiArY29uZmlnIEtVTklUX1NVUFBSRVNTX0JBQ0tUUkFDRQo+PiArwqDCoMKgwqDCoMKgIGJvb2wg IktVbml0IC0gRW5hYmxlIGJhY2t0cmFjZSBzdXBwcmVzc2lvbiIKPj4gK8KgwqDCoMKgwqDCoCBk ZWZhdWx0IHkKPj4gK8KgwqDCoMKgwqDCoCBoZWxwCj4+ICvCoMKgwqDCoMKgwqDCoMKgIEVuYWJs ZSBiYWNrdHJhY2Ugc3VwcHJlc3Npb24gZm9yIEtVbml0LiBJZiBlbmFibGVkLCBiYWNrdHJhY2Vz Cj4+ICvCoMKgwqDCoMKgwqDCoMKgIGdlbmVyYXRlZCBpbnRlbnRpb25hbGx5IGJ5IEtVbml0IHRl c3RzIGNhbiBiZSBzdXBwcmVzc2VkLiBEaXNhYmxlCj4+ICvCoMKgwqDCoMKgwqDCoMKgIHRvIHJl ZHVjZSBrZXJuZWwgaW1hZ2Ugc2l6ZSBpZiBpbWFnZSBzaXplIGlzIG1vcmUgaW1wb3J0YW50IHRo YW4KPj4gK8KgwqDCoMKgwqDCoMKgwqAgc3VwcHJlc3Npb24gb2YgYmFja3RyYWNlcyBnZW5lcmF0 ZWQgYnkgS1VuaXQgdGVzdHMuCj4KPiBBbnkgbW9yZSBjb21tZW50cyAvIGZlZWRiYWNrIG9uIHRo aXMgPyBPdGhlcndpc2UgSSdsbCBpbnRyb2R1Y2UgdGhlCj4gYWJvdmUgY29uZmlndXJhdGlvbiBv cHRpb24gaW4gdjIgb2YgdGhlIHNlcmllcy4KPgo+IEluIHRoaXMgY29udGV4dCwgYW55IHN1Z2dl c3Rpb25zIGlmIGl0IHNob3VsZCBiZSBlbmFibGVkIG9yIGRpc2FibGVkIGJ5Cj4gZGVmYXVsdCA/ IEkgcGVyc29uYWxseSB0aGluayBpdCB3b3VsZCBiZSBtb3JlIGltcG9ydGFudCB0byBiZSBhYmxl IHRvCj4gc3VwcHJlc3MgYmFja3RyYWNlcywgYnV0IEkgdW5kZXJzdGFuZCB0aGF0IG90aGVycyBt YXkgbm90IGJlIHdpbGxpbmcgdG8KPiBhY2NlcHQgYSB+MSUgaW1hZ2Ugc2l6ZSBpbmNyZWFzZSB3 aXRoIENPTkZJR19LVU5JVD1tIHVubGVzcwo+IEtVTklUX1NVUFBSRVNTX0JBQ0tUUkFDRSBpcyBl eHBsaWNpdGx5IGRpc2FibGVkLgoKUGxlYXNlIGVuYWJsZSBpdCBieSBkZWZhdWx0LgoKVGhlcmUg YXJlIG11bHRpcGxlIENJIHN5c3RlbXMgdGhhdCB3aWxsIGJlbmVmaXQgZnJvbSBpdCwgd2hlcmVh cyB0aGUKbnVtYmVyIG9mIHVzZXJzIGVuYWJsaW5nIEtVTklUIGluIHNldmVyZWx5IHNwYWNlZCBj b25zdHJhaW50ZWQKZW52aXJvbm1lbnRzIGlzIHN1cmVseSBzbWFsbCAtIHBlcmhhcHMganVzdCBH ZWVydCA7KS4KCmNoZWVycwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtYXJtLWtlcm5lbAo=