From: Jonathan Corbet <corbet@lwn.net>
To: Anna-Maria Behnsen <anna-maria@linutronix.de>, linux-doc@vger.kernel.org
Cc: Matthew Wilcox <willy@infradead.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Anna-Maria Behnsen <anna-maria@linutronix.de>
Subject: Re: [RFC PATCH 0/2] kernel-doc: Do not pre-process comments
Date: Tue, 16 Jan 2024 13:21:50 -0700 [thread overview]
Message-ID: <87ttnd9ggx.fsf@meer.lwn.net> (raw)
In-Reply-To: <20240116151456.48238-1-anna-maria@linutronix.de>
Anna-Maria Behnsen <anna-maria@linutronix.de> writes:
> this is a RFC as I'm not quite sure if this change has some subtle side
> effect.
Turns out it does, unfortunately. Consider a hunk like this:
> /**
> - * drm_gem_vram_fill_create_dumb() - \
> - Helper for implementing &struct drm_driver.dumb_create
> + * drm_gem_vram_fill_create_dumb() - Helper for implementing
> + * &struct drm_driver.dumb_create
> + *
> * @file: the DRM file
> * @dev: the DRM device
> * @pg_align: the buffer's alignment in multiples of the page size
> * @pitch_align: the scanline's alignment in powers of 2
> - * @args: the arguments as provided to \
> - &struct drm_driver.dumb_create
> + * @args: the arguments as provided to
> + * &struct drm_driver.dumb_create
> *
> * This helper function fills &struct drm_mode_create_dumb, which is used
The change to the description line is fine, it handles that. But the
same is not true within the arguments; kernel-doc seems to simply drop
the continuation lines entirely, for some strange reason.
I think it's fair to call that a bug, and it shouldn't be *that* hard to
fix. But it involves wading fairly deep into the Perl swamp, I may not
get there right away.
Thanks,
jon
next prev parent reply other threads:[~2024-01-16 20:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 15:14 [RFC PATCH 0/2] kernel-doc: Do not pre-process comments Anna-Maria Behnsen
2024-01-16 15:14 ` [RFC PATCH 1/2] drm/vram-helper: Fix 'multi-line' kernel-doc comments Anna-Maria Behnsen
2024-01-17 8:47 ` Jani Nikula
2024-01-22 9:13 ` Anna-Maria Behnsen
2024-01-16 15:14 ` [RFC PATCH 2/2] scripts/kernel-doc: Do not process backslash lines in comments Anna-Maria Behnsen
2024-01-16 20:21 ` Jonathan Corbet [this message]
2024-01-16 21:13 ` [RFC PATCH 0/2] kernel-doc: Do not pre-process comments Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttnd9ggx.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=airlied@gmail.com \
--cc=anna-maria@linutronix.de \
--cc=daniel@ffwll.ch \
--cc=linux-doc@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.