From: Jani Nikula <jani.nikula@intel.com>
To: Patchwork <patchwork@emeril.freedesktop.org>
Cc: intel-xe@lists.freedesktop.org
Subject: Re: ✗ CI.checkpatch: warning for drm/xe: display support should not depend on EXPERT
Date: Thu, 11 Jan 2024 13:29:18 +0200 [thread overview]
Message-ID: <87ttnkt8fl.fsf@intel.com> (raw)
In-Reply-To: <170497212931.271298.16781504254126615026@5338d5abeb45>
On Thu, 11 Jan 2024, Patchwork <patchwork@emeril.freedesktop.org> wrote:
> == Series Details ==
>
> Series: drm/xe: display support should not depend on EXPERT
> URL : https://patchwork.freedesktop.org/series/128648/
> State : warning
>
> == Summary ==
>
> + KERNEL=/kernel
> + git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
> Cloning into 'mt'...
> warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
> + git -C mt rev-list -n1 origin/master
> faa12d3432d7ef7793d934cd9338c555e95a5aad
> + cd /kernel
> + git config --global --add safe.directory /kernel
> + git log -n1
> commit 9b662af5259f4ddaac4101a7ce4ecdfe606f08b7
> Author: Jani Nikula <jani.nikula@intel.com>
> Date: Thu Jan 11 12:47:16 2024 +0200
>
> drm/xe: display support should not depend on EXPERT
>
> Remove the DRM_XE_DISPLAY config dependency on EXPERT. I can only
> presume the idea was only experts should be able to disable it, but the
> effect is the opposite.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> Reported-by: Eero Tamminen <eero.t.tamminen@intel.com>
> Reviewed-by: Francois Dugast <francois.dugast@intel.com>
> + /mt/dim checkpatch 79184e72263e91528195db01783148435c7e4fad drm-intel
> 9b662af52 drm/xe: display support should not depend on EXPERT
> -:11: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report
Kind of hard when it was in private. :p
BR,
Jani.
> #11:
> Reported-by: Eero Tamminen <eero.t.tamminen@intel.com>
> Reviewed-by: Francois Dugast <francois.dugast@intel.com>
>
> total: 0 errors, 1 warnings, 0 checks, 8 lines checked
>
>
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-01-11 11:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 10:47 [PATCH] drm/xe: display support should not depend on EXPERT Jani Nikula
2024-01-11 10:48 ` Jani Nikula
2024-01-11 10:58 ` Francois Dugast
2024-01-15 7:33 ` Jani Nikula
2024-01-11 11:21 ` ✓ CI.Patch_applied: success for " Patchwork
2024-01-11 11:22 ` ✗ CI.checkpatch: warning " Patchwork
2024-01-11 11:29 ` Jani Nikula [this message]
2024-01-11 11:23 ` ✓ CI.KUnit: success " Patchwork
2024-01-11 11:30 ` ✓ CI.Build: " Patchwork
2024-01-11 11:31 ` ✓ CI.Hooks: " Patchwork
2024-01-11 11:32 ` ✓ CI.checksparse: " Patchwork
2024-01-11 12:07 ` ✓ CI.BAT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttnkt8fl.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=patchwork@emeril.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.