All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Vegard Nossum <vegard.nossum@oracle.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-doc@vger.kernel.org,
	Vegard Nossum <vegard.nossum@oracle.com>,
	Jani Nikula <jani.nikula@intel.com>
Subject: Re: [RFC PATCH 1/2] scripts/get_abi: fix source path leak
Date: Wed, 03 Jan 2024 14:02:02 -0700	[thread overview]
Message-ID: <87ttnu871x.fsf@meer.lwn.net> (raw)
In-Reply-To: <20231231235959.3342928-1-vegard.nossum@oracle.com>

Vegard Nossum <vegard.nossum@oracle.com> writes:

> The code currently leaks the absolute path of the ABI files into the
> rendered documentation.
>
> There exists code to prevent this, but it is not effective when an
> absolute path is passed, which it is when $srctree is used.
>
> I consider this to be a minimal, stop-gap fix; a better fix would strip
> off the actual prefix instead of hacking it off with a regex.
>
> Link: https://mastodon.social/@vegard/111677490643495163
> Cc: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>

This definitely is worth fixing; I'm a bit annoyed that I let these
problems through.  I've tossed in a Cc: stable as well, backporting them
can only do good.

Thanks,

jon

      parent reply	other threads:[~2024-01-03 21:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-31 23:59 [RFC PATCH 1/2] scripts/get_abi: fix source path leak Vegard Nossum
2023-12-31 23:59 ` [RFC PATCH 2/2] docs: kernel_abi.py: fix command injection Vegard Nossum
2024-01-03 21:02 ` Jonathan Corbet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttnu871x.fsf@meer.lwn.net \
    --to=corbet@lwn.net \
    --cc=jani.nikula@intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=vegard.nossum@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.