From: Peter Korsgaard <peter@korsgaard.com>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: Daniel Price <daniel.price@gmail.com>,
Martin Bark <martin@barkynet.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/nodejs/nodejs-src: fix arch check on additional modules
Date: Fri, 10 Nov 2023 18:39:21 +0100 [thread overview]
Message-ID: <87ttptjynq.fsf@48ers.dk> (raw)
In-Reply-To: <20231105142405.71631-1-giulio.benetti@benettiengineering.com> (Giulio Benetti's message of "Sun, 5 Nov 2023 15:24:05 +0100")
>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:
> At the moment check-bin-arch script finds NodeJS modules containing
> prebuilt binaries for different architectures and build fails.
> So let check-bin-arch to ignore folder /usr/lib/node_modules by setting
> NODEJS_SRC_BIN_ARCH_EXCLUDE to it.
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> package/nodejs/nodejs-src/nodejs-src.mk | 3 +++
> 1 file changed, 3 insertions(+)
> diff --git a/package/nodejs/nodejs-src/nodejs-src.mk b/package/nodejs/nodejs-src/nodejs-src.mk
> index 6fb550f158..8f934202b0 100644
> --- a/package/nodejs/nodejs-src/nodejs-src.mk
> +++ b/package/nodejs/nodejs-src/nodejs-src.mk
> @@ -244,6 +244,9 @@ define NODEJS_SRC_INSTALL_MODULES
> # help in diagnosing the problem.
> $(NPM) install -g $(NODEJS_SRC_MODULES_LIST)
> endef
> +
> +# Exclude prebuilt binaries with different architectures and OS from check
> +NODEJS_SRC_BIN_ARCH_EXCLUDE = /usr/lib/node_modules/
> endif
Committed to 2023.02.x and 2023.08.x (after moving it to the nodejs
package and adjusting the variable name to match), thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-11-10 17:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-05 14:24 [Buildroot] [PATCH] package/nodejs/nodejs-src: fix arch check on additional modules Giulio Benetti
2023-11-05 14:27 ` Giulio Benetti
2023-11-06 9:32 ` Yegor Yefremov via buildroot
2023-11-06 19:13 ` Marcus Hoffmann via buildroot
2023-11-07 21:39 ` Yann E. MORIN
2023-11-10 17:39 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttptjynq.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=daniel.price@gmail.com \
--cc=giulio.benetti@benettiengineering.com \
--cc=martin@barkynet.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.