From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D728EC4332F for ; Thu, 9 Nov 2023 15:33:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8416F10E8CD; Thu, 9 Nov 2023 15:33:51 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by gabe.freedesktop.org (Postfix) with ESMTPS id 00CC210E8CA; Thu, 9 Nov 2023 15:33:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699544021; x=1731080021; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=tbZO18Gel9lZlrdpPSwwRYT3gC3jFkA9CmWrS6PEOS4=; b=F7/ttde6eYpSwJD3AqSKYATfsZdWl3gkqwFv6m+eqmBaL5VSHKp2h7Ek vYqJXzDr0mrpLjK0lnzn1cWmT0W7+PkBy9T7INpyKCp8ODuBHCvuwYLBF kNiBguvXiYJeS5HyGmfrjcU8vpsRXzKP3HJhKL+PZGTavWeTK9ytuZRlR 0dKkuzvC1BpwWJIfq4dknhIgme8vl96JPSRz28rPrHvj5Y13aGyf2mJPT BdejmDFCFkjCpTYoSwD00M44h+BCpXzADA1B8L0VvS61WtIxASVKqsajB 7rOP4gwZM7CM5LJir0uccfC/YeIkbn62qOLy4Q5Uy40+Zp0fXhUtFdoyh w==; X-IronPort-AV: E=McAfee;i="6600,9927,10889"; a="11554021" X-IronPort-AV: E=Sophos;i="6.03,289,1694761200"; d="scan'208";a="11554021" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2023 07:33:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10889"; a="833855753" X-IronPort-AV: E=Sophos;i="6.03,289,1694761200"; d="scan'208";a="833855753" Received: from unknown (HELO localhost) ([10.237.66.162]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2023 07:33:29 -0800 From: Jani Nikula To: dri-devel@lists.freedesktop.org, Maxime Ripard , Maarten Lankhorst , Thomas Zimmermann In-Reply-To: <877cn04hvq.fsf@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <877cn04hvq.fsf@intel.com> Date: Thu, 09 Nov 2023 17:33:26 +0200 Message-ID: <87ttpvvt4p.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH v2 0/6] drm/edid: split out drm_eld.[ch], add some SAD helpers X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 02 Nov 2023, Jani Nikula wrote: > On Tue, 31 Oct 2023, Jani Nikula wrote: >> v2 of https://patchwork.freedesktop.org/series/123384/ >> >> Jani Nikula (6): >> drm/edid: split out drm_eld.h from drm_edid.h >> drm/eld: replace uint8_t with u8 >> drm/edid: include drm_eld.h only where required >> drm/edid: use a temp variable for sads to drop one level of >> dereferences >> drm/edid: add helpers to get/set struct cea_sad from/to 3-byte sad >> drm/eld: add helpers to modify the SADs of an ELD > > Maxime, Maarten, Thomas - > > I'm moving a bunch of code around here, and would like to get your acks > before merging. I'm planning on merging this via drm-misc-next, it's > just that it only has Intel reviews, and don't want to feel like I'm > sneaking this in. Merged with Maxime's IRC ack, which I forgot to add to the commit messages. *facepalm*. Sorry about that. Thanks Mitul for reviews! BR, Jani. > > Thanks, > Jani. > >> >> Documentation/gpu/drm-kms-helpers.rst | 6 + >> drivers/gpu/drm/Makefile | 1 + >> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + >> drivers/gpu/drm/drm_edid.c | 43 +++-- >> drivers/gpu/drm/drm_eld.c | 55 ++++++ >> drivers/gpu/drm/drm_internal.h | 6 + >> drivers/gpu/drm/i915/display/intel_audio.c | 1 + >> .../drm/i915/display/intel_crtc_state_dump.c | 1 + >> drivers/gpu/drm/i915/display/intel_sdvo.c | 1 + >> drivers/gpu/drm/nouveau/dispnv50/disp.c | 1 + >> drivers/gpu/drm/radeon/radeon_audio.c | 1 + >> drivers/gpu/drm/tegra/hdmi.c | 1 + >> drivers/gpu/drm/tegra/sor.c | 1 + >> include/drm/drm_edid.h | 148 ---------------- >> include/drm/drm_eld.h | 164 ++++++++++++++++++ >> sound/core/pcm_drm_eld.c | 1 + >> sound/soc/codecs/hdac_hdmi.c | 1 + >> sound/soc/codecs/hdmi-codec.c | 1 + >> sound/x86/intel_hdmi_audio.c | 1 + >> 19 files changed, 275 insertions(+), 160 deletions(-) >> create mode 100644 drivers/gpu/drm/drm_eld.c >> create mode 100644 include/drm/drm_eld.h -- Jani Nikula, Intel