From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9FDA1CDB47E for ; Wed, 18 Oct 2023 11:53:34 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qt56v-0004Ei-6J; Wed, 18 Oct 2023 07:53:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qt56u-0004EK-7e for qemu-devel@nongnu.org; Wed, 18 Oct 2023 07:53:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qt56s-0001DR-OJ for qemu-devel@nongnu.org; Wed, 18 Oct 2023 07:53:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697629989; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JVTp81euMeasMpF3QQPkS0JPGrzZL6UmHdiaSyIdL5M=; b=W7TOa3WtO/orVDZhTXCkjt4lAXBA6nHs+PoIUhwRwzt/GcaafNnHq7lCFYexK7MJdyyf2f Eox1+e7TO6cc/UmAHLONQ5gapiGNCKD6DH878hYTlrJsbLJytSEb2xS28quN1yVDxKUQL0 +0Xc3MP1StimWIASn8ZV5l1/PQU/h/c= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-502-jMecBYShMgqu9V8ZdAPViA-1; Wed, 18 Oct 2023 07:52:56 -0400 X-MC-Unique: jMecBYShMgqu9V8ZdAPViA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 93C7F88B785; Wed, 18 Oct 2023 11:52:55 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.193.56]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 722518C1; Wed, 18 Oct 2023 11:52:55 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 6A1C521E6A1F; Wed, 18 Oct 2023 13:52:54 +0200 (CEST) From: Markus Armbruster To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= Cc: qemu-devel@nongnu.org, Michael Roth Subject: Re: [PATCH v2] qapi: provide a friendly string representation of QAPI classes References: <20230922153257.352911-1-berrange@redhat.com> <87v8b4ryjf.fsf@pond.sub.org> Date: Wed, 18 Oct 2023 13:52:54 +0200 In-Reply-To: ("Daniel P. =?utf-8?Q?Berrang?= =?utf-8?Q?=C3=A9=22's?= message of "Wed, 18 Oct 2023 12:05:08 +0100") Message-ID: <87ttqop2p5.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Daniel P. Berrang=C3=A9 writes: > On Wed, Oct 18, 2023 at 12:54:28PM +0200, Markus Armbruster wrote: >> Daniel P. Berrang=C3=A9 writes: >>=20 >> > If printing a QAPI schema object for debugging we get the classname and >> > a hex value for the instance: >> > >> > >> > >> > >> > >> > With this change we instead get the classname and the human friendly >> > name of the QAPI type instance: >> > >> > >> > >> > >>=20 >> This gains the QAPI name (good), but loses the address. The actual >> address is rarely useful (when it is, you're deep in Python innards; >> good luck, you'll need it). Except they let me see which objects are >> the same, and which are different. Could that be preserved without >> trouble somehow? > > It appears the hex value comes from 'id(obj)', so yes, I can > insert the same hex value into the new representation. I'd appreciate that. >> > Signed-off-by: Daniel P. Berrang=C3=A9 >> > --- >> > >> > v1 was two & half years ago: >> > >> > https://mail.gnu.org/archive/html/qemu-devel/2021-03/msg01645.html >>=20 >> Was it my fault? If yes, I apologize. > > No, I forgot about it until I was moving old branches from my previous > laptop to my new laptops :-) Puh! [...]