From: Markus Armbruster <armbru@redhat.com>
To: Fiona Ebner <f.ebner@proxmox.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
eblake@redhat.com, hreitz@redhat.com, kwolf@redhat.com,
vsementsov@yandex-team.ru, jsnow@redhat.com, den@virtuozzo.com,
t.lamprecht@proxmox.com, alexander.ivanov@virtuozzo.com
Subject: Re: [PATCH v3 6/9] qapi/block-core: use JobType for BlockJobInfo's type
Date: Wed, 18 Oct 2023 11:37:36 +0200 [thread overview]
Message-ID: <87ttqouv8f.fsf@pond.sub.org> (raw)
In-Reply-To: <20231013092143.365296-7-f.ebner@proxmox.com> (Fiona Ebner's message of "Fri, 13 Oct 2023 11:21:40 +0200")
Fiona Ebner <f.ebner@proxmox.com> writes:
> In preparation to turn BlockJobInfo into a union with @type as the
> discriminator. That requires it to be an enum.
>
> No functional change is intended.
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Replacing str by enum makes sense whether we need enum for a union or
not.
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2023-10-18 9:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 9:21 [PATCH v3 0/9] mirror: allow switching from background to active mode Fiona Ebner
2023-10-13 9:21 ` [PATCH v3 1/9] blockjob: introduce block-job-change QMP command Fiona Ebner
2023-10-18 15:52 ` Kevin Wolf
2023-10-23 9:31 ` Fiona Ebner
2023-10-23 13:42 ` Kevin Wolf
2023-10-13 9:21 ` [PATCH v3 2/9] block/mirror: set actively_synced even after the job is ready Fiona Ebner
2023-10-13 9:21 ` [PATCH v3 3/9] block/mirror: move dirty bitmap to filter Fiona Ebner
2023-10-13 9:21 ` [PATCH v3 4/9] block/mirror: determine copy_to_target only once Fiona Ebner
2023-10-13 9:21 ` [PATCH v3 5/9] mirror: implement mirror_change method Fiona Ebner
2023-10-18 9:38 ` Markus Armbruster
2023-10-18 16:59 ` Kevin Wolf
2023-10-23 11:37 ` Fiona Ebner
2023-10-23 12:59 ` Kevin Wolf
2023-10-23 14:14 ` Fiona Ebner
2023-10-24 11:04 ` Kevin Wolf
2023-10-13 9:21 ` [PATCH v3 6/9] qapi/block-core: use JobType for BlockJobInfo's type Fiona Ebner
2023-10-18 9:37 ` Markus Armbruster [this message]
2023-10-13 9:21 ` [PATCH v3 7/9] qapi/block-core: turn BlockJobInfo into a union Fiona Ebner
2023-10-13 9:21 ` [PATCH v3 8/9] blockjob: query driver-specific info via a new 'query' driver method Fiona Ebner
2023-10-13 9:21 ` [PATCH v3 9/9] mirror: return mirror-specific information upon query Fiona Ebner
2023-10-18 9:41 ` [PATCH v3 0/9] mirror: allow switching from background to active mode Markus Armbruster
2023-10-18 9:45 ` Fiona Ebner
2023-11-03 9:37 ` Markus Armbruster
2023-10-19 13:36 ` Kevin Wolf
2023-10-23 11:39 ` Fiona Ebner
2023-10-25 12:27 ` Fiona Ebner
2023-10-25 15:20 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttqouv8f.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=alexander.ivanov@virtuozzo.com \
--cc=den@virtuozzo.com \
--cc=eblake@redhat.com \
--cc=f.ebner@proxmox.com \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=t.lamprecht@proxmox.com \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.