From: Markus Armbruster <armbru@redhat.com>
To: Victor Toso <victortoso@redhat.com>
Cc: qemu-devel@nongnu.org, "John Snow" <jsnow@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH v2 07/11] qapi: fix example of query-rocker-of-dpa-flows command
Date: Thu, 14 Sep 2023 15:50:23 +0200 [thread overview]
Message-ID: <87ttrwn9sw.fsf@pond.sub.org> (raw)
In-Reply-To: <20230911104017.65397-8-victortoso@redhat.com> (Victor Toso's message of "Mon, 11 Sep 2023 12:40:15 +0200")
Victor Toso <victortoso@redhat.com> writes:
> Example output has a comment embedded in the array. Remove it.
> The end result is a list of size 1.
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> ---
> qapi/rocker.json | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/qapi/rocker.json b/qapi/rocker.json
> index 31ce0b36f6..858e4f4a45 100644
> --- a/qapi/rocker.json
> +++ b/qapi/rocker.json
> @@ -249,8 +249,7 @@
> # "cookie": 0,
> # "action": {"goto-tbl": 10},
> # "mask": {"in-pport": 4294901760}
> -# },
> -# {...more...},
> +# }
> # ]}
> ##
> { 'command': 'query-rocker-of-dpa-flows',
The schema patches in this series fix typos, except for this patch and
the next one, which drop "more of the same omitted for brevity" text. I
believe you drop the text because it doesn't parse as JSON.
Fine if the example still make sense afterwards. Do they?
Shortening examples is a reasonable thing to do. Perhaps we should
adopt a conventional way to do it, and teach the proposed generator to
cope with it. What do you think?
next prev parent reply other threads:[~2023-09-14 13:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 10:40 [PATCH v2 00/11] Validate and test qapi examples Victor Toso
2023-09-11 10:40 ` [PATCH v2 01/11] qapi: fix example of get-win32-socket command Victor Toso
2023-09-11 10:40 ` [PATCH v2 02/11] qapi: fix example of dumpdtb command Victor Toso
2023-09-11 10:40 ` [PATCH v2 03/11] qapi: fix example of cancel-vcpu-dirty-limit command Victor Toso
2023-09-11 10:40 ` [PATCH v2 04/11] qapi: fix example of set-vcpu-dirty-limit command Victor Toso
2023-09-11 10:40 ` [PATCH v2 05/11] qapi: fix example of calc-dirty-rate command Victor Toso
2023-09-11 10:40 ` [PATCH v2 06/11] qapi: fix example of NETDEV_STREAM_CONNECTED event Victor Toso
2023-09-11 10:40 ` [PATCH v2 07/11] qapi: fix example of query-rocker-of-dpa-flows command Victor Toso
2023-09-11 10:53 ` Daniel P. Berrangé
2023-09-14 13:50 ` Markus Armbruster [this message]
2023-09-14 14:01 ` Victor Toso
2023-09-14 14:15 ` Daniel P. Berrangé
2023-09-11 10:40 ` [PATCH v2 08/11] qapi: fix example of query-spice command Victor Toso
2023-09-11 10:53 ` Daniel P. Berrangé
2023-09-11 10:40 ` [PATCH v2 09/11] qapi: fix example of query-blockstats command Victor Toso
2023-09-11 10:55 ` Daniel P. Berrangé
2023-09-11 11:27 ` [PATCH v2 10/11] qapi: meson: add test flag to allow skip generators Victor Toso
2023-09-11 11:27 ` [PATCH v2 11/11] qapi: scripts: add a generator for qapi's examples Victor Toso
2023-09-14 13:51 ` [PATCH v2 00/11] Validate and test qapi examples Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttrwn9sw.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=victortoso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.