From: Peter Korsgaard <peter@korsgaard.com>
To: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
Cc: Andreas Ziegler <br015@umbiko.net>,
YANN E MORIN <yann.morin.1998@free.fr>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [Buildroot] [PATCH v2 1/4] package/mpd: fix reversed logic in tcp disable
Date: Mon, 11 Sep 2023 09:22:59 +0200 [thread overview]
Message-ID: <87tts1cgx8.fsf@48ers.dk> (raw)
In-Reply-To: <20230806214236.72d4cb2d@windsurf> (Thomas Petazzoni via buildroot's message of "Sun, 6 Aug 2023 21:42:36 +0200")
>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:
> Hello Andreas,
> On Wed, 5 Oct 2022 11:10:29 +0200
> Andreas Ziegler <br015@umbiko.net> wrote:
>> Signed-off-by: Andreas Ziegler <br015@umbiko.net>
> I've extended this explanation with some details on when the issue was
> introduced:
> package/mpd: fix reversed logic in tcp disable
> In commit 54b9008d482923131191da75f09966483f4ecac1 ("package/mpd: bump
> to version 0.21.11"), mpd was migrated from using the autotools build
> system to the meson build system.
> As part of this, the BR2_PACKAGE_MPD_TCP was incorrectly modified,
> leading BR2_PACKAGE_MPD_TCP disabled to actually enable TCP, and
> BR2_PACKAGE_MPD_TCP enabled to not explicitly enable TCP support.
> This commit fixes that by handling this option in the common way.
> Signed-off-by: Andreas Ziegler <br015@umbiko.net>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed to 2023.02.x and 2023.05.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-09-11 7:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 13:22 [Buildroot] [PATCH 1/1] package/mpd: explicitly disable features to avoid collision with host packages Andreas Ziegler
2022-04-04 17:38 ` Arnout Vandecappelle
2022-04-08 13:22 ` Andreas Ziegler
2022-04-09 15:41 ` [Buildroot] User-visible Config.in feature sub-options [was: Re: [PATCH 1/1] package/mpd: explicitly disable features to avoid collision with host packages] Arnout Vandecappelle
2022-04-09 16:09 ` Yann E. MORIN
2022-04-10 5:44 ` Andreas Ziegler
2022-04-21 14:45 ` Andreas Ziegler
2022-10-05 9:10 ` [Buildroot] [PATCH v2 0/4] User-visible Config.in feature sub-options Andreas Ziegler
2022-10-05 9:10 ` [Buildroot] [PATCH v2 1/4] package/mpd: fix reversed logic in tcp disable Andreas Ziegler
2023-08-06 19:42 ` Thomas Petazzoni via buildroot
2023-09-11 7:22 ` Peter Korsgaard [this message]
2022-10-05 9:10 ` [Buildroot] [PATCH v2 2/4] package/mpd: add/enhance (kconfig + code) comments Andreas Ziegler
2023-08-06 19:45 ` Thomas Petazzoni via buildroot
2023-08-08 8:14 ` Andreas Ziegler
2022-10-05 9:10 ` [Buildroot] [PATCH v2 3/4] package/mpd: introduce id3tag feature dependency Andreas Ziegler
2023-08-06 19:46 ` Thomas Petazzoni via buildroot
2023-09-11 7:23 ` Peter Korsgaard
2022-10-05 9:10 ` [Buildroot] [PATCH v2 4/4] package/mpd: introduce sub-options for expat and yajl Andreas Ziegler
2023-08-06 20:45 ` Thomas Petazzoni via buildroot
2023-09-11 7:23 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tts1cgx8.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=br015@umbiko.net \
--cc=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.