From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
To: Zhengchao Shao <shaozhengchao@huawei.com>
Cc: <netdev@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <richardcochran@gmail.com>,
<saeedm@nvidia.com>, <leon@kernel.org>, <lkayal@nvidia.com>,
<tariqt@nvidia.com>, <gal@nvidia.com>, <vadfed@meta.com>,
<ayal@nvidia.com>, <eranbe@nvidia.com>, <weiyongjun1@huawei.com>,
<yuehaibing@huawei.com>
Subject: Re: [PATCH net 2/2] net/mlx5e: fix memory leak in mlx5e_ptp_open
Date: Wed, 28 Jun 2023 23:23:10 -0700 [thread overview]
Message-ID: <87ttuqn5wx.fsf@nvidia.com> (raw)
In-Reply-To: <20230629024642.2228767-3-shaozhengchao@huawei.com> (Zhengchao Shao's message of "Thu, 29 Jun 2023 10:46:42 +0800")
On Thu, 29 Jun, 2023 10:46:42 +0800 Zhengchao Shao <shaozhengchao@huawei.com> wrote:
> When kvzalloc_node or kvzalloc failed in mlx5e_ptp_open, the memory
> pointed by "c" or "cparams" is not freed, which can lead to a memory
> leak. Fix by freeing the array in the error path.
Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
prev parent reply other threads:[~2023-06-29 6:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 2:46 [PATCH net 0/2] fix two memory leak issues for mlx5en driver Zhengchao Shao
2023-06-29 2:46 ` [PATCH net 1/2] net/mlx5e: fix memory leak in mlx5e_fs_tt_redirect_any_create Zhengchao Shao
2023-06-29 12:05 ` Simon Horman
2023-06-29 18:18 ` Rahul Rameshbabu
2023-06-30 1:27 ` shaozhengchao
2023-06-29 2:46 ` [PATCH net 2/2] net/mlx5e: fix memory leak in mlx5e_ptp_open Zhengchao Shao
2023-06-29 6:08 ` Gal Pressman
2023-06-29 6:23 ` Rahul Rameshbabu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttuqn5wx.fsf@nvidia.com \
--to=rrameshbabu@nvidia.com \
--cc=ayal@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eranbe@nvidia.com \
--cc=gal@nvidia.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lkayal@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=saeedm@nvidia.com \
--cc=shaozhengchao@huawei.com \
--cc=tariqt@nvidia.com \
--cc=vadfed@meta.com \
--cc=weiyongjun1@huawei.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.