All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Christoph Hellwig <hch@lst.de>,
	tytso@mit.edu, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: set FMODE_CAN_ODIRECT instead of a dummy direct_IO method
Date: Tue, 13 Jun 2023 19:27:23 +0530	[thread overview]
Message-ID: <87ttvb5ut8.fsf@doe.com> (raw)
In-Reply-To: <20230613054700.GA14648@lst.de>

Christoph Hellwig <hch@lst.de> writes:

> On Tue, Jun 13, 2023 at 11:00:19AM +0530, Ritesh Harjani wrote:
>> why do we require .direct_IO function op for any of the dax_aops?
>> IIUC, any inode if it supports DAX i.e. IS_DAX(inode), then it takes the
>> separate path in file read/write iter path.
>>
>> so it should never do ->direct_IO on an inode which supports DAX right?
>
> do_dentry_open rejects opens with O_DIRECT if FMODE_CAN_ODIRECT is
> not set.  So we either needs to set that manually or because there is a
> ->direct_IO if we want to keep supporting O_DIRECT opens for DAX
> files, which we've traditionally supported.

Ok, so for DAX it was mainly to support file opens with O_DIRECT semantics.

Thanks
-ritesh

      reply	other threads:[~2023-06-13  8:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-12  5:37 [PATCH] ext4: set FMODE_CAN_ODIRECT instead of a dummy direct_IO method Christoph Hellwig
2023-06-13  5:30 ` Ritesh Harjani
2023-06-13  5:47   ` Christoph Hellwig
2023-06-13 13:57     ` Ritesh Harjani [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttvb5ut8.fsf@doe.com \
    --to=ritesh.list@gmail.com \
    --cc=hch@lst.de \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.