From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
netdev@vger.kernel.org, sasha.neftin@intel.com,
richardcochran@gmail.com,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Naama Meir <naamax.meir@linux.intel.com>
Subject: Re: [PATCH net 2/4] igc: Check if hardware TX timestamping is enabled earlier
Date: Fri, 02 Jun 2023 10:56:40 -0700 [thread overview]
Message-ID: <87ttvpsq7b.fsf@intel.com> (raw)
In-Reply-To: <20230601205516.7322d9e3@kernel.org>
Jakub Kicinski <kuba@kernel.org> writes:
> On Thu, 01 Jun 2023 14:21:35 -0700 Vinicius Costa Gomes wrote:
>> > AFAICT the cancel / cleanup path is not synchronized (I mean for
>> > accesses to adapter->tstamp_config) so this looks racy to me :(
>>
>> As far as I can see, the racy behavior wasn't introduced here, can I
>> propose the fix as a follow up patch? Or do you prefer that I re-spin
>> this series?
>
> I think respin would be better, you're rejigging the synchronization
> here, who knows if you won't have to rejig differently to cover this
> case.
Makes sense. Will do that.
Cheers,
--
Vinicius
next prev parent reply other threads:[~2023-06-02 17:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 17:49 [PATCH net 0/4][pull request] igc: TX timestamping fixes Tony Nguyen
2023-05-30 17:49 ` [PATCH net 1/4] igc: Fix race condition in PTP tx code Tony Nguyen
2023-06-19 7:27 ` naamax.meir
2023-05-30 17:49 ` [PATCH net 2/4] igc: Check if hardware TX timestamping is enabled earlier Tony Nguyen
2023-06-01 6:10 ` Jakub Kicinski
2023-06-01 21:21 ` Vinicius Costa Gomes
2023-06-02 3:55 ` Jakub Kicinski
2023-06-02 17:56 ` Vinicius Costa Gomes [this message]
2023-05-30 17:49 ` [PATCH net 3/4] igc: Retrieve TX timestamp during interrupt handling Tony Nguyen
2023-06-05 11:16 ` Marc Kleine-Budde
2023-06-05 18:11 ` Vinicius Costa Gomes
2023-05-30 17:49 ` [PATCH net 4/4] igc: Add workaround for missing timestamps Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttvpsq7b.fsf@intel.com \
--to=vinicius.gomes@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=naamax.meir@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=sasha.neftin@intel.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.