From: Thomas Gleixner <tglx@linutronix.de>
To: linux-kernel@vger.kernel.org, mm-commits@vger.kernel.org,
adobriyan@gmail.com, akpm@linux-foundation.org
Subject: Re: + fix-mult_frac-multiple-argument-evaluation-bug.patch added to mm-nonmm-unstable branch
Date: Tue, 23 May 2023 01:45:40 +0200 [thread overview]
Message-ID: <87ttw4udzv.ffs@tglx> (raw)
In-Reply-To: <20230522211514.E0037C4339C@smtp.kernel.org>
On Mon, May 22 2023 at 14:15, Andrew Morton wrote:
> ------------------------------------------------------
> From: Alexey Dobriyan <adobriyan@gmail.com>
> Subject: include/linux/math.h: fix mult_frac() multiple argument evaluation bug
> Date: Sat, 20 May 2023 21:25:19 +0300
>
> mult_frac() evaluates _all_ arguments multiple times in the body.
I'm not opposed to the patch, but to the description.
Multiple evaluation is not a bug per se.
Unless there is a reasonable explanation for the alleged bug this is
just a cosmetic exercise.
Changelogs have to be self explanatory and if the shortlog, aka
$subject, claims "bug" then there has to be a reasonable explanation
what the actual bug is.
Seriously.
All this is documented, but obviously documention for changelogs and the
acceptance of patches is just there to be ignored, right?
Thanks,
tglx
next prev parent reply other threads:[~2023-05-23 0:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 21:15 + fix-mult_frac-multiple-argument-evaluation-bug.patch added to mm-nonmm-unstable branch Andrew Morton
2023-05-22 23:45 ` Thomas Gleixner [this message]
2023-05-23 8:48 ` Alexey Dobriyan
2023-05-23 10:41 ` Thomas Gleixner
-- strict thread matches above, loose matches on Subject: below --
2023-05-19 20:53 Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttw4udzv.ffs@tglx \
--to=tglx@linutronix.de \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.