All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Cc: alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>
Subject: Re: [PATCH 5/7] ALSA: emu10k1: centralize freeing PCM voices
Date: Thu, 18 May 2023 16:53:19 +0200	[thread overview]
Message-ID: <87ttw9hesg.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230518140947.3725394-6-oswald.buddenhagen@gmx.de>

On Thu, 18 May 2023 16:09:45 +0200,
Oswald Buddenhagen wrote:
> -static int snd_emu10k1_pcm_channel_alloc(struct snd_emu10k1_pcm * epcm, int voices)
> +static void snd_emu10k1_pcm_free_voices(struct snd_emu10k1_pcm *epcm)
>  {
> -	int err, i;
> -
> -	for (i = 0; i < ARRAY_SIZE(epcm->voices); i++) {
> +	for (unsigned i = 0; i < ARRAY_SIZE(epcm->voices); i++) {

We don't use this style.  Declare the variable outside the for().

Also, as usual, it'd be still helpful if you show this is merely a
code simplification without any functional change in the commit log.


thanks,

Takashi

  reply	other threads:[~2023-05-18 14:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-18 14:09 [PATCH 0/7] ALSA: emu10k1: refactoring of the playback voice management Oswald Buddenhagen
2023-05-18 14:09 ` [PATCH 1/7] ALSA: emu10k1: simplify freeing synth voices Oswald Buddenhagen
2023-05-18 14:09 ` [PATCH 2/7] ALSA: emu10k1: don't forget to reset reclaimed " Oswald Buddenhagen
2023-05-18 14:09 ` [PATCH 3/7] ALSA: emu10k1: improve voice status display in /proc Oswald Buddenhagen
2023-05-18 14:09 ` [PATCH 4/7] ALSA: emu10k1: make freeing untouched playback voices cheap Oswald Buddenhagen
2023-05-18 14:09 ` [PATCH 5/7] ALSA: emu10k1: centralize freeing PCM voices Oswald Buddenhagen
2023-05-18 14:53   ` Takashi Iwai [this message]
2023-05-19 10:43     ` Oswald Buddenhagen
2023-05-19 11:04       ` Takashi Iwai
2023-05-19 11:53         ` Oswald Buddenhagen
2023-05-19 12:22           ` Takashi Iwai
2023-05-18 14:09 ` [PATCH 6/7] ALSA: emu10k1: make snd_emu10k1_voice_alloc() assign voices' epcm Oswald Buddenhagen
2023-05-18 14:09 ` [PATCH 7/7] ALSA: emu10k1: revamp playback voice allocator Oswald Buddenhagen
2023-05-18 14:58 ` [PATCH 0/7] ALSA: emu10k1: refactoring of the playback voice management Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttw9hesg.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=oswald.buddenhagen@gmx.de \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.