All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: "linux-wireless\@vger.kernel.org"
	<linux-wireless@vger.kernel.org>,
	"Bernie Huang" <phhuang@realtek.com>,
	"arnd\@arndb.de" <arnd@arndb.de>
Subject: Re: rtw88/rtw89: command/event structure handling
Date: Mon, 03 Apr 2023 21:06:46 +0300	[thread overview]
Message-ID: <87ttxwalhl.fsf@kernel.org> (raw)
In-Reply-To: <84e5fadd204807a6de84376f76d405a63198e055.camel@realtek.com> (Ping-Ke Shih's message of "Mon, 3 Apr 2023 14:09:51 +0000")

Ping-Ke Shih <pkshih@realtek.com> writes:

>> > Downside of course is that there's quite a lot of boilerplate code but I
>> > still consider that positives outweight the negatives. Thoughts?
>> > 
>> > And I'll emphasise that this is not a blocker for anything but it would
>> > be nice to clean this up both in rtw88 and rtw89 at some point, if we
>> > can.
>
> Since they will be a lot of works and I have a lot of local patches on
> hand, can I apply these rules to the patches and submit them ahead? 
> Until all things or a bunch of conversion are completed (maybe weeks or
> one or two months later), I can submit patches that only convert
> these H2C/C2H with new rules.
>
> Does it work to you?

Yes, that's totally fine. No rush with this cleanup. Thanks for working
on this.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2023-04-03 18:07 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-10  3:46 [PATCH 0/5] wifi: rtw89: preparation of multiple interface concurrency support Ping-Ke Shih
2023-03-10  3:46 ` [PATCH 1/5] wifi: rtw89: 8852c: add beacon filter and CQM support Ping-Ke Shih
2023-03-15  8:31   ` Kalle Valo
2023-03-15  8:57     ` Ping-Ke Shih
2023-03-15 11:45       ` Ping-Ke Shih
2023-03-16 12:24         ` Ping-Ke Shih
2023-04-03 10:21       ` rtw88/rtw89: command/event structure handling Kalle Valo
2023-04-03 13:23         ` Kalle Valo
2023-04-03 14:09           ` Ping-Ke Shih
2023-04-03 18:06             ` Kalle Valo [this message]
2023-03-10  3:46 ` [PATCH 2/5] wifi: rtw89: add function to wait for completion of TX skbs Ping-Ke Shih
2023-03-15  8:39   ` Kalle Valo
2023-03-15 12:09     ` Ping-Ke Shih
2023-04-03 10:32       ` Kalle Valo
2023-04-04  2:38         ` Ping-Ke Shih
2023-04-11 13:01           ` Ping-Ke Shih
2023-04-12 13:00             ` Kalle Valo
2023-03-10  3:46 ` [PATCH 3/5] wifi: rtw89: add ieee80211::remain_on_channel ops Ping-Ke Shih
2023-03-10  3:46 ` [PATCH 4/5] wifi: rtw89: add flag check for power state Ping-Ke Shih
2023-03-10  3:46 ` [PATCH 5/5] wifi: rtw89: fix authentication fail during scan Ping-Ke Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttxwalhl.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=arnd@arndb.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=phhuang@realtek.com \
    --cc=pkshih@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.