All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Jiang Jiacheng <jiangjiacheng@huawei.com>
Cc: <qemu-devel@nongnu.org>,  <berrange@redhat.com>,
	 <dgilbert@redhat.com>, <yubihong@huawei.com>,
	 <xiexiangyou@huawei.com>, <zhengchuan@huawei.com>,
	 <linyilu@huawei.com>
Subject: Re: [PATCH 1/3] migration: report migration thread name to libvirt
Date: Mon, 30 Jan 2023 05:19:40 +0100	[thread overview]
Message-ID: <87tu08odr7.fsf@secure.mitica> (raw)
In-Reply-To: <20230120084735.825054-2-jiangjiacheng@huawei.com> (Jiang Jiacheng's message of "Fri, 20 Jan 2023 16:47:33 +0800")

Jiang Jiacheng <jiangjiacheng@huawei.com> wrote:
> Report migration thread name to libvirt in order to
> support query migration thread infomation by its name.
>
> Signed-off-by: Jiang Jiacheng <jiangjiacheng@huawei.com>
> ---
>  migration/migration.c |  3 +++
>  migration/multifd.c   |  5 ++++-
>  qapi/migration.json   | 12 ++++++++++++
>  3 files changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 52b5d39244..b4ce458bb9 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -3955,6 +3955,9 @@ static void *migration_thread(void *opaque)
>      MigThrError thr_error;
>      bool urgent = false;
>  
> +    /* report migration thread name to libvirt */
> +    qapi_event_send_migration_name("live_migration");
> +
>      rcu_register_thread();
>  
>      object_ref(OBJECT(s));

I am not sure about this.
This is not an event, in my point of view.

What is the problem adding it to info migrate or similar?
Looks more logical to me.

Later, Juan.



  reply	other threads:[~2023-01-30  4:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-20  8:47 [RFC PATCH 0/3] migration: support query migration thread information Jiang Jiacheng via
2023-01-20  8:47 ` [PATCH 1/3] migration: report migration thread name to libvirt Jiang Jiacheng via
2023-01-30  4:19   ` Juan Quintela [this message]
2023-01-30 12:48     ` Jiang Jiacheng via
2023-01-20  8:47 ` [PATCH 2/3] migration: implement query migration threadinfo by name Jiang Jiacheng via
2023-01-30  4:27   ` Juan Quintela
2023-01-30 12:48     ` Jiang Jiacheng via
2023-01-30 14:03       ` Juan Quintela
2023-01-31 13:00         ` Jiang Jiacheng via
2023-01-31 16:33           ` Juan Quintela
2023-01-20  8:47 ` [PATCH 3/3] migration: save/delete migration thread info Jiang Jiacheng via
2023-01-30  4:28   ` Juan Quintela
2023-01-30 12:49     ` Jiang Jiacheng via
2023-01-30 14:04       ` Juan Quintela
2023-01-31 13:00         ` Jiang Jiacheng via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tu08odr7.fsf@secure.mitica \
    --to=quintela@redhat.com \
    --cc=berrange@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=jiangjiacheng@huawei.com \
    --cc=linyilu@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=xiexiangyou@huawei.com \
    --cc=yubihong@huawei.com \
    --cc=zhengchuan@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.