Re: [PATCH] ath10k: snoc: enable threaded napi on WCN3990

From: Kalle Valo <kvalo@kernel.org>
To: Abhishek Kumar <kuabhs@chromium.org>
Cc: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>,
	 ath10k@lists.infradead.org,  linux-wireless@vger.kernel.org,
	 linux-kernel@vger.kernel.org,  netdev@vger.kernel.org,
	 "David S. Miller" <davem@davemloft.net>,
	 Eric Dumazet <edumazet@google.com>,
	 Jakub Kicinski <kuba@kernel.org>,
	 Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH] ath10k: snoc: enable threaded napi on WCN3990
Date: Thu, 12 Jan 2023 12:15:42 +0200	[thread overview]
Message-ID: <87tu0wcb3l.fsf@kernel.org> (raw)
In-Reply-To: <CACTWRwt7oQrCyHf=ZF6dW8TtRhOfa14XMZW39cYZWi4hhszcqg@mail.gmail.com> (Abhishek Kumar's message of "Wed, 28 Dec 2022 16:01:38 -0800")

Abhishek Kumar <kuabhs@chromium.org> writes:

>> > --- a/drivers/net/wireless/ath/ath10k/snoc.c
>> > +++ b/drivers/net/wireless/ath/ath10k/snoc.c
>> > @@ -927,6 +927,9 @@ static int ath10k_snoc_hif_start(struct ath10k *ar)
>> >
>> >       bitmap_clear(ar_snoc->pending_ce_irqs, 0, CE_COUNT_MAX);
>> >
>> > +     if (ar->hw_params.enable_threaded_napi)
>> > +             dev_set_threaded(&ar->napi_dev, true);
>> > +
>>
>> Since this is done in the API specific to WCN3990, we do not need
>> hw_param for this.
>
> Just so that I am clear, are you suggesting to enable this by default
> in snoc.c, similar to what you did in
>
> https://lore.kernel.org/all/20220905071805.31625-2-quic_mpubbise@quicinc.com/
>
> If my understanding is correct and there is no objection, I can remove
> hw_param and enable it by default on snoc.c . I used hw_param because,
> as I see it, threaded NAPI can have some adverse effect on the cache
> utilization and power.

WCN3990 is the only device using SNOC bus so the hw_param is not needed.
It's safe to call dev_set_threaded() in ath10k_snoc_hif_start()
unconditionally as it only affects WCN3990.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k