From: Kalle Valo <kvalo@kernel.org>
To: Jaewan Kim <jaewan@google.com>
Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3] iw: info: fix bug reading preambles and bandwidths
Date: Mon, 09 Jan 2023 16:55:32 +0200 [thread overview]
Message-ID: <87tu0zhi57.fsf@kernel.org> (raw)
In-Reply-To: <20221227010034.1399587-1-jaewan@google.com> (Jaewan Kim's message of "Tue, 27 Dec 2022 10:00:34 +0900")
Jaewan Kim <jaewan@google.com> writes:
> Preambles and bandwidths values are considered as bit shifts
> when they're are used for capabilities.
>
> Signed-off-by: Jaewan Kim <jaewan@google.com>
> Reviewed-by: Kalle Valo <kvalo@kernel.org>
I didn't provide you a Reviewed-by tag[1] during my review, please don't
create such tags yourself. For example, in this case I didn't review the
patch in detail so I'm not comfortable giving you my Reviewed-by tag.
The general idea is that you only copy paste the tag when someone gives
you one, you don't create them on your own. I think Reported-by is only
exception but there might be others.
[1] https://lore.kernel.org/linux-wireless/87ili3kfdr.fsf@kernel.org/
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-01-09 14:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 13:42 [PATCH] iw: info: fix bug reading preamble and bandwidths Jaewan Kim
2022-12-20 13:47 ` [PATCH v2] " Jaewan Kim
2022-12-22 8:32 ` Kalle Valo
2022-12-27 1:00 ` [PATCH v3] iw: info: fix bug reading preambles " Jaewan Kim
2023-01-09 14:55 ` Kalle Valo [this message]
2023-01-09 15:12 ` Jaewan Kim
2023-01-09 15:14 ` [PATCH v4] " Jaewan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu0zhi57.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=jaewan@google.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.