From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7481C4332F for ; Wed, 16 Nov 2022 15:24:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1215C10E1A3; Wed, 16 Nov 2022 15:24:01 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id CE79410E1A3 for ; Wed, 16 Nov 2022 15:23:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668612238; x=1700148238; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=+izVJFEtstLEKAeJc/eZaesc5tWF6qBZ3EjMC/f5lS8=; b=aUvY1PuvMVpknX2JkSvBpl+Ztan9RjuY2ipLcc4331SNopNAqY6ojRq8 dMPqJc+smm7LDo0GQ3DQW+JVSgxpQVJks/jw2gczwSOSjeFU/kDFBea1M 3aFBVlbbD7YxQOS2gUGk9yNaobx3fYMuHBnS0Iamn/PGROTVgCqcuLznR ivtfYkV/xS4p2fPW1XrFs2k+nTcH5J/wc1wrbS4F6Ci3naN9roPRTU+5E gwydncv8sb1E3PN/QcW6b0FAhG5ofvqF56FK3nZhCtbA/s0nUldfLDT71 SndaRFyiYP7seKFcwcjir7ySuuyVNLBTPWySMhSsWvQoWAyI8LFwhqYTl w==; X-IronPort-AV: E=McAfee;i="6500,9779,10533"; a="314385273" X-IronPort-AV: E=Sophos;i="5.96,167,1665471600"; d="scan'208";a="314385273" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2022 07:23:57 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10533"; a="633661234" X-IronPort-AV: E=Sophos;i="5.96,167,1665471600"; d="scan'208";a="633661234" Received: from dariofax-mobl.amr.corp.intel.com (HELO localhost) ([10.252.59.5]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2022 07:23:54 -0800 From: Jani Nikula To: Maxime Ripard Subject: Re: [PATCH 2/3] drm/tests: helpers: Add module infos In-Reply-To: <20221116151214.pnwszhhbassplbr3@houat> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20221116091712.1309651-1-maxime@cerno.tech> <20221116091712.1309651-2-maxime@cerno.tech> <6dba9207-5ba2-5c73-e575-a7a86a2b9520@riseup.net> <874juz2kyk.fsf@intel.com> <20221116151214.pnwszhhbassplbr3@houat> Date: Wed, 16 Nov 2022 17:23:51 +0200 Message-ID: <87tu2y2a9k.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Rothwell , Florian Fainelli , David Airlie , dri-devel@lists.freedesktop.org, =?utf-8?Q?Ma=C3=ADra?= Canal , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Thomas Zimmermann , Daniel Vetter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 16 Nov 2022, Maxime Ripard wrote: > On Wed, Nov 16, 2022 at 01:32:51PM +0200, Jani Nikula wrote: >> On Wed, 16 Nov 2022, Ma=C3=ADra Canal wrote: >> > Hi Maxime, >> > >> > On 11/16/22 06:17, Maxime Ripard wrote: >> >> The MODULE_LICENSE macro is missing from the kunit helpers file, thus >> >> leading to a build error. >> >>=20 >> >> Let's introduce it along with MODULE_AUTHOR. >> >>=20 >> >> Fixes: 44a3928324e9 ("drm/tests: Add Kunit Helpers") >> >> Reported-by: Stephen Rothwell >> >> Signed-off-by: Maxime Ripard >> > >> > It would be nice to add the SPDX-License-Identifier tag in the source >> > file as well. Besides that, >>=20 >> It's not just nice, it's basically mandatory to add license boilerplate. >>=20 >> Checkpatch would've warned about this. And actually about a lot of stuff >> in the series. > > Right, sorry about that. I'll send additional patches to address the > issues already in. > >> (And our CI checkpatch did too, although we don't send the replies to >> the world, just intel-gfx [1].) > > I'm not sure how helpful it is though if the author is not a recipient > of the report It actually should be, but I have absolutely no idea why in this case it decided to do To: "Mateusz Kwiatkowski" instead of you. Baffled. BR, Jani. --=20 Jani Nikula, Intel Open Source Graphics Center