From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [GIT PULL] ASoC fixes for v5.19-rc4-2
Date: Fri, 15 Jul 2022 12:31:29 +0200 [thread overview]
Message-ID: <87tu7ivf9a.wl-tiwai@suse.de> (raw)
In-Reply-To: <YtFAtL9hdT57Hb4n@sirena.org.uk>
On Fri, 15 Jul 2022 12:25:56 +0200,
Mark Brown wrote:
>
> On Fri, Jul 15, 2022 at 08:44:44AM +0200, Takashi Iwai wrote:
> > Mark Brown wrote:
>
> > > As covered in the second revert commit in this pull request the version
> > > of the BCLK muxing that's in v5.19 is causing issues, let's just revert
> > > it and wait for the more complete support in v5.20 instead.
>
> > Hmm, this revert itself is fine, but the PR contains way too many
> > changes than expected as a *very* late stage. Are all those really
> > mandatory as 5.19 fixes? e.g. regressions that have been introduced
> > in 5.19-rc or such? Otherwise I prefer cherry-picking only the really
> > needed one for now for the merge to 5.19-final.
>
> Ah, I suspect what's gone wrong here is that my script generated it
> against Linus' tree but you'd not yet sent your pull request since the
> last time I sent you changes so it has all the changes you already have
> in it. Regenerating it against asoc-fix-v5.19-rc4 gives:
>
> The following changes since commit fc976f5629afb4160ee77798b14a693eac903ffd:
>
> ASoC: Intel: Skylake: Correct the handling of fmt_config flexible array (2022-07-07 17:16:40 +0100)
>
> are available in the Git repository at:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-fix-v5.19-rc4-2
>
> for you to fetch changes up to 1e347f861da8ddb17e1d1b3113cb6c188e0de3e5:
>
> ASoC: rockchip-i2s: Undo BCLK pinctrl changes (2022-07-14 13:25:52 +0100)
>
> ----------------------------------------------------------------
> ASoC: Drop Rockchip BCLK management for v5.19
>
> As covered in the second revert commit in this pull request the version
> of the BCLK muxing that's in v5.19 is causing issues, let's just revert
> it and wait for the more complete support in v5.20 instead.
>
> ----------------------------------------------------------------
> Alexandru Elisei (1):
> ASoC: rockchip: i2s: Fix NULL pointer dereference when pinctrl is not found
>
> Mark Brown (1):
> ASoC: rockchip-i2s: Undo BCLK pinctrl changes
OK, that relieved me. Now pulled to for-linus branch.
Thanks!
Takashi
next prev parent reply other threads:[~2022-07-15 10:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 17:59 [GIT PULL] ASoC fixes for v5.19-rc4-2 Mark Brown
2022-07-15 6:44 ` Takashi Iwai
2022-07-15 10:25 ` Mark Brown
2022-07-15 10:31 ` Takashi Iwai [this message]
2022-07-15 10:35 ` Takashi Iwai
2022-07-15 11:28 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu7ivf9a.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.