From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1761CCA480 for ; Tue, 28 Jun 2022 13:33:50 +0000 (UTC) Received: from localhost ([::1]:46796 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o6BLh-0005UL-Rr for qemu-devel@archiver.kernel.org; Tue, 28 Jun 2022 09:33:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48362) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6BDk-0006cg-Jr for qemu-devel@nongnu.org; Tue, 28 Jun 2022 09:25:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:20646) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6BDj-0002Ve-5H for qemu-devel@nongnu.org; Tue, 28 Jun 2022 09:25:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656422733; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9EdgiFB5Q9QlTk+EYMiVBdPyWqNbaaMSB+OkL/Eiuak=; b=EDrHoQfUGIB1NJCh7qv1buXMXaHlExEV26HKoDZTmBTvUELUUVLY4sCIAZEtAKXGByNluu nmUeTbMI9pyxFKXC2VnwvP7luIVW3FfeqtPsFLr1CQI3OTXVDIhpGu/xySDJ8NI/+vXkCv UIyIbhX6HKf2NKUwQIUdRuLtI7u4Zjc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-607-yM2GYev3MjKwTIwZmqnYyQ-1; Tue, 28 Jun 2022 09:25:32 -0400 X-MC-Unique: yM2GYev3MjKwTIwZmqnYyQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BABB585A581; Tue, 28 Jun 2022 13:25:31 +0000 (UTC) Received: from localhost (unknown [10.39.193.129]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 72DB72166B26; Tue, 28 Jun 2022 13:25:31 +0000 (UTC) From: Cornelia Huck To: Thomas Huth , qemu-s390x@nongnu.org, Christian Borntraeger , Eric Farman Cc: qemu-devel@nongnu.org, Janosch Frank Subject: Re: [PATCH 07/12] pc-bios/s390-ccw/virtio: Read device config after feature negotiation In-Reply-To: <20220628131032.213986-8-thuth@redhat.com> Organization: Red Hat GmbH References: <20220628131032.213986-1-thuth@redhat.com> <20220628131032.213986-8-thuth@redhat.com> User-Agent: Notmuch/0.36 (https://notmuchmail.org) Date: Tue, 28 Jun 2022 15:25:30 +0200 Message-ID: <87tu84c439.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 Received-SPF: pass client-ip=170.10.129.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Jun 28 2022, Thomas Huth wrote: > Feature negotiation should be done first, since some fields in the > config area can depend on the negotiated features and thus should > rather be read afterwards. > > While we're at it, also adjust the error message here a little bit > (the code is nowadays used for non-block virtio devices, too). > > Signed-off-by: Thomas Huth > --- > pc-bios/s390-ccw/virtio.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) Reviewed-by: Cornelia Huck